Issues in ActiveRoute.php (master) - Issues in master - zengineOrg/active-route - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/ActiveRoute.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Zengine\ActiveRoute;

use Illuminate\Routing\Router as Route;
use Illuminate\Routing\UrlGenerator as URL;

class ActiveRoute
{
    protected $route;

    protected $url;

    public function __construct(Route $route, URL $url)
    {
        $this->route = $route;
        $this->url = $url;
    }

    /**
     * Compares given route name with current route name.
     * Any section of the route name can be replaced with a * wildcard.
     * Example: user.*.
     *
     * @param  string $routeName
     * @param  string $output
     *
     * @return bool
     */
    public function isActiveRoute($routeName, $output = 'active')
    {
        if (strpos($routeName, '*') !== false) {
            // Quote all RE characters, then undo the quoted '*' characters to match any
            // sequence of non-'.' characters.
            $regex = '/^'.str_replace(preg_quote('*'), '[^.]*?', preg_quote($routeName, '/')).'$/';
            if (preg_match($regex, $this->route->currentRouteName())) {
                return $output;
            }
        } elseif ($this->route->currentRouteName() == $routeName) {
            return $output;
        }
    }

    /**
     * Compares given URL with current URL.
     *
     * @param  string $url
     * @param  string $output
     *
     * @return bool
     */
    public function isActiveURL($url, $output = 'active')
    {
        if ($this->url->current() == $this->url->to($url)) {
            return $output;
        }
    }

    /**
     * Detects if the given string is found in the current URL.
     *
     * @param  string $string
     * @param  string $output
     *
     * @return bool
     */
    public function isActiveMatch($string, $output = 'active')
    {
        if (strpos($this->url->current(), $string) !== false) {
            return $output;
        }
    }

    /**
     * Compares given array of route names with current route name.
     *
     * @param  array  $routeNames
     * @param  string $output
     *
     * @return bool
     */
    public function areActiveRoutes(array $routeNames, $output = 'active')
    {
        foreach ($routeNames as $routeName) {
            if ($this->isActiveRoute($routeName, true)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                return $output;
            }
        }
    }

    /**
     * Compares given array of URLs with current URL.
     *
     * @param  array  $urls
     * @param  string $output
     *
     * @return bool
     */
    public function areActiveURLs(array $urls, $output = 'active')
    {
        foreach ($urls as $url) {
            if ($this->isActiveURL($url, true)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                return $output;
            }
        }
    }
}


1			<?php
2
3			namespace Zengine\ActiveRoute;
4
5			use Illuminate\Routing\Router as Route;
6			use Illuminate\Routing\UrlGenerator as URL;
7
8			class ActiveRoute
9			{
10			protected $route;
11
12			protected $url;
13
14			public function __construct(Route $route, URL $url)
15			{
16			$this->route = $route;
17			$this->url = $url;
18			}
19
20			/**
21			* Compares given route name with current route name.
22			* Any section of the route name can be replaced with a * wildcard.
23			* Example: user.*.
24			*
25			* @param string $routeName
26			* @param string $output
27			*
28			* @return bool
29			*/
30			public function isActiveRoute($routeName, $output = 'active')
31			{
32			if (strpos($routeName, '*') !== false) {
33			// Quote all RE characters, then undo the quoted '*' characters to match any
34			// sequence of non-'.' characters.
35			$regex = '/^'.str_replace(preg_quote(''), '[^.]?', preg_quote($routeName, '/')).'$/';
36			if (preg_match($regex, $this->route->currentRouteName())) {
37			return $output;
38			}
39			} elseif ($this->route->currentRouteName() == $routeName) {
40			return $output;
41			}
42			}
43
44			/**
45			* Compares given URL with current URL.
46			*
47			* @param string $url
48			* @param string $output
49			*
50			* @return bool
51			*/
52			public function isActiveURL($url, $output = 'active')
53			{
54			if ($this->url->current() == $this->url->to($url)) {
55			return $output;
56			}
57			}
58
59			/**
60			* Detects if the given string is found in the current URL.
61			*
62			* @param string $string
63			* @param string $output
64			*
65			* @return bool
66			*/
67			public function isActiveMatch($string, $output = 'active')
68			{
69			if (strpos($this->url->current(), $string) !== false) {
70			return $output;
71			}
72			}
73
74			/**
75			* Compares given array of route names with current route name.
76			*
77			* @param array $routeNames
78			* @param string $output
79			*
80			* @return bool
81			*/
82			public function areActiveRoutes(array $routeNames, $output = 'active')
83			{
84			foreach ($routeNames as $routeName) {
85			if ($this->isActiveRoute($routeName, true)) {
			0 ignored issues – show Documentation introduced 2019-04-01 10:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug Best Practice introduced 2019-04-01 10:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->isActiveRoute($routeName, true)` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
86			return $output;
87			}
88			}
89			}
90
91			/**
92			* Compares given array of URLs with current URL.
93			*
94			* @param array $urls
95			* @param string $output
96			*
97			* @return bool
98			*/
99			public function areActiveURLs(array $urls, $output = 'active')
100			{
101			foreach ($urls as $url) {
102			if ($this->isActiveURL($url, true)) {
			0 ignored issues – show Documentation introduced 2019-04-01 10:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug Best Practice introduced 2019-04-01 10:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->isActiveURL($url, true)` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
103			return $output;
104			}
105			}
106			}
107			}
108

zengineOrg / active-route

Issues (4)

Security Analysis not enabled

src/ActiveRoute.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like