Telephone::getE164() - Code Metrics - Inspection of "first commit" - zenapply/php-telephone - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b6c9d3...371ad5 )

by Tyler

created 2016-05-15 02:58 UTC

Telephone::getE164() A

↳ Parent: Telephone

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Zenapply\DataTypes;

use libphonenumber\PhoneNumberUtil as Util;
use libphonenumber\PhoneNumberFormat as Format;
use libphonenumber\PhoneNumberType as Type;

/**
 * @see https://en.wikipedia.org/wiki/Telephone_numbering_plan#Structure
 */
class Telephone 
{
    //Telephone variations
    protected $format_E164;
    protected $format_international;
    protected $format_national;
    protected $format_RFC3966;

    //Telephone structure
    protected $country_code;
    protected $area_code;
    protected $subscriber_code;
    protected $extension;

    //Telephone extras
    protected $region;
    protected $input;

    //Telephone types
    protected $typeMap = [
        Type::FIXED_LINE => 'FIXED_LINE',
        Type::MOBILE => 'MOBILE',
        Type::FIXED_LINE_OR_MOBILE => 'FIXED_LINE_OR_MOBILE',
        Type::TOLL_FREE => 'TOLL_FREE',
        Type::PREMIUM_RATE => 'PREMIUM_RATE',
        Type::SHARED_COST => 'SHARED_COST',
        Type::VOIP => 'VOIP',
        Type::PERSONAL_NUMBER => 'PERSONAL_NUMBER',
        Type::PAGER => 'PAGER',
        Type::UAN => 'UAN',
        Type::UNKNOWN => 'UNKNOWN',
        Type::EMERGENCY => 'EMERGENCY',
        Type::VOICEMAIL => 'VOICEMAIL',
        Type::SHORT_CODE => 'SHORT_CODE',
        Type::STANDARD_RATE => 'STANDARD_RATE',
    ];

    /**
     * @param string $input  [description]
     * @param string $region [description]
     */
    public function __construct($input,$region = 'US')
    {
        $this->input = $input;
        $this->region = $region;
        $this->setup();
    }

    /**
     * @return void
     */
    protected function setup()
    {
        $util = Util::getInstance();
        $number = $util->parse($this->input, $this->region);
        
        //Meta
        $this->valid  = $util->isValidNumber($number);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->type   = $this->typeMap[$util->getNumberType($number)];
class MyClass { }

$x = new MyClass();
$x->foo = true;

        //Formats
        $this->format_E164          = $util->format($number, Format::E164);
        $this->format_international = $util->format($number, Format::INTERNATIONAL);
        $this->format_national      = $util->format($number, Format::NATIONAL);
        $this->format_RFC3966       = $util->format($number, Format::RFC3966);
        
        //Get the parts
        $this->country_code = $number->getCountryCode();
        $this->extension    = $number->getExtension();
        $this->area_code    = $this->extractAreaCode();
    }

    protected function extractAreaCode()
    {
        if($this->region === 'US' && $this->isValid()){
            $exp = '/^\+?(1)?\(?(\d{3})\)?(?:\s|\.|\-)?(\d{3})(?:\s|\.|\-)?(\d{4})$/';
            preg_match($exp,$this->format_E164,$matches);
            if(count($matches) >= 2){
                return $matches[2];
            }
        }

        return null;
    }

    /*=====================================
    =            Ouput Methods            =
    =====================================*/

    /**
     * @return string
     */
    public function getRFC3966()
    {
        return $this->format_RFC3966;
    }

    /**
     * @return string
     */
    public function getNational()
    {
        return $this->format_national;
    }

    /**
     * @return string
     */
    public function getInternational()
    {
        return $this->format_international;
    }

    /**
     * @return string
     */
    public function getE164()
    {
        return $this->format_E164;
    }


    /**
     * @return string
     */
    public function getOriginal()
    {
        return $this->input;
    }

    /**
     * @return string
     */
    public function getAreaCode()
    {
        return $this->area_code;
    }

    /**
     * @return string
     */
    public function getCountryCode()
    {
        return $this->country_code;
    }

    /**
     * @return string
     */
    public function getSubscriberCode()
    {
        return $this->subscriber_code;
    }

    /**
     * @return string
     */
    public function isValid()
    {
        return $this->valid;
    }

    /**
     * @return string
     */
    public function __toString()
    {
        return $this->getE164();
    }
    
    /*=====  End of Ouput Methods  ======*/
}

1		<?php
2
3		namespace Zenapply\DataTypes;
4
5		use libphonenumber\PhoneNumberUtil as Util;
6		use libphonenumber\PhoneNumberFormat as Format;
7		use libphonenumber\PhoneNumberType as Type;
8
9		/**
10		* @see https://en.wikipedia.org/wiki/Telephone_numbering_plan#Structure
11		*/
12		class Telephone
13		{
14		//Telephone variations
15		protected $format_E164;
16		protected $format_international;
17		protected $format_national;
18		protected $format_RFC3966;
19
20		//Telephone structure
21		protected $country_code;
22		protected $area_code;
23		protected $subscriber_code;
24		protected $extension;
25
26		//Telephone extras
27		protected $region;
28		protected $input;
29
30		//Telephone types
31		protected $typeMap = [
32		Type::FIXED_LINE => 'FIXED_LINE',
33		Type::MOBILE => 'MOBILE',
34		Type::FIXED_LINE_OR_MOBILE => 'FIXED_LINE_OR_MOBILE',
35		Type::TOLL_FREE => 'TOLL_FREE',
36		Type::PREMIUM_RATE => 'PREMIUM_RATE',
37		Type::SHARED_COST => 'SHARED_COST',
38		Type::VOIP => 'VOIP',
39		Type::PERSONAL_NUMBER => 'PERSONAL_NUMBER',
40		Type::PAGER => 'PAGER',
41		Type::UAN => 'UAN',
42		Type::UNKNOWN => 'UNKNOWN',
43		Type::EMERGENCY => 'EMERGENCY',
44		Type::VOICEMAIL => 'VOICEMAIL',
45		Type::SHORT_CODE => 'SHORT_CODE',
46		Type::STANDARD_RATE => 'STANDARD_RATE',
47		];
48
49		/**
50		* @param string $input [description]
51		* @param string $region [description]
52		*/
53	3	public function __construct($input,$region = 'US')
54		{
55	3	$this->input = $input;
56	3	$this->region = $region;
57	3	$this->setup();
58	3	}
59
60		/**
61		* @return void
62		*/
63	3	protected function setup()
64		{
65	3	$util = Util::getInstance();
66	3	$number = $util->parse($this->input, $this->region);
67
68		//Meta
69	3	$this->valid = $util->isValidNumber($number);
		0 ignored issues – show Bug introduced 2016-05-15 03:03 UTC by Report Bug Copy Issue Report The property `valid` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
70	3	$this->type = $this->typeMap[$util->getNumberType($number)];
		0 ignored issues – show Bug introduced 2016-05-15 03:03 UTC by Report Bug Copy Issue Report The property `type` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
71
72		//Formats
73	3	$this->format_E164 = $util->format($number, Format::E164);
74	3	$this->format_international = $util->format($number, Format::INTERNATIONAL);
75	3	$this->format_national = $util->format($number, Format::NATIONAL);
76	3	$this->format_RFC3966 = $util->format($number, Format::RFC3966);
77
78		//Get the parts
79	3	$this->country_code = $number->getCountryCode();
80	3	$this->extension = $number->getExtension();
81	3	$this->area_code = $this->extractAreaCode();
82	3	}
83
84	3	protected function extractAreaCode()
85		{
86	3	if($this->region === 'US' && $this->isValid()){
87	3	$exp = '/^\+?(1)?\(?(\d{3})\)?(?:\s\|\.\|\-)?(\d{3})(?:\s\|\.\|\-)?(\d{4})$/';
88	3	preg_match($exp,$this->format_E164,$matches);
89	3	if(count($matches) >= 2){
90	3	return $matches[2];
91		}
92		}
93
94		return null;
95		}
96
97		/*=====================================
98		= Ouput Methods =
99		=====================================*/
100
101		/**
102		* @return string
103		*/
104		public function getRFC3966()
105		{
106		return $this->format_RFC3966;
107		}
108
109		/**
110		* @return string
111		*/
112		public function getNational()
113		{
114		return $this->format_national;
115		}
116
117		/**
118		* @return string
119		*/
120		public function getInternational()
121		{
122		return $this->format_international;
123		}
124
125		/**
126		* @return string
127		*/
128		public function getE164()
129		{
130		return $this->format_E164;
131		}
132
133
134		/**
135		* @return string
136		*/
137		public function getOriginal()
138		{
139		return $this->input;
140		}
141
142		/**
143		* @return string
144		*/
145		public function getAreaCode()
146		{
147		return $this->area_code;
148		}
149
150		/**
151		* @return string
152		*/
153		public function getCountryCode()
154		{
155		return $this->country_code;
156		}
157
158		/**
159		* @return string
160		*/
161		public function getSubscriberCode()
162		{
163		return $this->subscriber_code;
164		}
165
166		/**
167		* @return string
168		*/
169	3	public function isValid()
170		{
171	3	return $this->valid;
172		}
173
174		/**
175		* @return string
176		*/
177		public function __toString()
178		{
179		return $this->getE164();
180		}
181
182		/===== End of Ouput Methods ======/
183		}

zenapply / php-telephone

Push — master ( b6c9d3...371ad5 )

Telephone::getE164() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like