Zemit\Mvc\Controller\Rest\Actions\DeleteAction::deleteAction()

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function deleteAction(string|int $id = null): ResponseInterface
    {
        $entity = $this->getSingle($id);

It seems like getSingle() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        
        if (!$entity) {
            return $this->setRestErrorResponse(404);
        }
        
        $delete = $entity->delete();
        $this->view->setVars([

The property view does not exist on Zemit\Mvc\Controller\Rest\Actions\DeleteAction. Did you mean view;?

            'delete' => $delete,
            'single' => $this->expose($entity),

It seems like expose() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            'messages' => $entity->getMessages(),
        ]);
        
        return $this->setRestResponse($delete);
    }