Zemit\Mvc\Controller\Rest\Actions\SaveAction

Complexity

Total Complexity

8

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	saveAction()	0	17	3
A	saveResultHasKey()	0	19	5

<?php

/**
 * This file is part of the Zemit Framework.
 *
 * (c) Zemit Team <contact@zemit.com>
 *
 * For the full copyright and license information, please view the LICENSE.txt
 * file that was distributed with this source code.
 */

namespace Zemit\Mvc\Controller\Rest\Actions;

use Phalcon\Http\ResponseInterface;
use Zemit\Mvc\Controller\AbstractTrait\AbstractInjectable;
use Zemit\Mvc\Controller\Rest\Response;

trait SaveAction
{
    use AbstractInjectable;
    use Response;
    
    /**
     * Saving a record (create & update)
     */
    public function saveAction(?int $id = null): ResponseInterface
    {
        $ret = $this->save($id);

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->view->setVars($ret);

The property view does not exist on Zemit\Mvc\Controller\Rest\Actions\SaveAction. Did you mean view;?

        $saved = $this->saveResultHasKey($ret, 'saved');
        $messages = $this->saveResultHasKey($ret, 'messages');
        
        if (!$saved) {
            if (!$messages) {
                $this->response->setStatusCode(422, 'Unprocessable Entity');

The property response does not exist on Zemit\Mvc\Controller\Rest\Actions\SaveAction. Did you mean response;?

            }
            else {
                $this->response->setStatusCode(400, 'Bad Request');
            }
        }
        
        return $this->setRestResponse($saved);
    }
    
    /**
     * Return true if the record or the records where saved
     * Return false if one record wasn't saved
     * Return null if nothing was saved
     */
    public function saveResultHasKey(array $array, string $key): bool
    {
        $ret = $array[$key] ?? null;
        
        if (isset($array[0])) {
            foreach ($array as $k => $r) {
                if (isset($r[$key])) {
                    if ($r[$key]) {
                        $ret = true;
                    }
                    else {
                        $ret = false;
                        break;
                    }
                }
            }
        }
        
        return (bool)$ret;
    }
}