Zemit\Mvc\Controller\Rest\Actions\ReorderAction

Complexity

Total Complexity

2

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	reorderAction()	0	18	2

<?php

/**
 * This file is part of the Zemit Framework.
 *
 * (c) Zemit Team <contact@zemit.com>
 *
 * For the full copyright and license information, please view the LICENSE.txt
 * file that was distributed with this source code.
 */

namespace Zemit\Mvc\Controller\Rest\Actions;

use Exception;
use Phalcon\Filter\Filter;
use Phalcon\Http\ResponseInterface;
use Zemit\Mvc\Controller\AbstractTrait\AbstractInjectable;
use Zemit\Mvc\Controller\Rest\Response;

trait ReorderAction
{
    use AbstractInjectable;
    use Response;
    
    /**
     * Re-ordering a position
     * @throws Exception
     */
    public function reorderAction(string|int $id = null, int $position = null): ResponseInterface
    {
        $entity = $this->getSingle($id);

It seems like getSingle() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        
        if (!$entity) {
            return $this->setRestErrorResponse(404);
        }
        
        $position ??= $this->getParam('position', [Filter::FILTER_INT]);

It seems like getParam() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        
        $reorder = $entity->reorder($position);
        $this->view->setVars([

The property view does not exist on Zemit\Mvc\Controller\Rest\Actions\ReorderAction. Did you mean view;?

            'reorder' => $reorder,
            'single' => $this->expose($entity),

It seems like expose() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            'messages' => $entity->getMessages(),
        ]);
        
        return $this->setRestResponse($reorder);
    }
}