Task::afterExecuteRoute() - Code Metrics - Inspection of "cli task refactoring (start)" - zemit-cms/core - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 244aa0...8b6dec )

by Julien

created 2023-03-28 06:03 UTC

Task::afterExecuteRoute() D

↳ Parent: Task

Complexity

Conditions	22
Paths	58

Size

Total Lines	82
Code Lines	53

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	506

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	22
eloc	53
nc	58
nop	1
dl	0
loc	82
ccs	0
cts	55
cp	0
crap	506
rs	4.1666
c	1
b	0
f	0

How to fix Long Method Complexity

<?php

/**
 * This file is part of the Zemit Framework.
 *
 * (c) Zemit Team <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE.txt
 * file that was distributed with this source code.
 */

namespace Zemit\Modules\Cli;

use Phalcon\Cli\Dispatcher;
use Phalcon\Version;
use Zemit\Exception\CliException;
use Zemit\Http\StatusCode;
use Zemit\Utils;

class Task extends \Zemit\Cli\Task
{
    
    public string $cliDoc = <<<DOC
Usage:
  php zemit cli <task> <action> [<params> ...]

Options:
  task: build,cache,cron,errors,help,scaffold


DOC;
    
    public function helpAction(): void
    {
        echo $this->cliDoc;
    }
    
    public function mainAction(): ?array
    {
        $this->helpAction();
        
        return null;
    }
    
    public function normalizeResponse(bool $response = true, ?int $code = null, ?string $status = null): array
    {
        $debug = $this->config->path('app.debug') || $this->dispatcher->getParam('debug');
        
        // keep forced status code or set our own
        $statusCode = $this->response->getStatusCode();
        $reasonPhrase = $this->response->getReasonPhrase();
        $code ??= (int)$statusCode ?: 200;
        $status ??= $reasonPhrase ?: StatusCode::getMessage($code);
        
        $view = $this->view->getParamsToView();
        $hash = hash('sha512', json_encode($view));
        
        // set response status code
        $this->response->setStatusCode($code, $status);
        
        $ret = [];
        $ret['api'] = [];
        $ret['api']['version'] = ['0.1'];
        $ret['timestamp'] = date('c');
        $ret['hash'] = $hash;
        $ret['status'] = $status;
        $ret['code'] = $code;
        $ret['response'] = $response;
        $ret['view'] = $view;
        
        if ($debug) {
            $ret['api']['php'] = phpversion();
            $ret['api']['phalcon'] = Version::get();
            $ret['api']['zemit'] = $this->config->path('core.version');
            $ret['api']['core'] = $this->config->path('core.name');
            $ret['api']['app'] = $this->config->path('app.version');
            $ret['api']['name'] = $this->config->path('app.name');
            
            $ret['identity'] = $this->identity ? $this->identity->getIdentity() : null;
            $ret['profiler'] = $this->profiler ? $this->profiler->toArray() : null;
            $ret['dispatcher'] = $this->dispatcher ? $this->dispatcher->toArray() : null;
            $ret['router'] = $this->router ? $this->router->toArray() : null;
            $ret['memory'] = Utils::getMemoryUsage();
        }
        
        return $ret;
    }
    
    /**
     * Handle rest response automagically
     * @param Dispatcher $dispatcher
     * @return void
     * @throws CliException
     */
    public function afterExecuteRoute(Dispatcher $dispatcher): void
    {
        // Merge response into view variables
        $response = $dispatcher->getReturnedValue();
        
        // Quiet output
        $quiet = $this->dispatcher->getParam('quiet');
        if ($quiet) {
            exit(!$response ? 1 : 0);

        }
        
        // Normalize response
        if (is_array($response)) {
            $this->view->setVars($response, true);
                         setVars($response, true);
        }
        else {
            $this->view->setVars((array)$response, true);
        }
        $normalizedResponse = $this->normalizeResponse((bool)$response);
        $dispatcher->setReturnedValue($normalizedResponse);
        
        // Set response
        $verbose = $this->dispatcher->getParam('verbose');
        $ret = $verbose ? $normalizedResponse : $response;
        
        // Format response
        $format = $this->dispatcher->getParam('format');
        $format ??= 'json';
        switch (strtolower($format)) {
            case 'dump':
                dump($ret);
                break;
                
            case 'var_dump':
                var_dump($ret);

                break;
                
            case 'var_export':
                var_export($ret);
                break;
                
            case 'print_r':
                print_r($ret);
                break;
    
            case 'serialize':
                echo serialize($ret);
                break;
            
            case 'json':
                echo json_encode($ret, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE);
                break;
            
            case 'string':
                if (is_string($ret)) {
                    echo $ret;
                }
                elseif (is_bool($ret)) {
                    echo $ret? 'true' : 'false';
                }
                elseif (is_null($ret)) {
                    echo 'null';
                }
                elseif (is_numeric($ret)) {
                    echo $ret;
                }
                else {
                    echo json_encode($ret, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE);
                }
                break;
                
            case 'raw':
                if (is_string($ret) || is_bool($ret) || is_null($ret) || is_numeric($ret)) {
                    echo $ret;
                }
                else {
                    echo json_encode($ret, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE);
                }
                break;
            
            default:
                throw new CliException('Unknown output format `' . $format . '` expected one of the string value: `json` `serialize` `dump` `raw`');
        }
    }
}


zemit-cms / core

Push — master ( 244aa0...8b6dec )

Task::afterExecuteRoute() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like