Test Failed
Pull Request — master (#3)
by
unknown
11:53
created

Rest::formatColumnText()   A

Complexity

Conditions 6
Paths 6

Size

Total Lines 17
Code Lines 10

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 42

Importance

Changes 1
Bugs 0 Features 1
Metric Value
eloc 10
c 1
b 0
f 1
dl 0
loc 17
ccs 0
cts 11
cp 0
rs 9.2222
cc 6
nc 6
nop 1
crap 42
1
<?php
2
/**
3
 * This file is part of the Zemit Framework.
4
 *
5
 * (c) Zemit Team <[email protected]>
6
 *
7
 * For the full copyright and license information, please view the LICENSE.txt
8
 * file that was distributed with this source code.
9
 */
10
11
namespace Zemit\Mvc\Controller;
12
13
use League\Csv\CharsetConverter;
14
use Phalcon\Http\Response;
15
use Phalcon\Mvc\Dispatcher;
16
use Phalcon\Mvc\Model\Resultset;
17
use League\Csv\Writer;
18
use Phalcon\Version;
19
use Zemit\Db\Profiler;
20
use Zemit\Utils\Slug;
21
22
/**
23
 * Class Rest
24
 *
25
 * @author Julien Turbide <[email protected]>
26
 * @copyright Zemit Team <[email protected]>
27
 *
28
 * @since 1.0
29
 * @version 1.0
30
 *
31
 *
32
 * @property Profiler $profiler
33
 * @package Zemit\Mvc\Controller
34
 */
35
class Rest extends \Zemit\Mvc\Controller
36
{
37
    use Model;
0 ignored issues
show
Bug introduced by
The trait Zemit\Mvc\Controller\Model requires the property $loader which is not provided by Zemit\Mvc\Controller\Rest.
Loading history...
38
    
39
    /**
40
     * Rest Bootstrap
41
     */
42
    public function indexAction($id = null)
43
    {
44
        $this->restForwarding($id);
45
    }
46
    
47
    /**
48
     * Rest bootstrap forwarding
49
     *
50
     * @return \Phalcon\Http\ResponseInterface
51
     */
52
    protected function restForwarding($id = null)
53
    {
54
        $id ??= $this->getParam('id');
55
        
56
        if ($this->request->isPost() || $this->request->isPut()) {
57
            $this->dispatcher->forward(['action' => 'save']);
58
        }
59
        else if ($this->request->isDelete()) {
60
            $this->dispatcher->forward(['action' => 'delete']);
61
        }
62
        else if ($this->request->isGet()) {
63
            if (is_null($id)) {
64
                $this->dispatcher->forward(['action' => 'getList']);
65
            }
66
            else {
67
                $this->dispatcher->forward(['action' => 'get']);
68
            }
69
        }
70
        else if ($this->request->isOptions()) {
71
            
72
            // @TODO handle this correctly
73
            return $this->setRestResponse(['result' => 'OK']);
74
        }
75
    }
76
    
77
    /**
78
     * Retrieving a single record
79
     * Alias of method getAction()
80
     * @deprecated Should use getAction() method instead
81
     *
82
     * @param null $id
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?
Loading history...
83
     *
84
     * @return bool|\Phalcon\Http\ResponseInterface
85
     */
86
    public function getSingleAction($id = null) {
87
        return $this->getAction($id);
88
    }
89
    
90
    /**
91
     * Retrieving a single record
92
     *
93
     * @param null $id
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?
Loading history...
94
     *
95
     * @return bool|\Phalcon\Http\ResponseInterface
96
     */
97
    public function getAction($id = null)
98
    {
99
        $modelName = $this->getModelClassName();
100
        $single = $this->getSingle($id, $modelName, null);
101
        
102
        $this->view->single = $single ? $single->expose($this->getExpose()) : false;
0 ignored issues
show
Bug introduced by
The method expose() does not exist on Phalcon\Mvc\Model\Resultset. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

102
        $this->view->single = $single ? $single->/** @scrutinizer ignore-call */ expose($this->getExpose()) : false;

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
Bug introduced by
Are you sure the usage of $this->getExpose() targeting Zemit\Mvc\Controller\Rest::getExpose() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
103
        $this->view->model = $modelName;
104
        $this->view->source = $single ? $single->getSource() : false;
0 ignored issues
show
Bug introduced by
The method getSource() does not exist on Phalcon\Mvc\Model\Resultset. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

104
        $this->view->source = $single ? $single->/** @scrutinizer ignore-call */ getSource() : false;

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
105
        
106
        if (!$single) {
107
            $this->response->setStatusCode(404, 'Not Found');
108
            
109
            return false;
110
        }
111
        
112
        return $this->setRestResponse();
113
    }
114
    
115
    /**
116
     * Retrieving a record list
117
     * Alias of method getListAction()
118
     * @deprecated Should use getListAction() method instead
119
     *
120
     * @return \Phalcon\Http\ResponseInterface
121
     */
122
    public function getAllAction() {
123
        return $this->getListAction();
124
    }
125
    
126
    /**
127
     * Retrieving a record list
128
     *
129
     * @return \Phalcon\Http\ResponseInterface
130
     * @throws \Exception
131
     */
132
    public function getListAction()
133
    {
134
        $model = $this->getModelClassName();
135
        
136
        /** @var Resultset $with */
137
        $find = $this->getFind();
138
        $with = $model::with($this->getWith() ? : [], $find ? : []);
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getWith() targeting Zemit\Mvc\Controller\Rest::getWith() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
139
        
140
        /**
141
         * Expose the list
142
         * @var int $key
143
         * @var \Zemit\Mvc\Model $item
144
         */
145
        $list = [];
146
        foreach ($with as $key => $item) {
147
            $list[$key] = $item->expose($this->getListExpose());
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getListExpose() targeting Zemit\Mvc\Controller\Rest::getListExpose() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
148
        }
149
        
150
        $list = is_array($list) ? array_values(array_filter($list)) : $list;
0 ignored issues
show
introduced by
The condition is_array($list) is always true.
Loading history...
151
        $this->view->list = $list;
152
        $this->view->listCount = count($list);
153
        $this->view->totalCount = $model::find($this->getFindCount($find));
154
        $this->view->totalCount = is_int($this->view->totalCount)? $this->view->totalCount : count($this->view->totalCount); // @todo fix count to work with rollup when joins
155
        $this->view->limit = $find['limit'] ?? false;
156
        $this->view->offset = $find['offset'] ?? false;
157
        $this->view->find = ($this->config->app->debug || $this->config->debug->enable) ? $find : false;
0 ignored issues
show
Bug Best Practice introduced by
The property app does not exist on Zemit\Bootstrap\Config. Since you implemented __get, consider adding a @property annotation.
Loading history...
Bug Best Practice introduced by
The property debug does not exist on Zemit\Bootstrap\Config. Since you implemented __get, consider adding a @property annotation.
Loading history...
158
        
159
        return $this->setRestResponse();
160
    }
161
    
162
    /**
163
     * Exporting a record list into a CSV stream
164
     *
165
     * @return \Phalcon\Http\ResponseInterface
166
     * @throws \League\Csv\CannotInsertRecord
167
     * @throws \Zemit\Exception
168
     */
169
    public function exportAction()
170
    {
171
        $model = $this->getModelClassName();
172
        $params = $this->view->getParamsToView();
173
        $contentType = $this->getContentType();
174
        $fileName = ucfirst(Slug::generate(basename(str_replace('\\', '/', $this->getModelClassName())))) . ' List (' . date('Y-m-d') . ')';
175
        
176
        /** @var Resultset $with */
177
        $find = $this->getFind();
178
        $with = $model::with($this->getWith() ? : [], $find ? : []);
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getWith() targeting Zemit\Mvc\Controller\Rest::getWith() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
179
180
        /**
181
         * Expose the list
182
         * @var int $key
183
         * @var \Zemit\Mvc\Model $item
184
         */
185
        $list = [];
186
        foreach ($with as $key => $item) {
187
            $list[$key] = $item->expose($this->getExportExpose());
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getExportExpose() targeting Zemit\Mvc\Controller\Rest::getExportExpose() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
188
        }
189
190
        $list = is_array($list) ? array_values(array_filter($list)) : $list;
0 ignored issues
show
introduced by
The condition is_array($list) is always true.
Loading history...
191
        $this->flatternArrayForCsv($list);
192
193
        if ($contentType === 'json') {
194
//            $this->response->setJsonContent($list);
195
            $this->response->setContent(json_encode($list, JSON_PRETTY_PRINT, 2048));
196
            $this->response->setContentType('application/json');
197
            $this->response->setHeader('Content-disposition', 'attachment; filename="'.addslashes($fileName).'.json"');
198
            return $this->response->send();
199
        }
200
        
201
        // CSV
202
        if ($contentType === 'csv') {
203
            
204
            // Get CSV custom request parameters
205
            $mode = $params['mode'] ?? null;
206
            $delimiter = $params['delimiter'] ?? null;
207
            $newline = $params['newline'] ?? null;
208
            $escape = $params['escape'] ?? null;
209
            $outputBOM = $params['outputBOM'] ?? null;
210
            $skipIncludeBOM = $params['skipIncludeBOM'] ?? null;
211
            
212
//            $csv = Writer::createFromFileObject(new \SplTempFileObject());
213
            $csv = Writer::createFromStream(fopen('php://memory', 'r+'));
214
            
215
            // CSV - MS Excel on MacOS
216
            if ($mode === 'mac') {
217
                $csv->setOutputBOM(Writer::BOM_UTF16_LE); // utf-16
218
                $csv->setDelimiter("\t"); // tabs separated
219
                $csv->setNewline("\r\n"); // new lines
220
                CharsetConverter::addTo($csv, 'UTF-8', 'UTF-16');
221
            }
222
            
223
            // CSV - MS Excel on Windows
224
            else {
225
                $csv->setOutputBOM(Writer::BOM_UTF8); // utf-8
226
                $csv->setDelimiter(','); // comma separated
227
                $csv->setNewline("\n"); // new line windows
228
                CharsetConverter::addTo($csv, 'UTF-8', 'UTF-8');
229
            }
230
            
231
            // Apply forced params from request
232
            if (isset($outputBOM)) {
233
                $csv->setOutputBOM($outputBOM);
234
            }
235
            if (isset($delimiter)) {
236
                $csv->setDelimiter($delimiter);
237
            }
238
            if (isset($newline)) {
239
                $csv->setNewline($newline);
240
            }
241
            if (isset($escape)) {
242
                $csv->setEscape($escape);
243
            }
244
            if ($skipIncludeBOM) {
245
                $csv->skipInputBOM();
246
            }
247
            else {
248
                $csv->includeInputBOM();
249
            }
250
            
251
            // CSV
252
            $csv->insertOne(array_keys($list[0]));
253
            $csv->insertAll($list);
254
            $csv->output($fileName . '.csv');
255
            die;
0 ignored issues
show
Best Practice introduced by
Using exit here is not recommended.

In general, usage of exit should be done with care and only when running in a scripting context like a CLI script.

Loading history...
256
        }
257
        
258
        // XLSX
259
        if ($contentType === 'xlsx') {
260
            $xlsxArray = [];
261
            foreach ($list as $array) {
262
                if (empty($xlsxArray)) {
263
                    $xlsxArray []= array_keys($array);
264
                }
265
                $xlsxArray []= array_values($array);
266
            }
267
            $xlsx = \SimpleXLSXGen::fromArray($xlsxArray);
268
            $xlsx->downloadAs($fileName . '.xlsx');
269
            die;
0 ignored issues
show
Best Practice introduced by
Using exit here is not recommended.

In general, usage of exit should be done with care and only when running in a scripting context like a CLI script.

Loading history...
270
        }
271
        
272
        // Something went wrong
273
        throw new \Exception('Failed to export `' . $this->getModelClassName() . '` using content-type `' . $contentType . '`', 400);
274
    }
275
276
    /**
277
     * @param array|null $array
278
     *
279
     * @return array|null
280
     */
281
    public function flatternArrayForCsv(?array &$list = null) {
282
283
        foreach ($list as $listKey => $listValue) {
284
            foreach ($listValue as $column => $value) {
285
                if (is_array($value) || is_object($value)) {
286
                    $list[$listKey][$column] = $this->arrayFlatten($value);
0 ignored issues
show
Bug introduced by
It seems like $value can also be of type object; however, parameter $array of Zemit\Mvc\Controller\Rest::arrayFlatten() does only seem to accept array|null, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

286
                    $list[$listKey][$column] = $this->arrayFlatten(/** @scrutinizer ignore-type */ $value);
Loading history...
287
                    if (is_array($list[$listKey][$column])) {
288
                        foreach ($list[$listKey][$column] as $childKey => $childValue) {
289
                            $list[$listKey][$childKey] = $childValue;
290
                            unset ($list[$listKey][$column]);
0 ignored issues
show
Coding Style introduced by
Space before opening parenthesis of function call prohibited
Loading history...
291
                        }
292
                    }
293
                }
294
            }
295
        }
296
297
        $this->formatColumnText($list);
298
        return $this->mergeColumns($list);
299
    }
300
301
    /**
302
     * @param array|null $array
303
     *
304
     * @return array|null
305
     */
306
    function arrayFlatten(?array $array) {
0 ignored issues
show
Comprehensibility Best Practice introduced by
It is recommend to declare an explicit visibility for arrayFlatten.

Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed.

If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with private, and only raise it to protected if a sub-class needs to have access, or public if an external class needs access.

Loading history...
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
307
        $return = array();
308
        foreach ($array as $key => $value) {
309
            if (is_array($value)) {
310
                $return = array_merge($return, $this->arrayFlatten($value));
311
            }
312
            else {
313
                $return[$key] = $value;
314
            }
315
        }
316
        return $return;
317
    }
318
319
    /**
320
     * @param array|null $list
321
     *
322
     * @return array|null
323
     */
324
    public function mergeColumns (?array &$list) {
0 ignored issues
show
Coding Style introduced by
Expected "function abc(...)"; found "function abc (...)"
Loading history...
Coding Style introduced by
Expected 0 spaces before opening parenthesis; 1 found
Loading history...
325
        $columnToMergeList = $this->getExportMergeColum ();
0 ignored issues
show
Coding Style introduced by
Space before opening parenthesis of function call prohibited
Loading history...
Bug introduced by
Are you sure the assignment to $columnToMergeList is correct as $this->getExportMergeColum() targeting Zemit\Mvc\Controller\Rest::getExportMergeColum() seems to always return null.

This check looks for function or method calls that always return null and whose return value is assigned to a variable.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

The method getObject() can return nothing but null, so it makes no sense to assign that value to a variable.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
326
        if (!$columnToMergeList || empty($columnToMergeList)) {
0 ignored issues
show
introduced by
$columnToMergeList is of type null, thus it always evaluated to false.
Loading history...
327
            return  $list;
328
        }
329
330
        $columnList = [];
331
        foreach ($list as $listKey => $listValue) {
332
            foreach ($columnToMergeList as $columnToMerge) {
333
                foreach ($columnToMerge['columns'] as $column) {
334
                    if (isset($listValue[$column])) {
335
                        $columnList[$listKey][] = $listValue[$column];
336
                        unset($list[$listKey][$column]);
337
                    }
338
                }
339
                $list[$listKey][$columnToMerge['name']] = implode (' ', $columnList[$listKey] ?? []);
0 ignored issues
show
Coding Style introduced by
Space before opening parenthesis of function call prohibited
Loading history...
340
            }
341
        }
342
343
        return $list;
344
    }
345
346
    /**
347
     * @param array|null $list
348
     *
349
     * @return array|null
350
     */
351
    public function formatColumnText (?array &$list) {
0 ignored issues
show
Coding Style introduced by
Expected "function abc(...)"; found "function abc (...)"
Loading history...
Coding Style introduced by
Expected 0 spaces before opening parenthesis; 1 found
Loading history...
352
        foreach ($list as $listKey => $listValue) {
353
            $formatArray = $this->getExportFormatFieldText ($listValue);
0 ignored issues
show
Bug introduced by
Are you sure the assignment to $formatArray is correct as $this->getExportFormatFieldText($listValue) targeting Zemit\Mvc\Controller\Res...ExportFormatFieldText() seems to always return null.

This check looks for function or method calls that always return null and whose return value is assigned to a variable.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

The method getObject() can return nothing but null, so it makes no sense to assign that value to a variable.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
Coding Style introduced by
Space before opening parenthesis of function call prohibited
Loading history...
354
            if ($formatArray) {
355
                foreach ($formatArray as $formatKey => $formatValue) {
0 ignored issues
show
Bug introduced by
The expression $formatArray of type void is not traversable.
Loading history...
356
                    if (isset($formatValue['text'])) {
357
                        $list[$listKey][$formatKey] = $formatValue['text'];
358
                        if ($formatValue['rename']) {
359
                            $list[$listKey][$formatValue['rename']] = $formatValue['text'];
360
                            unset($list[$listKey][$formatKey]);
361
                        }
362
                    }
363
                }
364
            }
365
        }
366
367
        return $list;
368
    }
369
    
370
    /**
371
     * Count a record list
372
     * @TODO add total count / deleted count / active count
373
     *
374
     * @return \Phalcon\Http\ResponseInterface
375
     */
376
    public function countAction()
377
    {
378
        $model = $this->getModelClassName();
379
        
380
        /** @var \Zemit\Mvc\Model $entity */
381
        $entity = new $model();
382
        
383
        $this->view->totalCount = $model::count($this->getFindCount($this->getFind()));
384
        $this->view->totalCount = is_int($this->view->totalCount)? $this->view->totalCount : count($this->view->totalCount);
385
        $this->view->model = get_class($entity);
386
        $this->view->source = $entity->getSource();
387
        
388
        return $this->setRestResponse();
389
    }
390
    
391
    /**
392
     * Prepare a new model for the frontend
393
     *
394
     * @return \Phalcon\Http\ResponseInterface
395
     */
396
    public function newAction()
397
    {
398
        $model = $this->getModelClassName();
399
        
400
        /** @var \Zemit\Mvc\Model $entity */
401
        $entity = new $model();
402
        $entity->assign($this->getParams(), $this->getWhiteList(), $this->getColumnMap());
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getColumnMap() targeting Zemit\Mvc\Controller\Rest::getColumnMap() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
Bug introduced by
Are you sure the usage of $this->getWhiteList() targeting Zemit\Mvc\Controller\Rest::getWhiteList() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
403
        
404
        $this->view->model = get_class($entity);
405
        $this->view->source = $entity->getSource();
406
        $this->view->single = $entity->expose($this->getExpose());
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getExpose() targeting Zemit\Mvc\Controller\Rest::getExpose() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
407
        
408
        return $this->setRestResponse();
409
    }
410
    
411
    /**
412
     * Prepare a new model for the frontend
413
     *
414
     * @return \Phalcon\Http\ResponseInterface
415
     */
416
    public function validateAction($id = null)
417
    {
418
        $model = $this->getModelClassName();
419
        
420
        /** @var \Zemit\Mvc\Model $entity */
421
        $entity = $this->getSingle($id);
422
        $new = !$entity;
0 ignored issues
show
introduced by
$entity is of type Zemit\Mvc\Model, thus it always evaluated to true.
Loading history...
423
        
424
        if ($new) {
0 ignored issues
show
introduced by
The condition $new is always false.
Loading history...
425
            $entity = new $model();
426
        }
427
        
428
        $entity->assign($this->getParams(), $this->getWhiteList(), $this->getColumnMap());
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getWhiteList() targeting Zemit\Mvc\Controller\Rest::getWhiteList() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
Bug introduced by
Are you sure the usage of $this->getColumnMap() targeting Zemit\Mvc\Controller\Rest::getColumnMap() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
429
        
430
        /**
431
         * Event to run
432
         * @see https://docs.phalcon.io/4.0/en/db-models-events
433
         */
434
        $events = [
435
            'beforeCreate' => null,
436
            'beforeUpdate' => null,
437
            'beforeSave' => null,
438
            'beforeValidationOnCreate' => null,
439
            'beforeValidationOnUpdate' => null,
440
            'beforeValidation' => null,
441
            'prepareSave' => null,
442
            'validation' => null,
443
            'afterValidationOnCreate' => null,
444
            'afterValidationOnUpdate' => null,
445
            'afterValidation' => null,
446
        ];
447
        
448
        // run events, as it would normally
449
        foreach ($events as $event => $state) {
450
            $this->skipped = false;
0 ignored issues
show
Bug Best Practice introduced by
The property skipped does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.
Loading history...
451
            
452
            // skip depending wether it's a create or update
453
            if (strpos($event, $new ? 'Update' : 'Create') !== false) {
454
                continue;
455
            }
456
            
457
            // fire the event, allowing to fail or skip
458
            $events[$event] = $entity->fireEventCancel($event);
459
            if ($events[$event] === false) {
460
                // event failed
461
                break;
462
            }
463
            
464
            // event was skipped, just for consistencies purpose
465
            if ($this->skipped) {
466
                continue;
467
            }
468
        }
469
        
470
        $this->view->model = get_class($entity);
471
        $this->view->source = $entity->getSource();
472
        $this->view->single = $entity->expose($this->getExpose());
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getExpose() targeting Zemit\Mvc\Controller\Rest::getExpose() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
473
        $this->view->messages = $entity->getMessages();
474
        $this->view->events = $events;
475
        $this->view->validated = empty($this->view->messages);
476
        
477
        return $this->setRestResponse($this->view->validated);
0 ignored issues
show
Bug introduced by
$this->view->validated of type boolean is incompatible with the type array|null expected by parameter $response of Zemit\Mvc\Controller\Rest::setRestResponse(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

477
        return $this->setRestResponse(/** @scrutinizer ignore-type */ $this->view->validated);
Loading history...
478
    }
479
    
480
    /**
481
     * Saving a record
482
     * - Create
483
     * - Update
484
     *
485
     * @param null $id
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?
Loading history...
486
     *
487
     * @return array
488
     */
489
    public function saveAction($id = null)
490
    {
491
        $this->view->setVars($this->save($id));
0 ignored issues
show
Bug introduced by
The method setVars() does not exist on Phalcon\Mvc\ViewInterface. Did you maybe mean setVar()? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

491
        $this->view->/** @scrutinizer ignore-call */ 
492
                     setVars($this->save($id));

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
492
        
493
        return $this->setRestResponse($this->view->saved);
0 ignored issues
show
Bug Best Practice introduced by
The expression return $this->setRestResponse($this->view->saved) returns the type Phalcon\Http\ResponseInterface which is incompatible with the documented return type array.
Loading history...
494
    }
495
    
496
    /**
497
     * Deleting a record
498
     *
499
     * @param null $id
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?
Loading history...
500
     *
501
     * @return bool
502
     */
503
    public function deleteAction($id = null)
504
    {
505
        $single = $this->getSingle($id);
506
        
507
        $this->view->deleted = $single ? $single->delete() : false;
508
        $this->view->single = $single ? $single->expose($this->getExpose()) : false;
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getExpose() targeting Zemit\Mvc\Controller\Rest::getExpose() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
509
        $this->view->messages = $single ? $single->getMessages() : false;
510
        
511
        if (!$single) {
512
            $this->response->setStatusCode(404, 'Not Found');
513
            
514
            return false;
515
        }
516
        
517
        return $this->setRestResponse($this->view->deleted);
0 ignored issues
show
Bug Best Practice introduced by
The expression return $this->setRestRes...e($this->view->deleted) returns the type Phalcon\Http\ResponseInterface which is incompatible with the documented return type boolean.
Loading history...
Bug introduced by
$this->view->deleted of type boolean is incompatible with the type array|null expected by parameter $response of Zemit\Mvc\Controller\Rest::setRestResponse(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

517
        return $this->setRestResponse(/** @scrutinizer ignore-type */ $this->view->deleted);
Loading history...
518
    }
519
    
520
    /**
521
     * Restoring record
522
     *
523
     * @param null $id
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?
Loading history...
524
     *
525
     * @return bool
526
     */
527
    public function restoreAction($id = null)
528
    {
529
        $single = $this->getSingle($id);
530
        
531
        $this->view->restored = $single ? $single->restore() : false;
0 ignored issues
show
Bug introduced by
The method restore() does not exist on Phalcon\Mvc\Model\Resultset. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

531
        $this->view->restored = $single ? $single->/** @scrutinizer ignore-call */ restore() : false;

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
532
        $this->view->single = $single ? $single->expose($this->getExpose()) : false;
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getExpose() targeting Zemit\Mvc\Controller\Rest::getExpose() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
533
        $this->view->messages = $single ? $single->getMessages() : false;
534
        
535
        if (!$single) {
536
            $this->response->setStatusCode(404, 'Not Found');
537
            
538
            return false;
539
        }
540
        
541
        return $this->setRestResponse($this->view->restored);
0 ignored issues
show
Bug introduced by
It seems like $this->view->restored can also be of type false; however, parameter $response of Zemit\Mvc\Controller\Rest::setRestResponse() does only seem to accept array|null, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

541
        return $this->setRestResponse(/** @scrutinizer ignore-type */ $this->view->restored);
Loading history...
Bug Best Practice introduced by
The expression return $this->setRestRes...($this->view->restored) returns the type Phalcon\Http\ResponseInterface which is incompatible with the documented return type boolean.
Loading history...
542
    }
543
    
544
    /**
545
     * Re-ordering a position
546
     *
547
     * @param null $id
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?
Loading history...
548
     * @param null $position
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $position is correct as it would always require null to be passed?
Loading history...
549
     *
550
     * @return bool|\Phalcon\Http\ResponseInterface
551
     */
552
    public function reorderAction($id = null)
553
    {
554
        $single = $this->getSingle($id);
555
        
556
        $position = $this->getParam('position', 'int');
557
        
558
        $this->view->reordered = $single ? $single->reorder($position) : false;
0 ignored issues
show
Bug introduced by
The method reorder() does not exist on Phalcon\Mvc\Model\Resultset. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

558
        $this->view->reordered = $single ? $single->/** @scrutinizer ignore-call */ reorder($position) : false;

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
559
        $this->view->single = $single ? $single->expose($this->getExpose()) : false;
0 ignored issues
show
Bug introduced by
Are you sure the usage of $this->getExpose() targeting Zemit\Mvc\Controller\Rest::getExpose() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
560
        $this->view->messages = $single ? $single->getMessages() : false;
561
        
562
        if (!$single) {
563
            $this->response->setStatusCode(404, 'Not Found');
564
            
565
            return false;
566
        }
567
        
568
        return $this->setRestResponse($this->view->reordered);
0 ignored issues
show
Bug introduced by
It seems like $this->view->reordered can also be of type false; however, parameter $response of Zemit\Mvc\Controller\Rest::setRestResponse() does only seem to accept array|null, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

568
        return $this->setRestResponse(/** @scrutinizer ignore-type */ $this->view->reordered);
Loading history...
569
    }
570
    
571
    /**
572
     * Sending an error as an http response
573
     *
574
     * @param null $error
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $error is correct as it would always require null to be passed?
Loading history...
575
     * @param null $response
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $response is correct as it would always require null to be passed?
Loading history...
576
     *
577
     * @return \Phalcon\Http\ResponseInterface
578
     */
579
    public function setRestErrorResponse($code = 400, $status = 'Bad Request', $response = null)
580
    {
581
        return $this->setRestResponse($response, $code, $status);
582
    }
583
    
584
    /**
585
     * Sending rest response as an http response
586
     *
587
     * @param array|null $response
588
     * @param null $status
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $status is correct as it would always require null to be passed?
Loading history...
589
     * @param null $code
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $code is correct as it would always require null to be passed?
Loading history...
590
     * @param int $jsonOptions
591
     * @param int $depth
592
     *
593
     * @return \Phalcon\Http\ResponseInterface
594
     */
595
    public function setRestResponse($response = null, $code = null, $status = null, $jsonOptions = 0, $depth = 512)
596
    {
597
        $debug = $this->config->app->debug ?? false;
0 ignored issues
show
Bug Best Practice introduced by
The property app does not exist on Zemit\Bootstrap\Config. Since you implemented __get, consider adding a @property annotation.
Loading history...
598
        
599
        // keep forced status code or set our own
600
        $responseStatusCode = $this->response->getStatusCode();
601
        $reasonPhrase = $this->response->getReasonPhrase();
602
        $status ??= $reasonPhrase ? : 'OK';
603
        $code ??= (int)$responseStatusCode ? : 200;
604
        $view = $this->view->getParamsToView();
605
        $hash = hash('sha512', json_encode($view));
606
        
607
        /**
608
         * Debug section
609
         * - Versions
610
         * - Request
611
         * - Identity
612
         * - Profiler
613
         * - Dispatcher
614
         * - Router
615
         */
616
        $request = $debug ? $this->request->toArray() : null;
0 ignored issues
show
Bug introduced by
The method toArray() does not exist on Phalcon\Http\RequestInterface. It seems like you code against a sub-type of Phalcon\Http\RequestInterface such as Zemit\Http\Request. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

616
        $request = $debug ? $this->request->/** @scrutinizer ignore-call */ toArray() : null;
Loading history...
introduced by
The method toArray() does not exist on Phalcon\Http\Request. Are you sure you never get this type here, but always one of the subclasses? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

616
        $request = $debug ? $this->request->/** @scrutinizer ignore-call */ toArray() : null;
Loading history...
617
        $identity = $debug ? $this->identity->getIdentity() : null;
618
        $profiler = $debug && $this->profiler ? $this->profiler->toArray() : null;
619
        $dispatcher = $debug ? $this->dispatcher->toArray() : null;
620
        $router = $debug ? $this->router->toArray() : null;
621
        
622
        $api = $debug ? [
623
            'php' => phpversion(),
624
            'phalcon' => Version::get(),
625
            'zemit' => $this->config->core->version,
0 ignored issues
show
Bug Best Practice introduced by
The property core does not exist on Zemit\Bootstrap\Config. Since you implemented __get, consider adding a @property annotation.
Loading history...
626
            'core' => $this->config->core->name,
627
            'app' => $this->config->app->version,
628
            'name' => $this->config->app->name,
629
        ] : [];
630
        $api['version'] = '0.1';
631
        
632
        $this->response->setStatusCode($code, $code . ' ' . $status);
633
        
634
        // @todo handle this correctly
635
        // @todo private vs public cache type
636
        $cache = $this->getCache();
637
        if (!empty($cache['lifetime'])) {
638
            if ($this->response->getStatusCode() === 200) {
639
                $this->response->setCache($cache['lifetime']);
640
                $this->response->setEtag($hash);
641
            }
642
        } else {
643
            $this->response->setCache(0);
644
            $this->response->setHeader('Cache-Control', 'no-cache, max-age=0');
645
        }
646
        
647
        return $this->response->setJsonContent(array_merge([
648
            'api' => $api,
649
            'timestamp' => date('c'),
650
            'hash' => $hash,
651
            'status' => $status,
652
            'code' => $code,
653
            'response' => $response,
654
            'view' => $view,
655
        ], $debug ? [
656
            'identity' => $identity,
657
            'profiler' => $profiler,
658
            'request' => $request,
659
            'dispatcher' => $dispatcher,
660
            'router' => $router,
661
        ] : []), $jsonOptions, $depth);
0 ignored issues
show
Unused Code introduced by
The call to Phalcon\Http\ResponseInterface::setJsonContent() has too many arguments starting with $jsonOptions. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

661
        return $this->response->/** @scrutinizer ignore-call */ setJsonContent(array_merge([

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
662
    }
663
    
664
    /**
665
     * Handle rest response automagically
666
     *
667
     * @param Dispatcher $dispatcher
668
     */
669
    public function afterExecuteRoute(Dispatcher $dispatcher)
670
    {
671
        $response = $dispatcher->getReturnedValue();
672
        
673
        // Avoid breaking default phalcon behaviour
674
        if ($response instanceof Response) {
675
            return;
676
        }
677
        
678
        // Merge response into view variables
679
        if (is_array($response)) {
680
            $this->view->setVars($response, true);
681
        }
682
        
683
        // Return our Rest normalized response
684
        $dispatcher->setReturnedValue($this->setRestResponse(is_array($response) ? null : $response));
685
    }
686
}
687