Zemit\Mvc\Model\Behavior\Position::notify()

Complexity

Conditions	17
Paths	21

Size

Total Lines	64
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function notify(string $type, ModelInterface $model)
    {
        if (!$this->isEnabled()) {
            return;
        }
        
        assert($model instanceof Model);
        
        $positionField = $this->getField();
        $rawSql = $this->getRawSql();
        
        switch ($type) {
            case 'beforeValidation':
                // if position field is empty, force current max(position)+1
                $lastPosition = $model::findFirst(['order' => $positionField . ' DESC']);
                if ($lastPosition && assert($lastPosition instanceof $model)) {
                    $position = (int)$lastPosition->getAttribute($positionField);

The method getAttribute() does not exist on Phalcon\Mvc\ModelInterface. It seems like you code against a sub-type of Phalcon\Mvc\ModelInterface such as Phalcon\Mvc\Model or Zemit\Models\Setting or Zemit\Models\Category or Zemit\Models\Audit or Zemit\Models\UserGroup or Zemit\Models\User or Zemit\Models\Field or Zemit\Models\Page or Zemit\Models\Log or Zemit\Models\File or Zemit\Models\Role or Zemit\Models\GroupRole or Zemit\Models\Template or Zemit\Models\AuditDetail or Zemit\Models\UserType or Zemit\Models\Post or Zemit\Models\PostCategory or Zemit\Models\Session or Zemit\Models\TranslateField or Zemit\Models\GroupType or Zemit\Models\Translate or Zemit\Models\Email or Zemit\Models\Data or Zemit\Models\Group or Zemit\Models\Lang or Zemit\Models\EmailFile or Zemit\Models\TranslateTable or Zemit\Models\SiteLang or Zemit\Models\UserRole or Zemit\Models\Flag or Zemit\Models\Menu or Zemit\Models\Site or Zemit\Models\Type or Zemit\Models\Channel or Zemit\Models\Meta.

                    $model->setAttribute($positionField, $position + 1);
                }
                break;
            
            case 'afterSave':
                if (!$this->getProgress() && $model->hasSnapshotData() && $model->hasUpdated($positionField)) {
                    $this->setProgress(true);
                    
                    $snapshot = $model->getOldSnapshotData() ?: $model->getSnapshotData();
                    $modelPosition = $model->getAttribute($positionField);
                    $modelPrimaryKeys = $model->getPrimaryKeysValues();
                    
                    if (!($modelPosition instanceof RawValue)) {
                        $uField = Text::uncamelize($positionField); // @todo use columnMap
                        $updatePositionQuery = null;
                        
                        if ($snapshot[$positionField] > $modelPosition) {
                            $updatePositionQuery = $rawSql
                                ? 'UPDATE `' . $model->getSource() . '` SET `' . $uField . '` = `' . $uField . '`+1 WHERE `' . $uField . '` >= :position and `' . $uField . '` < :oldPosition and `' . $idField . '` <> :id'

The variable $idField seems to be never defined.

                                : 'UPDATE [' . get_class($model) . '] SET [' . $positionField . '] = [' . $positionField . ']+1 WHERE [' . $positionField . '] >= ?1 and [' . $positionField . '] < ?2 and [' . $idField . '] <> ?0';
                        }
                        elseif ($snapshot[$positionField] < $modelPosition) {
                            $updatePositionQuery = $rawSql
                                ? 'UPDATE `' . $model->getSource() . '` SET `' . $uField . '` = `' . $uField . '`-1 WHERE `' . $uField . '` > :oldPosition and `' . $uField . '` <= :position and `' . $idField . '` <> :id'
                                : 'UPDATE [' . get_class($model) . '] SET [' . $positionField . '] = [' . $positionField . ']-1 WHERE [' . $positionField . '] > ?2 and [' . $positionField . '] <= ?1 and [' . $idField . '] <> ?0';
                        }
                        
                        if (!empty($updatePositionQuery)) {
                            if ($rawSql) {
                                $model->getWriteConnection()->query($updatePositionQuery, [
                                    'primaryKeys' => $modelPrimaryKeys,
                                    'position' => $modelPosition,
                                    'oldPosition' => $snapshot[$positionField],
                                ]);
                            }
                            else {
                                $model->getModelsManager()->executeQuery($updatePositionQuery, [$modelId, $modelPosition, $snapshot[$positionField]]);

The variable $modelId does not exist. Did you maybe mean $model?

                            }
                        }
                    }
                    
                    $this->setProgress(false);
                }
                break;
        }
        
        return true;
    }