Zemit\Modules\Api\Controllers\AuthController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	getAction()	0	33	8
A	indexAction()	0	3	1
A	destroyAction()	0	2	1

<?php
/**
 * This file is part of the Zemit Framework.
 *
 * (c) Zemit Team <contact@zemit.com>
 *
 * For the full copyright and license information, please view the LICENSE.txt
 * file that was distributed with this source code.
 */

namespace Zemit\Modules\Api\Controllers;

use Zemit\Modules\Api\Controller;
use Zemit\Mvc\Controller\Identity;

/**
 * Class AuthController
 *
 * @author Julien Turbide <jturbide@nuagerie.com>
 * @copyright Zemit Team <contact@zemit.com>
 *
 * @since 1.0
 * @version 1.0
 *
 * @package Zemit\Modules\Api\Controllers
 */
class AuthController extends Controller
{
    use Identity;

The trait Zemit\Mvc\Controller\Identity requires some properties which are not provided by Zemit\Modules\Api\Controllers\AuthController: $loggedIn, $saved, $stored, $reset, $loggedInAs

    public function indexAction($id = null)
    {
        return $this->getAction();
    }

    /**
     *
     */
    public function destroyAction() {
        return $this->session->destroy();

Are you sure the usage of $this->session->destroy() targeting Phalcon\Session\ManagerInterface::destroy() seems to always return null.

    }

    /**
     * Create a refresh a session
     *
     * @param bool $refresh
     *
     * @return bool
     * @throws \Phalcon\Security\Exception
     */
    public function getAction($request = null)
    {
        $this->view->setVars($this->identity->getJwt($request === true));

The method setVars() does not exist on Phalcon\Mvc\ViewInterface. Did you maybe mean setVar()?

        $this->view->setVars($this->identity->getIdentity());

        $indexLabelExpose = [false, 'email', 'label', 'labelFr', 'labelEn', 'addressId'];
        $expose = [
            'User' => [false, 'email', 'firstName', 'lastName', 'category', 'addressId', 'id', 'companyId'],
            'Role' => $indexLabelExpose,
            'Group' => $indexLabelExpose,
            'Type' => $indexLabelExpose,
        ];

        $permissions = $this->config->permissions->roles->toArray() ?? [];

The property permissions does not exist on Zemit\Bootstrap\Config. Since you implemented __get, consider adding a @property annotation.

        $permissionList = ['everyone' => $permissions['everyone']['frontend'] ?? null];
        $vars = [];
        foreach (['user', 'userAs', 'roleList', 'groupList', 'typeList'] as $var) {
            if (is_array($this->view->$var)) {
                foreach ($this->view->$var as $key => $role) {
                    if ($role) {
                        $vars[$var][$key] = $role->expose($expose);
                        $permissionList[$key] = $permissions[$key]['frontend'] ?? null;
                    }
                }
            } else if ($this->view->$var) {
                $vars[$var] = $this->view->$var->expose($expose);
            }
        }
        $this->view->setVars($vars);

        $this->view->permissionList = $permissionList;

        return $this->view->saved && $this->view->stored && $this->view->validated;
    }
}