Email::send() - Code Metrics - Inspection of "refactoring the json model helper" - zemit-cms/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 636052...60f6c1 )

by Julien

created 2024-02-29 05:41 UTC

Email::send() F

↳ Parent: Project

Complexity

Conditions	17
Paths	577

Size

Total Lines	83
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	306

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	17
eloc	44
c	1
b	1
f	0
nc	577
nop	1
dl	0
loc	83
ccs	0
cts	44
cp	0
crap	306
rs	1.6375

How to fix Long Method Complexity

<?php
/**
 * This file is part of the Zemit Framework.
 *
 * (c) Zemit Team <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE.txt
 * file that was distributed with this source code.
 */

namespace Zemit\Models;

use Zemit\Db\Column;
use Zemit\Models\Abstracts\AbstractEmail;
use Phalcon\Incubator\Mailer\Manager;
use Phalcon\Messages\Message;
use Phalcon\Filter\Validation\Validator\PresenceOf;
use Phalcon\Filter\Validation\Validator\StringLength\Max;
use Phalcon\Filter\Validation\Validator\Uniqueness;
use Phalcon\Filter\Validation\Validator\Numericality;
use Zemit\Models\Interfaces\EmailInterface;

/**
 * @property Template $TemplateEntity
 * @method Template getTemplateEntity(?array $params = null)
 * 
 * @property EmailFile $FileNode
 * @method EmailFile getFileNode(?array $params = null)
 * 
 * @property File $FileList
 * @method File getFileList(?array $params = null)
 */
class Email extends AbstractEmail implements EmailInterface
{
    protected $deleted = self::NO;
    protected $sent = self::NO;
    
    public function initialize(): void
    {
        parent::initialize();
        // @todo relationships
    }
    
    public function validation(): bool
    {
        $validator = $this->genericValidation();
        
        // @todo validations
        
        return $this->validate($validator);
    }
}


1			<?php
2			/**
3			* This file is part of the Zemit Framework.
4			*
5			* (c) Zemit Team <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE.txt
8			* file that was distributed with this source code.
9			*/
10
11			namespace Zemit\Models;
12
13			use Zemit\Db\Column;
14			use Zemit\Models\Abstracts\AbstractEmail;
15			use Phalcon\Incubator\Mailer\Manager;
16			use Phalcon\Messages\Message;
17			use Phalcon\Filter\Validation\Validator\PresenceOf;
18			use Phalcon\Filter\Validation\Validator\StringLength\Max;
19			use Phalcon\Filter\Validation\Validator\Uniqueness;
20			use Phalcon\Filter\Validation\Validator\Numericality;
21			use Zemit\Models\Interfaces\EmailInterface;
22
23			/**
24			* @property Template $TemplateEntity
25			* @method Template getTemplateEntity(?array $params = null)
26			*
27			* @property EmailFile $FileNode
28			* @method EmailFile getFileNode(?array $params = null)
29			*
30			* @property File $FileList
31			* @method File getFileList(?array $params = null)
32			*/
33			class Email extends AbstractEmail implements EmailInterface
34			{
35			protected $deleted = self::NO;
36			protected $sent = self::NO;
37
38			public function initialize(): void
39			{
40			parent::initialize();
41			// @todo relationships
42			}
43
44			public function validation(): bool
45			{
46			$validator = $this->genericValidation();
47
48			// @todo validations
49
50			return $this->validate($validator);
51			}
52			}
53

zemit-cms / core

Push — master ( 636052...60f6c1 )

Email::send() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like