Issues in application.php - New Issues - Inspection of "Merge pull request #6 in ~SZYMON.DUDZIAK_EQUIQO.CO..." - zelaznymarek/app-builder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 613187...0057b2 )

by Marek

created 2017-07-04 12:14 UTC

application.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

#!/usr/bin/env php
<?php

require __DIR__ . '/vendor/autoload.php';

use PVG\Command\DeployTestBranchCommand;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\Console\Application;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
use Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher;

$application = new Application('Test branch builder', '1.0.0');
$container   = new ContainerBuilder();
$fileLocator = new FileLocator(__DIR__);

try {
    $container->set('app.file_locator', $fileLocator);
    $container->set('app.event_dispatcher', new ContainerAwareEventDispatcher($container));
    $loader = new YamlFileLoader($container, $fileLocator);
    $loader->load('config/services.yml');

    $application->setCatchExceptions(true);
    $application->add($container->get('deploy_test_branch_command'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    $application->setDefaultCommand(DeployTestBranchCommand::NAME);

    $application->run();
} catch (Exception $exception) {
    (new \SimpleLogger\Stdout())->critical($exception->getMessage());
    exit(1);
}


1			#!/usr/bin/env php
2			<?php
3
4			require __DIR__ . '/vendor/autoload.php';
5
6			use PVG\Command\DeployTestBranchCommand;
7			use Symfony\Component\Config\FileLocator;
8			use Symfony\Component\Console\Application;
9			use Symfony\Component\DependencyInjection\ContainerBuilder;
10			use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
11			use Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher;
12
13			$application = new Application('Test branch builder', '1.0.0');
14			$container = new ContainerBuilder();
15			$fileLocator = new FileLocator(__DIR__);
16
17			try {
18			$container->set('app.file_locator', $fileLocator);
19			$container->set('app.event_dispatcher', new ContainerAwareEventDispatcher($container));
20			$loader = new YamlFileLoader($container, $fileLocator);
21			$loader->load('config/services.yml');
22
23			$application->setCatchExceptions(true);
24			$application->add($container->get('deploy_test_branch_command'));
			0 ignored issues – show Documentation introduced 2017-07-04 12:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$container->get('deploy_test_branch_command')` is of type `object\|null`, but the function expects a `object<Symfony\Component\Console\Command\Command>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25			$application->setDefaultCommand(DeployTestBranchCommand::NAME);
26
27			$application->run();
28			} catch (Exception $exception) {
29			(new \SimpleLogger\Stdout())->critical($exception->getMessage());
30			exit(1);
31			}
32

zelaznymarek / app-builder

Push — master ( 613187...0057b2 )

application.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like