JiraAuthentication::__construct() - Code Metrics - Inspection of "Merge pull request #6 in ~SZYMON.DUDZIAK_EQUIQO.CO..." - zelaznymarek/app-builder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 613187...0057b2 )

by Marek

created 2017-07-04 12:14 UTC

JiraAuthentication::__construct() A

↳ Parent: JiraAuthentication

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	3

<?php

declare(strict_types=1);

namespace Pvg\Application\Configuration\ValueObject;

use InvalidArgumentException;

class JiraAuthentication
{
    /** @var string */
    private $host;

    /** @var string */
    private $username;

    /** @var string */
    private $password;

    /**
     * @throws InvalidArgumentException
     */
    public function __construct(string $host, string $username, string $password)
    {
        $this
            ->setHost($host)
            ->setUsername($username)
            ->setPassword($password);
    }

    public function host() : string
    {
        return $this->host;
    }

    public function username() : string
    {
        return $this->username;
    }

    public function password() : string
    {
        return $this->password;
    }

    public static function createFromArray(array $yamlConfigArray) : void

    {
    }

    /**
     * @throws InvalidArgumentException
     */
    private function setHost(string $host) : self
    {
        if (empty($host)) {
            throw new InvalidArgumentException('Empty JIRA host configuration');
        }
        $this->host = $host;

        return $this;
    }

    /**
     * @throws InvalidArgumentException
     */
    private function setUsername(string $username) : self
    {
        if (empty($host)) {

            throw new InvalidArgumentException('Empty JIRA username configuration');
        }
        $this->username = $username;

        return $this;
    }

    /**
     * @throws InvalidArgumentException
     */
    private function setPassword(string $password) : self
    {
        if (empty($host)) {

            throw new InvalidArgumentException('Empty JIRA password configuration');
        }
        $this->password = $password;

        return $this;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Pvg\Application\Configuration\ValueObject;
6
7			use InvalidArgumentException;
8
9			class JiraAuthentication
10			{
11			/** @var string */
12			private $host;
13
14			/** @var string */
15			private $username;
16
17			/** @var string */
18			private $password;
19
20			/**
21			* @throws InvalidArgumentException
22			*/
23			public function __construct(string $host, string $username, string $password)
24			{
25			$this
26			->setHost($host)
27			->setUsername($username)
28			->setPassword($password);
29			}
30
31			public function host() : string
32			{
33			return $this->host;
34			}
35
36			public function username() : string
37			{
38			return $this->username;
39			}
40
41			public function password() : string
42			{
43			return $this->password;
44			}
45
46			public static function createFromArray(array $yamlConfigArray) : void
			0 ignored issues – show Unused Code introduced 2017-06-14 13:39 UTC by Report Bug Copy Issue Report The parameter `$yamlConfigArray` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
47			{
48			}
49
50			/**
51			* @throws InvalidArgumentException
52			*/
53			private function setHost(string $host) : self
54			{
55			if (empty($host)) {
56			throw new InvalidArgumentException('Empty JIRA host configuration');
57			}
58			$this->host = $host;
59
60			return $this;
61			}
62
63			/**
64			* @throws InvalidArgumentException
65			*/
66			private function setUsername(string $username) : self
67			{
68			if (empty($host)) {
			0 ignored issues – show Bug introduced 2017-07-04 12:20 UTC by Report Bug Copy Issue Report The variable `$host` seems to never exist, and therefore `empty` should always return `true`. Did you maybe rename this variable? This check looks for calls to `isset(...)` or `empty()` on variables that are yet undefined. These calls will always produce the same result and can be removed. This is most likely caused by the renaming of a variable or the removal of a function/method parameter. Loading history...
69			throw new InvalidArgumentException('Empty JIRA username configuration');
70			}
71			$this->username = $username;
72
73			return $this;
74			}
75
76			/**
77			* @throws InvalidArgumentException
78			*/
79			private function setPassword(string $password) : self
80			{
81			if (empty($host)) {
			0 ignored issues – show Bug introduced 2017-07-04 12:20 UTC by Report Bug Copy Issue Report The variable `$host` seems to never exist, and therefore `empty` should always return `true`. Did you maybe rename this variable? This check looks for calls to `isset(...)` or `empty()` on variables that are yet undefined. These calls will always produce the same result and can be removed. This is most likely caused by the renaming of a variable or the removal of a function/method parameter. Loading history...
82			throw new InvalidArgumentException('Empty JIRA password configuration');
83			}
84			$this->password = $password;
85
86			return $this;
87			}
88			}
89

zelaznymarek / app-builder

Push — master ( 613187...0057b2 )

JiraAuthentication::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like