zebrainsteam / laravel-repos

src/LaravelReposServiceProvider.php

<?php


namespace Zebrainsteam\LaravelRepos;

use Illuminate\Support\Facades\App;
use Illuminate\Support\ServiceProvider;
use Repositories\Core\Contracts\ResolverInterface;
use Repositories\Core\RepositoryFactory;
use Repositories\Core\Resolvers\ChainResolver;
use Repositories\Core\Resolvers\ContainerAwareResolver;
use Zebrainsteam\LaravelRepos\Console\RepositoryInterfaceMakeCommand;
use Zebrainsteam\LaravelRepos\Console\RepositoryMakeCommand;

class LaravelReposServiceProvider extends ServiceProvider
{
    public function boot()
    {
        if ($this->app->runningInConsole()) {

The method runningInConsole() does not exist on Tests\Laravel\App.

            $this->commands([

The method commands() does not exist on Zebrainsteam\LaravelRepos\LaravelReposServiceProvider.

                RepositoryInterfaceMakeCommand::class,
                RepositoryMakeCommand::class,
            ]);
        }

        $this->publishes([

The method publishes() does not exist on Zebrainsteam\LaravelRepos\LaravelReposServiceProvider.

            __DIR__.'/config/repositories.php' => config_path('repositories.php'),
        ]);
    }

    public function register()
    {
        $this->app->singleton(ContainerAwareResolver::class, function ($app) {

The method singleton() does not exist on Tests\Laravel\App.

            return new ContainerAwareResolver($app);
        });

        if (empty(config('repositories.resolvers'))
            || empty(config('repositories.bindings'))
        ) {
            throw new \Exception('Invalid repository config');
        }

        $this->app->singleton(RepositoryFactory::class, function ($app) {

The parameter $app is not used and could be removed.

            foreach (config('repositories.resolvers') as $resolverClass) {
                $resolver = App::get($resolverClass);

                if ($resolver instanceof ResolverInterface) {
                    $resolvers[] = $resolver;
                } else {
                    throw new \Exception('Invalid resolver class ' . $resolverClass);
                }
            }

            $resolver = new ChainResolver($resolvers);

The variable $resolvers seems to be defined by a foreach iteration on line 44. Are you sure the iterator is never empty, otherwise this variable is not defined?

            return new RepositoryFactory($resolver, config('repositories.bindings'));
        });
    }
}