zbateson / mail-mime-parser

src/Header/GenericHeader.php

<?php
/**
 * This file is part of the ZBateson\MailMimeParser project.
 *
 * @license http://opensource.org/licenses/bsd-license.php BSD
 */

namespace ZBateson\MailMimeParser\Header;

use Psr\Log\LoggerInterface;
use ZBateson\MailMimeParser\Header\Consumer\GenericConsumerMimeLiteralPartService;
use ZBateson\MailMimeParser\MailMimeParser;

/**
 * Reads a generic header.
 *
 * Header's may contain mime-encoded parts, quoted parts, and comments.  The
 * string value is the combined value of all its parts.
 *
 * @author Zaahid Bateson
 */
class GenericHeader extends AbstractHeader
{
    public function __construct(
        string $name,
        string $value,
        ?LoggerInterface $logger = null,
        ?GenericConsumerMimeLiteralPartService $consumerService = null
    ) {
        $di = MailMimeParser::getGlobalContainer();
        parent::__construct(
            $logger ?? $di->get(LoggerInterface::class),
            $consumerService ?? $di->get(DateConsumerService::class),

The type ZBateson\MailMimeParser\Header\DateConsumerService was not found. Maybe you did not declare it correctly or list all dependencies?

            $name,
            $value
        );
        parent::__construct($logger, $consumerService, $name, $value);

It seems like $logger can also be of type null; however, parameter $logger of ZBateson\MailMimeParser\Header\AbstractHeader::__construct() does only seem to accept Psr\Log\LoggerInterface, maybe add an additional type check?

It seems like $consumerService can also be of type null; however, parameter $consumerService of ZBateson\MailMimeParser\Header\AbstractHeader::__construct() does only seem to accept ZBateson\MailMimeParser\Header\Consumer\IConsumerService, maybe add an additional type check?

    }

    public function getValue() : ?string
    {
        if (!empty($this->parts)) {
            return \implode('', \array_map(function($p) { return $p->getValue(); }, $this->parts));

Expected 1 space after FUNCTION keyword; 0 found

Opening brace must be the last content on the line

It is generally recommended to place each PHP statement on a line by itself.

        }
        return null;
    }
}