MessageFactory::newInstance() - Code Metrics - Inspection of "Fix for PartFilter and some tests" - zbateson/mail-mime-parser - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — 1.0.0 (84f469)

by Zaahid

created 2017-11-17 23:56 UTC

MessageFactory::newInstance() A

↳ Parent: MessageFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	2

<?php
/**
 * This file is part of the ZBateson\MailMimeParser project.
 *
 * @license http://opensource.org/licenses/bsd-license.php BSD
 */
namespace ZBateson\MailMimeParser\Message;

use ZBateson\MailMimeParser\Message;
use ZBateson\MailMimeParser\Message\Part\MimePartFactory;
use ZBateson\MailMimeParser\Message\Part\PartBuilder;

/**
 * Responsible for creating Message instances.
 *
 * @author Zaahid Bateson
 */
class MessageFactory extends MimePartFactory
{
    /**
     * Constructs a new Message object and returns it
     * 
     * @param string $messageObjectId
     * @param PartBuilder $partBuilder
     * @return \ZBateson\MailMimeParser\Message\Part\MimePart
     */
    public function newInstance($messageObjectId, PartBuilder $partBuilder)
    {
        return new Message(
            $this->headerFactory,
            $this->partFilterFactory,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $messageObjectId,
            $partBuilder,
            $this->partStreamFilterManagerFactory->newInstance()
        );
    }
}


1			<?php
2			/**
3			* This file is part of the ZBateson\MailMimeParser project.
4			*
5			* @license http://opensource.org/licenses/bsd-license.php BSD
6			*/
7			namespace ZBateson\MailMimeParser\Message;
8
9			use ZBateson\MailMimeParser\Message;
10			use ZBateson\MailMimeParser\Message\Part\MimePartFactory;
11			use ZBateson\MailMimeParser\Message\Part\PartBuilder;
12
13			/**
14			* Responsible for creating Message instances.
15			*
16			* @author Zaahid Bateson
17			*/
18			class MessageFactory extends MimePartFactory
19			{
20			/**
21			* Constructs a new Message object and returns it
22			*
23			* @param string $messageObjectId
24			* @param PartBuilder $partBuilder
25			* @return \ZBateson\MailMimeParser\Message\Part\MimePart
26			*/
27			public function newInstance($messageObjectId, PartBuilder $partBuilder)
28			{
29			return new Message(
30			$this->headerFactory,
31			$this->partFilterFactory,
			0 ignored issues – show Documentation introduced 2017-11-18 00:01 UTC by Report Bug Copy Issue Report `$this->partFilterFactory` is of type `object<ZBateson\MailMime...r\Header\HeaderFactory>`, but the function expects a `object<ZBateson\MailMime...sage\PartFilterFactory>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			$messageObjectId,
33			$partBuilder,
34			$this->partStreamFilterManagerFactory->newInstance()
35			);
36			}
37			}
38

zbateson / mail-mime-parser

Branch — 1.0.0 (84f469)

MessageFactory::newInstance() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like