ZBateson\MailMimeParser\Message\Part\MimePartFactory

Complexity

Total Complexity

4

Size/Duplication

Total Lines	67
Duplicated Lines	17.91 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getInstance()	12	12	2
A	newInstance()	0	10	1

<?php
/**
 * This file is part of the ZBateson\MailMimeParser project.
 *
 * @license http://opensource.org/licenses/bsd-license.php BSD
 */
namespace ZBateson\MailMimeParser\Message\Part;

use ZBateson\MailMimeParser\Header\HeaderFactory;
use ZBateson\MailMimeParser\Message\PartFilterFactory;

/**
 * Responsible for creating MimePart instances.
 *
 * @author Zaahid Bateson
 */
class MimePartFactory extends MessagePartFactory
{
    /**
     * @var \ZBateson\MailMimeParser\Header\HeaderFactory the HeaderFactory
     *      instance
     */
    protected $headerFactory;
    
    /**
     * @var \ZBateson\MailMimeParser\Header\HeaderFactory the PartFilterFactory
     *      instance
     */
    protected $partFilterFactory;

    /**
     * Creates a MimePartFactory instance with its dependencies.
     * 
     * @param PartStreamFilterManagerFactory $psf
     * @param HeaderFactory $hf
     * @param PartFilterFactory $pf
     */
    public function __construct(PartStreamFilterManagerFactory $psf, HeaderFactory $hf, PartFilterFactory $pf)
    {
        parent::__construct($psf);
        $this->headerFactory = $hf;
        $this->partFilterFactory = $pf;

It seems like $pf of type object<ZBateson\MailMimeParser\Message\PartFilterFactory> is incompatible with the declared type object<ZBateson\MailMimeParser\Header\HeaderFactory> of property $partFilterFactory.

    }
    
    /**
     * Returns the singleton instance for the class.
     * 
     * @param PartStreamFilterManagerFactory $psf
     * @param HeaderFactory $hf
     * @param PartFilterFactory $pf
     * @return MimePartFactory
     */
    public static function getInstance(

This method seems to be duplicated in your project.

        PartStreamFilterManagerFactory $psf,
        HeaderFactory $hf = null,
        PartFilterFactory $pf = null
    ) {
        static $instances = [];
        $class = get_called_class();
        if (!isset($instances[$class])) {
            $instances[$class] = new static($psf, $hf, $pf);

It seems like $hf defined by parameter $hf on line 55 can be null; however, ZBateson\MailMimeParser\Message\Part\MimePartFactory::__construct() does not accept null, maybe add an additional type check?

It seems like $pf defined by parameter $pf on line 56 can be null; however, ZBateson\MailMimeParser\Message\Part\MimePartFactory::__construct() does not accept null, maybe add an additional type check?

        }
        return $instances[$class];
    }

    /**
     * Constructs a new MimePart object and returns it
     * 
     * @param string $messageObjectId
     * @param PartBuilder $partBuilder
     * @return \ZBateson\MailMimeParser\Message\Part\MimePart
     */
    public function newInstance($messageObjectId, PartBuilder $partBuilder)
    {
        return new MimePart(
            $this->headerFactory,
            $this->partFilterFactory,

$this->partFilterFactory is of type object<ZBateson\MailMimeParser\Header\HeaderFactory>, but the function expects a object<ZBateson\MailMimeParser\Message\PartFilterFactory>.

            $messageObjectId,
            $partBuilder,
            $this->partStreamFilterManagerFactory->newInstance()
        );
    }
}