MimePartFactory::newInstance() - Code Metrics - Inspection of "Fix duplicate code and @covers annotations" - zbateson/mail-mime-parser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 1.0.0 ( fcaf32...d3c3e6 )

by Zaahid

created 2017-12-04 06:00 UTC

MimePartFactory::newInstance() A

↳ Parent: MimePartFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	2
crap	1

<?php
/**
 * This file is part of the ZBateson\MailMimeParser project.
 *
 * @license http://opensource.org/licenses/bsd-license.php BSD
 */
namespace ZBateson\MailMimeParser\Message\Part;

use ZBateson\MailMimeParser\Header\HeaderFactory;
use ZBateson\MailMimeParser\Message\PartFilterFactory;

/**
 * Responsible for creating MimePart instances.
 *
 * @author Zaahid Bateson
 */
class MimePartFactory extends MessagePartFactory
{
    /**
     * @var \ZBateson\MailMimeParser\Header\HeaderFactory the HeaderFactory
     *      instance
     */
    protected $headerFactory;
    
    /**
     * @var \ZBateson\MailMimeParser\Header\HeaderFactory the PartFilterFactory
     *      instance
     */
    protected $partFilterFactory;

    /**
     * Creates a MimePartFactory instance with its dependencies.
     * 
     * @param PartStreamFilterManagerFactory $psf
     * @param HeaderFactory $hf
     * @param PartFilterFactory $pf
     */
    public function __construct(PartStreamFilterManagerFactory $psf, HeaderFactory $hf, PartFilterFactory $pf)
    {
        parent::__construct($psf);
        $this->headerFactory = $hf;
        $this->partFilterFactory = $pf;

    }

    /**
     * Constructs a new MimePart object and returns it
     * 
     * @param string $messageObjectId
     * @param PartBuilder $partBuilder
     * @return \ZBateson\MailMimeParser\Message\Part\MimePart
     */
    public function newInstance($messageObjectId, PartBuilder $partBuilder)
    {
        return new MimePart(
            $this->headerFactory,
            $this->partFilterFactory,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $messageObjectId,
            $partBuilder,
            $this->partStreamFilterManagerFactory->newInstance()
        );
    }
}


1		<?php
2		/**
3		* This file is part of the ZBateson\MailMimeParser project.
4		*
5		* @license http://opensource.org/licenses/bsd-license.php BSD
6		*/
7		namespace ZBateson\MailMimeParser\Message\Part;
8
9		use ZBateson\MailMimeParser\Header\HeaderFactory;
10		use ZBateson\MailMimeParser\Message\PartFilterFactory;
11
12		/**
13		* Responsible for creating MimePart instances.
14		*
15		* @author Zaahid Bateson
16		*/
17		class MimePartFactory extends MessagePartFactory
18		{
19		/**
20		* @var \ZBateson\MailMimeParser\Header\HeaderFactory the HeaderFactory
21		* instance
22		*/
23		protected $headerFactory;
24
25		/**
26		* @var \ZBateson\MailMimeParser\Header\HeaderFactory the PartFilterFactory
27		* instance
28		*/
29		protected $partFilterFactory;
30
31		/**
32		* Creates a MimePartFactory instance with its dependencies.
33		*
34		* @param PartStreamFilterManagerFactory $psf
35		* @param HeaderFactory $hf
36		* @param PartFilterFactory $pf
37		*/
38	1	public function __construct(PartStreamFilterManagerFactory $psf, HeaderFactory $hf, PartFilterFactory $pf)
39		{
40	1	parent::__construct($psf);
41	1	$this->headerFactory = $hf;
42	1	$this->partFilterFactory = $pf;
		0 ignored issues – show Documentation Bug introduced 2017-11-18 00:01 UTC by Report Bug Copy Issue Report It seems like `$pf` of type `object<ZBateson\MailMime...sage\PartFilterFactory>` is incompatible with the declared type `object<ZBateson\MailMime...r\Header\HeaderFactory>` of property `$partFilterFactory`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
43	1	}
44
45		/**
46		* Constructs a new MimePart object and returns it
47		*
48		* @param string $messageObjectId
49		* @param PartBuilder $partBuilder
50		* @return \ZBateson\MailMimeParser\Message\Part\MimePart
51		*/
52	1	public function newInstance($messageObjectId, PartBuilder $partBuilder)
53		{
54	1	return new MimePart(
55	1	$this->headerFactory,
56	1	$this->partFilterFactory,
		0 ignored issues – show Documentation introduced 2017-11-18 00:01 UTC by Report Bug Copy Issue Report `$this->partFilterFactory` is of type `object<ZBateson\MailMime...r\Header\HeaderFactory>`, but the function expects a `object<ZBateson\MailMime...sage\PartFilterFactory>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
57	1	$messageObjectId,
58	1	$partBuilder,
59	1	$this->partStreamFilterManagerFactory->newInstance()
60	1	);
61		}
62		}
63

zbateson / mail-mime-parser

Push — 1.0.0 ( fcaf32...d3c3e6 )

MimePartFactory::newInstance() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like