ZBateson\MailMimeParser\Stream\QuotedPrintableDecodeStreamFilter

Complexity

Total Complexity

7

Size/Duplication

Total Lines	81
Duplicated Lines	45.68 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getLines()	18	18	3
A	filterBucketLines()	10	10	2
A	filter()	9	9	2

<?php
/**
 * This file is part of the ZBateson\MailMimeParser project.
 *
 * @license http://opensource.org/licenses/bsd-license.php BSD
 */
namespace ZBateson\MailMimeParser\Stream;

use php_user_filter;

/**
 * @author Zaahid Bateson
 */
class QuotedPrintableDecodeStreamFilter extends php_user_filter
{
    /**
     * Name used when registering with stream_filter_register.
     */
    const STREAM_FILTER_NAME = 'convert.quoted-printable-decode';
    
    /**
     * @var string Leftovers from the last incomplete line that was parsed, to
     *      be prepended to the next line read.
     */
    private $leftover = '';
    
    /**
     * Returns an array of complete lines (including line endings) from the 
     * passed $bucket object.
     * 
     * If the last line on $bucket is incomplete, it's assigned to
     * $this->leftover and prepended to the first element of the first line in
     * the next call to getLines.
     * 
     * @param object $bucket
     * @return string[]
     */
    private function getLines($bucket)

This method seems to be duplicated in your project.

    {
        $lines = preg_split(
            '/([\r\n]+)/',
            $bucket->data,
            -1,
            PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY
        );
        if (!empty($this->leftover)) {
            $lines[0] = $this->leftover . $lines[0];
            $this->leftover = '';
        }
        $last = end($lines);
        if ($last[strlen($last) - 1] !== "\n") {
            $this->leftover = array_pop($lines);
        }
        return $lines;
    }
    
    /**
     * Filters the lines in the passed $lines array, returning a concatenated
     * string of decoded lines.
     * 
     * @param array $lines
     * @param int $consumed
     * @return string
     */
    private function filterBucketLines(array $lines, &$consumed)

This method seems to be duplicated in your project.

    {
        $data = '';
        foreach ($lines as $line) {
            $consumed += strlen($line);
            $data .= $line;
        }
        $decoded = quoted_printable_decode($data);
        return $decoded;
    }
    
    /**
     * Filter implementation converts encoding before returning PSFS_PASS_ON.
     * 
     * @param resource $in
     * @param resource $out
     * @param int $consumed
     * @param bool $closing
     * @return int
     */
    public function filter($in, $out, &$consumed, $closing)

This method seems to be duplicated in your project.

    {
        while ($bucket = stream_bucket_make_writeable($in)) {
            $lines = $this->getLines($bucket);
            $converted = $this->filterBucketLines($lines, $consumed);
            stream_bucket_append($out, stream_bucket_new($this->stream, $converted));

The property stream does not exist. Did you maybe forget to declare it?

        }
        return PSFS_PASS_ON;
    }
}