GenericConsumer - Code Metrics - Inspection of "Cleanup GenericConsumer::filterIgnoredSpaces" - zbateson/mail-mime-parser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7edc90...d4566f )

by Zaahid

created 2016-02-28 09:32 UTC

GenericConsumer A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	150
Duplicated Lines	6.67 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes	9
Bugs	3	Features	0

Metric	Value
wmc	21
c	9
b	3
f	0
lcom	2
cbo	3
dl	10
loc	150
rs	10

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getTokenSeparators()	0	4	1
A	isEndToken()	0	4	1
A	isStartToken()	0	4	1
A	getPartForToken()	10	10	4
A	getSubConsumers()	0	7	1
B	checkAddFilteredSpace()	0	14	5
B	filterIgnoredSpaces()	0	18	6
A	processParts()	0	9	2

How to fix Duplicated Code

<?php
/**
 * This file is part of the ZBateson\MailMimeParser project.
 *
 * @license http://opensource.org/licenses/bsd-license.php BSD
 */
namespace ZBateson\MailMimeParser\Header\Consumer;

use ZBateson\MailMimeParser\Header\Part\Token;

/**
 * A minimal implementation of AbstractConsumer defining a CommentConsumer and
 * QuotedStringConsumer as sub-consumers, and splitting tokens by whitespace.
 *
 * @author Zaahid Bateson
 */
class GenericConsumer extends AbstractConsumer
{
    /**
     * Returns \ZBateson\MailMimeParser\Header\Consumer\CommentConsumer and
     * \ZBateson\MailMimeParser\Header\Consumer\QuotedStringConsumer as
     * sub-consumers.
     * 
     * @return AbstractConsumer[] the sub-consumers
     */
    protected function getSubConsumers()
    {
        return [
            $this->consumerService->getCommentConsumer(),
            $this->consumerService->getQuotedStringConsumer(),
        ];
    }
    
    /**
     * Returns the regex '\s+' (whitespace) pattern matcher as a token marker so
     * the header value is split along whitespace characters.  GenericConsumer
     * filters out whitespace-only tokens from getPartForToken.
     * 
     * The whitespace character delimits mime-encoded parts for decoding.
     * 
     * @return string[] an array of regex pattern matchers
     */
    protected function getTokenSeparators()
    {
        return ['\s+'];
    }
    
    /**
     * GenericConsumer doesn't have start/end tokens, and so always returns
     * false.
     * 
     * @param string $token
     * @return boolean false
     */
    protected function isEndToken($token)
    {
        return false;
    }
    
    /**
     * GenericConsumer doesn't have start/end tokens, and so always returns
     * false.
     * 
     * @param string $token
     * @return boolean false
     */
    protected function isStartToken($token)
    {
        return false;
    }
    
    /**
     * Creates and returns a
     * \ZBateson\MailMimeParser\Header\Part\MimeLiteralPart out of the passed
     * string token and returns it.
     * 
     * @param string $token
     * @param bool $isLiteral
     * @return \ZBateson\MailMimeParser\Header\Part\HeaderPart
     */
    protected function getPartForToken($token, $isLiteral)

    {
        if (preg_match('/^\s+$/', $token) && !$isLiteral) {
            return $this->partFactory->newToken(' ');
        } elseif ($isLiteral) {
            return $this->partFactory->newLiteralPart($token);
        } else {
            return $this->partFactory->newMimeLiteralPart($token);
        }
    }
    
    /**
     * Checks if the passed space part should be added to the returned parts and
     * adds it.
     * 
     * Never adds a space if it's the first part, otherwise only add it if
     * either part isn't set to ignore the space
     * 
     * @param array $parts
     * @param array $retParts
     * @param ZBateson\MailMimeParser\Header\Part\HeaderPart $spacePart
     * @param int $curIndex
     * @return boolean true if the part was added
     */
    private function checkAddFilteredSpace(array $parts, array &$retParts, &$spacePart, $curIndex)
    {
        $lastPart = end($retParts);
        $count = count($parts);
        for ($j = $curIndex; $j < $count; ++$j) {
            $next = $parts[$j];
            if ($lastPart !== null && (!$lastPart->ignoreSpacesAfter() || !$next->ignoreSpacesBefore())) {
                $retParts[] = $spacePart;
                $spacePart = null;
                return true;
            }
        }
        return false;
    }
    
    /**
     * Filters out ignorable spaces between parts in the passed array.
     * 
     * Spaces with parts on either side of it that specify they can be ignored
     * are filtered out.  filterIgnoredSpaces is called from within
     * processParts, and if needed by an implementing class that overrides
     * processParts, must be specifically called.
     * 
     * @param ZBateson\MailMimeParser\Header\Part\HeaderPart[] $parts
     * @return ZBateson\MailMimeParser\Header\Part\HeaderPart[]
     */
    protected function filterIgnoredSpaces(array $parts)
    {
        $retParts = [];
        $spacePart = null;
        $count = count($parts);
        for ($i = 0; $i < $count; ++$i) {
            $part = $parts[$i];
            if ($part instanceof Token && $part->isSpace()) {
                $spacePart = $part;
                continue;
            } elseif ($spacePart !== null && $part->getValue() !== '') {
                $this->checkAddFilteredSpace($parts, $retParts, $spacePart, $i);
            }
            $retParts[] = $part;
        }
        // ignore trailing spaces
        return $retParts;
    }
    
    /**
     * Overridden to combine all part values into a single string and return it
     * as an array with a single element.
     * 
     * @param ZBateson\MailMimeParser\Header\Part\HeaderPart[] $parts
     * @return ZBateson\MailMimeParser\Header\Part\LiteralPart[]
     */
    protected function processParts(array $parts)
    {
        $strValue = '';
        $filtered = $this->filterIgnoredSpaces($parts);
        foreach ($filtered as $part) {
            $strValue .= $part->getValue();
        }
        return [$this->partFactory->newLiteralPart($strValue)];
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1		<?php
2		/**
3		* This file is part of the ZBateson\MailMimeParser project.
4		*
5		* @license http://opensource.org/licenses/bsd-license.php BSD
6		*/
7		namespace ZBateson\MailMimeParser\Header\Consumer;
8
9		use ZBateson\MailMimeParser\Header\Part\Token;
10
11		/**
12		* A minimal implementation of AbstractConsumer defining a CommentConsumer and
13		* QuotedStringConsumer as sub-consumers, and splitting tokens by whitespace.
14		*
15		* @author Zaahid Bateson
16		*/
17		class GenericConsumer extends AbstractConsumer
18		{
19		/**
20		* Returns \ZBateson\MailMimeParser\Header\Consumer\CommentConsumer and
21		* \ZBateson\MailMimeParser\Header\Consumer\QuotedStringConsumer as
22		* sub-consumers.
23		*
24		* @return AbstractConsumer[] the sub-consumers
25		*/
26		protected function getSubConsumers()
27		{
28		return [
29		$this->consumerService->getCommentConsumer(),
30		$this->consumerService->getQuotedStringConsumer(),
31		];
32		}
33
34		/**
35		* Returns the regex '\s+' (whitespace) pattern matcher as a token marker so
36		* the header value is split along whitespace characters. GenericConsumer
37		* filters out whitespace-only tokens from getPartForToken.
38		*
39		* The whitespace character delimits mime-encoded parts for decoding.
40		*
41		* @return string[] an array of regex pattern matchers
42		*/
43		protected function getTokenSeparators()
44		{
45		return ['\s+'];
46		}
47
48		/**
49		* GenericConsumer doesn't have start/end tokens, and so always returns
50		* false.
51		*
52		* @param string $token
53		* @return boolean false
54		*/
55		protected function isEndToken($token)
56		{
57		return false;
58		}
59
60		/**
61		* GenericConsumer doesn't have start/end tokens, and so always returns
62		* false.
63		*
64		* @param string $token
65		* @return boolean false
66		*/
67		protected function isStartToken($token)
68		{
69		return false;
70		}
71
72		/**
73		* Creates and returns a
74		* \ZBateson\MailMimeParser\Header\Part\MimeLiteralPart out of the passed
75		* string token and returns it.
76		*
77		* @param string $token
78		* @param bool $isLiteral
79		* @return \ZBateson\MailMimeParser\Header\Part\HeaderPart
80		*/
81	View Code Duplication	protected function getPartForToken($token, $isLiteral)
		0 ignored issues – show Duplication introduced 2015-11-26 00:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		{
83		if (preg_match('/^\s+$/', $token) && !$isLiteral) {
84		return $this->partFactory->newToken(' ');
85		} elseif ($isLiteral) {
86		return $this->partFactory->newLiteralPart($token);
87		} else {
88		return $this->partFactory->newMimeLiteralPart($token);
89		}
90		}
91
92		/**
93		* Checks if the passed space part should be added to the returned parts and
94		* adds it.
95		*
96		* Never adds a space if it's the first part, otherwise only add it if
97		* either part isn't set to ignore the space
98		*
99		* @param array $parts
100		* @param array $retParts
101		* @param ZBateson\MailMimeParser\Header\Part\HeaderPart $spacePart
102		* @param int $curIndex
103		* @return boolean true if the part was added
104		*/
105		private function checkAddFilteredSpace(array $parts, array &$retParts, &$spacePart, $curIndex)
106		{
107		$lastPart = end($retParts);
108		$count = count($parts);
109		for ($j = $curIndex; $j < $count; ++$j) {
110		$next = $parts[$j];
111		if ($lastPart !== null && (!$lastPart->ignoreSpacesAfter() \|\| !$next->ignoreSpacesBefore())) {
112		$retParts[] = $spacePart;
113		$spacePart = null;
114		return true;
115		}
116		}
117		return false;
118		}
119
120		/**
121		* Filters out ignorable spaces between parts in the passed array.
122		*
123		* Spaces with parts on either side of it that specify they can be ignored
124		* are filtered out. filterIgnoredSpaces is called from within
125		* processParts, and if needed by an implementing class that overrides
126		* processParts, must be specifically called.
127		*
128		* @param ZBateson\MailMimeParser\Header\Part\HeaderPart[] $parts
129		* @return ZBateson\MailMimeParser\Header\Part\HeaderPart[]
130		*/
131		protected function filterIgnoredSpaces(array $parts)
132		{
133		$retParts = [];
134		$spacePart = null;
135		$count = count($parts);
136		for ($i = 0; $i < $count; ++$i) {
137		$part = $parts[$i];
138		if ($part instanceof Token && $part->isSpace()) {
139		$spacePart = $part;
140		continue;
141		} elseif ($spacePart !== null && $part->getValue() !== '') {
142		$this->checkAddFilteredSpace($parts, $retParts, $spacePart, $i);
143		}
144		$retParts[] = $part;
145		}
146		// ignore trailing spaces
147		return $retParts;
148		}
149
150		/**
151		* Overridden to combine all part values into a single string and return it
152		* as an array with a single element.
153		*
154		* @param ZBateson\MailMimeParser\Header\Part\HeaderPart[] $parts
155		* @return ZBateson\MailMimeParser\Header\Part\LiteralPart[]
156		*/
157		protected function processParts(array $parts)
158		{
159		$strValue = '';
160		$filtered = $this->filterIgnoredSpaces($parts);
161		foreach ($filtered as $part) {
162		$strValue .= $part->getValue();
163		}
164		return [$this->partFactory->newLiteralPart($strValue)];
		0 ignored issues – show Bug Best Practice introduced 2015-11-26 00:18 UTC by Report Bug Copy Issue Report The return type of `return array($this->part...iteralPart($strValue));` (`ZBateson\MailMimeParser\Header\Part\LiteralPart[]`) is incompatible with the return type of the parent method `ZBateson\MailMimeParser\...tConsumer::processParts` of type `ZBateson\MailMimeParser\...eader\Part\HeaderPart[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
165		}
166		}
167

zbateson / mail-mime-parser

Push — master ( 7edc90...d4566f )

GenericConsumer A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like