Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | View Code Duplication | class TransactionInfo |
|
|
|||
13 | { |
||
14 | |||
15 | /** |
||
16 | * @var int |
||
17 | * @Serializer\Type("integer") |
||
18 | */ |
||
19 | protected $amount; |
||
20 | |||
21 | /** |
||
22 | * @var string |
||
23 | * @Serializer\Type("string") |
||
24 | */ |
||
25 | protected $status; |
||
26 | |||
27 | /** |
||
28 | * @var string |
||
29 | * @Serializer\Type("string") |
||
30 | */ |
||
31 | protected $transactionId; |
||
32 | |||
33 | /** |
||
34 | * @var \DateTimeInterface |
||
35 | * @Serializer\Type("DateTime<'Y-m-d\TH:i:s.u\Z'>") |
||
36 | */ |
||
37 | protected $timeStamp; |
||
38 | |||
39 | /** |
||
40 | * @var string |
||
41 | * @Serializer\Type("string") |
||
42 | */ |
||
43 | protected $transactionText; |
||
44 | |||
45 | /** |
||
46 | * Gets amount value. |
||
47 | * |
||
48 | * @return int |
||
49 | */ |
||
50 | public function getAmount() |
||
54 | |||
55 | /** |
||
56 | * Sets amount variable. |
||
57 | * |
||
58 | * @param int $amount |
||
59 | * |
||
60 | * @return $this |
||
61 | */ |
||
62 | public function setAmount($amount) |
||
67 | |||
68 | /** |
||
69 | * Gets timeStamp value. |
||
70 | * |
||
71 | * @return \DateTimeInterface |
||
72 | */ |
||
73 | public function getTimeStamp() |
||
77 | |||
78 | /** |
||
79 | * Sets timeStamp variable. |
||
80 | * |
||
81 | * @param \DateTimeInterface $timeStamp |
||
82 | * |
||
83 | * @return $this |
||
84 | */ |
||
85 | public function setTimeStamp($timeStamp) |
||
90 | |||
91 | /** |
||
92 | * Gets message value. |
||
93 | * |
||
94 | * @return string |
||
95 | */ |
||
96 | public function getTransactionText() |
||
100 | |||
101 | /** |
||
102 | * Sets message variable. |
||
103 | * |
||
104 | * @param string $message |
||
105 | * |
||
106 | * @return $this |
||
107 | */ |
||
108 | public function setTransactionText($message) |
||
113 | |||
114 | /** |
||
115 | * Gets status value. |
||
116 | * |
||
117 | * @return string |
||
118 | */ |
||
119 | public function getStatus() |
||
123 | |||
124 | /** |
||
125 | * Sets status variable. |
||
126 | * |
||
127 | * @param string $status |
||
128 | * |
||
129 | * @return $this |
||
130 | */ |
||
131 | public function setStatus($status) |
||
136 | |||
137 | /** |
||
138 | * Gets transactionId value. |
||
139 | * |
||
140 | * @return string |
||
141 | */ |
||
142 | public function getTransactionId() |
||
146 | |||
147 | /** |
||
148 | * Sets transactionId variable. |
||
149 | * |
||
150 | * @param string $transactionId |
||
151 | * |
||
152 | * @return $this |
||
153 | */ |
||
154 | public function setTransactionId($transactionId) |
||
159 | } |
||
160 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.