CompositeRouter::merge() - Code Metrics - Inspection of "Update CompositeRouter" - zapheus/skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 620416...a29fb4 )

by Rougin

created 2018-02-22 01:46 UTC

CompositeRouter::merge() A

↳ Parent: CompositeRouter

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1
crap	1

<?php

namespace App\Zapheus;

use Zapheus\Routing\Router;
use Zapheus\Routing\RouterInterface;

/**
 * Route Collection
 *
 * @package App
 * @author  Rougin Royce Gutib <[email protected]>
 */
class CompositeRouter extends Router
{
    /**
     * Namespace applied to all class-based routes.
     *
     * @var string
     */
    protected $namespace = 'App\Zapheus';

    /**
     * Merges the new route instances.
     *
     * @param  \Zapheus\Routing\RouterInterface $router
     * @return self
     */
    public function merge(RouterInterface $router)
    {
        $routes = $router->routes();

        $this->routes = array_merge($this->routes, $routes);

        return $this;
    }

    /**
     * Returns an array of route instances.
     *
     * @return \Zapheus\Routing\Route[]
     */
    public function routes()
    {
        $this->get('/scream', 'GreetController@scream');

        $this->get('/', 'GreetController@greet');

        // $this->get('/{name}', 'GreetController@greet');


        return $this->routes;
    }
}


1		<?php
2
3		namespace App\Zapheus;
4
5		use Zapheus\Routing\Router;
6		use Zapheus\Routing\RouterInterface;
7
8		/**
9		* Route Collection
10		*
11		* @package App
12		* @author Rougin Royce Gutib <[email protected]>
13		*/
14		class CompositeRouter extends Router
15		{
16		/**
17		* Namespace applied to all class-based routes.
18		*
19		* @var string
20		*/
21		protected $namespace = 'App\Zapheus';
22
23		/**
24		* Merges the new route instances.
25		*
26		* @param \Zapheus\Routing\RouterInterface $router
27		* @return self
28		*/
29	9	public function merge(RouterInterface $router)
30		{
31	9	$routes = $router->routes();
32
33	9	$this->routes = array_merge($this->routes, $routes);
34
35	9	return $this;
36		}
37
38		/**
39		* Returns an array of route instances.
40		*
41		* @return \Zapheus\Routing\Route[]
42		*/
43	9	public function routes()
44		{
45	9	$this->get('/scream', 'GreetController@scream');
46
47	9	$this->get('/', 'GreetController@greet');
48
49		// $this->get('/{name}', 'GreetController@greet');
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-02-22 01:48 UTC by Report Bug Copy Issue Report `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50
51	9	return $this->routes;
52		}
53		}
54

zapheus / skeleton

Push — master ( 620416...a29fb4 )

CompositeRouter::merge() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like