Uri::__construct() - Code Metrics - Inspection of "Update Zapheus HTTP bridge" - zapheus/psr-07-bridge - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1f627b...6e5e87 )

by Rougin

created 2018-01-20 18:42 UTC

Uri::__construct() A

↳ Parent: Uri

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	10
cts	10
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	9
nc	1
nop	1
crap	1

<?php

namespace Zapheus\Bridge\Psr\Interop;

use Psr\Http\Message\UriInterface as PsrUriInterface;
use Zapheus\Bridge\Psr\Uri as AbstractUri;
use Zapheus\Http\Message\UriInterface;

/**
 * Zapheus to PSR-07 URI Bridge
 *
 * @package Zapheus
 * @author  Rougin Royce Gutib <[email protected]>
 */
class Uri extends AbstractUri implements PsrUriInterface
{
    /**
     * Initializes the URI instance.
     *
     * @param \Zapheus\Http\Message\UriInterface $uri
     */
    public function __construct(UriInterface $uri)
    {
        $this->fragment = $uri->fragment();


        $this->host = $uri->host();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $this->path = $uri->path();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $this->port = $uri->port();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $this->query = $uri->query();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $this->scheme = $uri->scheme();


        $this->uri = $uri->__toString();

        $this->user = $uri->user();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


1		<?php
2
3		namespace Zapheus\Bridge\Psr\Interop;
4
5		use Psr\Http\Message\UriInterface as PsrUriInterface;
6		use Zapheus\Bridge\Psr\Uri as AbstractUri;
7		use Zapheus\Http\Message\UriInterface;
8
9		/**
10		* Zapheus to PSR-07 URI Bridge
11		*
12		* @package Zapheus
13		* @author Rougin Royce Gutib <[email protected]>
14		*/
15		class Uri extends AbstractUri implements PsrUriInterface
16		{
17		/**
18		* Initializes the URI instance.
19		*
20		* @param \Zapheus\Http\Message\UriInterface $uri
21		*/
22	102	public function __construct(UriInterface $uri)
23		{
24	102	$this->fragment = $uri->fragment();
		0 ignored issues – show Bug introduced 2018-01-20 18:44 UTC by Report Bug Copy Issue Report The method `fragment()` does not exist on `Zapheus\Http\Message\UriInterface`. Did you maybe mean `getFragment()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
25
26	102	$this->host = $uri->host();
		0 ignored issues – show Bug introduced 2018-01-20 18:44 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zapheus\Http\Message\UriInterface` as the method `host()` does only exist in the following implementations of said interface: `Zapheus\Bridge\Psr\Zapheus\Uri`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
27
28	102	$this->path = $uri->path();
		0 ignored issues – show Bug introduced 2018-01-20 18:44 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zapheus\Http\Message\UriInterface` as the method `path()` does only exist in the following implementations of said interface: `Zapheus\Bridge\Psr\Zapheus\Uri`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
29
30	102	$this->port = $uri->port();
		0 ignored issues – show Bug introduced 2018-01-20 18:44 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zapheus\Http\Message\UriInterface` as the method `port()` does only exist in the following implementations of said interface: `Zapheus\Bridge\Psr\Zapheus\Uri`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
31
32	102	$this->query = $uri->query();
		0 ignored issues – show Bug introduced 2018-01-20 18:44 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zapheus\Http\Message\UriInterface` as the method `query()` does only exist in the following implementations of said interface: `Zapheus\Bridge\Psr\Zapheus\Uri`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
33
34	102	$this->scheme = $uri->scheme();
		0 ignored issues – show Bug introduced 2018-01-20 18:44 UTC by Report Bug Copy Issue Report The method `scheme()` does not exist on `Zapheus\Http\Message\UriInterface`. Did you maybe mean `getScheme()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
35
36	102	$this->uri = $uri->__toString();
37
38	102	$this->user = $uri->user();
		0 ignored issues – show Bug introduced 2018-01-20 18:44 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zapheus\Http\Message\UriInterface` as the method `user()` does only exist in the following implementations of said interface: `Zapheus\Bridge\Psr\Zapheus\Uri`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
39	102	}
40		}
41

zapheus / psr-07-bridge

Push — master ( 1f627b...6e5e87 )

Uri::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like