for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace Tests\Bpost\HttpRequestBuilder;
use Bpost\BpostApiClient\Bpost\HttpRequestBuilder\FetchOrder;
use PHPUnit_Framework_TestCase;
class FetchOrderTest extends PHPUnit_Framework_TestCase
{
/**
* @param array $input
* @param string $url
* @param string $xml
* @param string $method
* @param bool $isExpectXml
* @param array $headers
*
* @return void
* @dataProvider dataResults
*/
public function testResults(array $input, $url, $xml, $headers, $method, $isExpectXml)
$builder = new FetchOrder($input[0]);
$this->assertSame($url, $builder->getUrl());
$this->assertSame($method, $builder->getMethod());
$this->assertSame($xml, $builder->getXml());
$builder->getXml()
Bpost\BpostApiClient\Bpo...er\FetchOrder::getXml()
This check looks for function or method calls that always return null and whose return value is used.
class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) {
The method getObject() can return nothing but null, so it makes no sense to use the return value.
getObject()
The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.
$this->assertSame($isExpectXml, $builder->isExpectXml());
$this->assertSame($headers, $builder->getHeaders());
}
public function dataResults()
return array(
array(
'input' => array('123'),
'url' => '/orders/123',
'xml' => null,
'headers' => array('Accept: application/vnd.bpost.shm-order-v3.3+XML'),
'method' => 'GET',
'isExpectXml' => true,
),
);
zangra-dev /
bpost-api-library
kouinkouin
This check looks for function or method calls that always return null and whose return value is used.
The method
getObject()can return nothing but null, so it makes no sense to use the return value.The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.