zangra-dev / bpost-api-library

src/Bpost/Label.php

<?php

namespace Bpost\BpostApiClient\Bpost;

use Bpost\BpostApiClient\Bpost\Label\Barcode;
use Bpost\BpostApiClient\Exception\BpostLogicException\BpostInvalidValueException;
use SimpleXMLElement;

/**
 * bPost Label class
 *
 * @author Tijs Verkoyen <php-bpost@verkoyen.eu>
 */
class Label
{
    const LABEL_MIME_TYPE_IMAGE_PNG = 'image/png';
    const LABEL_MIME_TYPE_IMAGE_PDF = 'image/pdf';
    const LABEL_MIME_TYPE_APPLICATION_PDF = 'application/pdf';

    /**
     * @var Barcode[]
     */
    private $barcodes;

    /**
     * @var string
     */
    private $mimeType;

    /**
     * @var string
     */
    private $bytes;

    /**
     * @param Barcode $barcode
     */
    public function addBarcode(Barcode $barcode)
    {
        $this->barcodes[] = $barcode;
    }

    /**
     * @return string
     */
    public function getBarcode()
    {
        if (is_array($this->getBarcodes())) {

The condition is_array($this->getBarcodes()) is always true.

            $barcode = current($this->getBarcodes());

            return $barcode->getBarcode();
        }

        return '';
    }

    /**
     * @param Barcode[] $barcodes
     */
    public function setBarcodes(array $barcodes)
    {
        $this->barcodes = $barcodes;
    }

    /**
     * @return Barcode[]
     */
    public function getBarcodes()
    {
        return $this->barcodes;
    }

    /**
     * @param string $bytes
     */
    public function setBytes($bytes)
    {
        $this->bytes = $bytes;
    }

    /**
     * @return string
     */
    public function getBytes()
    {
        return $this->bytes;
    }

    /**
     * @param string $mimeType
     *
     * @throws BpostInvalidValueException
     */
    public function setMimeType($mimeType)
    {
        if (!in_array($mimeType, self::getPossibleMimeTypeValues())) {
            throw new BpostInvalidValueException('mimeType', $mimeType, self::getPossibleMimeTypeValues());
        }

        $this->mimeType = $mimeType;
    }

    /**
     * @return string
     */
    public function getMimeType()
    {
        return $this->mimeType;
    }

    /**
     * @return array
     */
    public static function getPossibleMimeTypeValues()
    {
        return array(
            self::LABEL_MIME_TYPE_IMAGE_PNG,
            self::LABEL_MIME_TYPE_IMAGE_PDF,
            self::LABEL_MIME_TYPE_APPLICATION_PDF,
        );
    }

    /**
     * Output the bytes directly to the screen
     */
    public function output()
    {
        header('Content-type: ' . $this->getMimeType());
        echo $this->getBytes();
        exit;

Using exit here is not recommended.

    }

    /**
     * @param SimpleXMLElement $xml
     *
     * @return Label
     *
     * @throws BpostInvalidValueException
     */
    public static function createFromXML(SimpleXMLElement $xml)
    {
        $label = new Label();
        if (isset($xml->barcodeWithReference)) {
            foreach ($xml->barcodeWithReference as $barcodeWithReference) {
                $label->addBarcode(Barcode::createFromXML($barcodeWithReference));

It seems like $barcodeWithReference can also be of type null; however, parameter $xml of Bpost\BpostApiClient\Bpost\Label\Barcode::createFromXML() does only seem to accept SimpleXMLElement, maybe add an additional type check?

            }
        }
        if (isset($xml->mimeType) && $xml->mimeType != '') {
            $label->setMimeType((string) $xml->mimeType);
        }
        if (isset($xml->bytes) && $xml->bytes != '') {
            $label->setBytes((string) base64_decode($xml->bytes));
        }

        return $label;
    }
}