zaherkhirullah / laravel-likes

src/Traits/Likable.php

<?php

namespace Hayrullah\Likes\Traits;

use Hayrullah\LaravelLikes\Models\Like;

The type Hayrullah\LaravelLikes\Models\Like was not found. Maybe you did not declare it correctly or list all dependencies?

use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Relations\MorphMany;
use Illuminate\Support\Facades\Auth;

/**
 *
 * @license MIT
 * @package Hayrullah/laravel-likes
 *
 * Copyright @2020 Zaher Khirullah
 */
trait Likable
{
    /**
     * Add deleted observer to delete likes registers
     *
     * @return void
     */
    public static function bootLikable()
    {
        static::deleted(function ($model) {
            $model->likes()->delete();
        });
    }

    /**
     * Toggle the like status from this Object
     *
     * @param int $user_id
     */
    public function toggleLike($user_id = null)
    {
        $this->isLiked($user_id) ? $this->removeLike($user_id) : $this->addLike($user_id);
    }

    /**
     * Check if the user has liked this Object
     *
     * @param int $user_id
     *
     * @return boolean
     */
    public function isLiked($user_id = null)
    {
        return $this->likes()->where('user_id', $this->getUserId($user_id))->exists();

Are you sure the usage of $this->getUserId($user_id) targeting Hayrullah\Likes\Traits\Likable::getUserId() seems to always return null.

It seems like $user_id can also be of type integer; however, parameter $user_id of Hayrullah\Likes\Traits\Likable::getUserId() does only seem to accept null, maybe add an additional type check?

    }

    /**
     * Define a polymorphic one-to-many relationship.
     *
     * @return MorphMany
     */
    public function likes()
    {
        return $this->morphMany(Like::class, 'likable');

It seems like morphMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param null $user_id (if null its added to the auth user)

Are you sure the doc-type for parameter $user_id is correct as it would always require null to be passed?

     *
     * @return null
     */
    private function getUserId($user_id = null)
    {
        $user_id = ($user_id) ? $user_id : null;

$user_id is of type null, thus it always evaluated to false.

        if (!$user_id) {

$user_id is of type null, thus it always evaluated to false.

            \auth()->check() ? Auth::id() : null;
        }

        return $user_id;
    }

    /**
     * Remove this Object from the user likes
     *
     * @param int $user_id [if  null its added to the auth user]
     *
     */
    public function removeLike($user_id = null)
    {
        $this->likes()->where('user_id', $this->getUserId($user_id))->delete();

Are you sure the usage of $this->getUserId($user_id) targeting Hayrullah\Likes\Traits\Likable::getUserId() seems to always return null.

It seems like $user_id can also be of type integer; however, parameter $user_id of Hayrullah\Likes\Traits\Likable::getUserId() does only seem to accept null, maybe add an additional type check?

    }

    /**
     * Add this Object to the user likes
     *
     * @param int $user_id
     */
    public function addLike($user_id = null)
    {
        $like = new Like(['user_id' => $this->getUserId($user_id)]);

It seems like $user_id can also be of type integer; however, parameter $user_id of Hayrullah\Likes\Traits\Likable::getUserId() does only seem to accept null, maybe add an additional type check?

Are you sure the usage of $this->getUserId($user_id) targeting Hayrullah\Likes\Traits\Likable::getUserId() seems to always return null.

        $this->likes()->save($like);
    }

    /**
     * Return a collection with the Users who marked as like this Object.
     *
     * @return Collection
     */
    public function likedBy()
    {
        $likes = $this->likes()->with('user')->get();

        return $likes->mapWithKeys(function ($like) {
            return [$like['user']->id => $like['user']];
        });
    }

    /**
     * Count the number of likes
     *
     * @return int
     */
    public function getLikesCountAttribute()
    {
        return $this->likes()->count();
    }

    /**
     * @return likesCount attribute

The type Hayrullah\Likes\Traits\likesCount was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function likesCount()
    {
        return $this->likes_count;
    }
}