OrderField::rules() - Code Metrics - Inspection of "tests" - zacksleo/yii2-shop - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bac038...c56098 )

by zacksleo

created 2017-09-04 02:48 UTC

OrderField::rules() A

↳ Parent: OrderField

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	16
ccs	3
cts	3
cp	1
rs	9.4285
cc	1
eloc	11
nc	1
nop	0
crap	1

<?php

namespace zacksleo\yii2\shop\models;

use Yii;
use yii\db\ActiveRecord;
use yii\helpers\ArrayHelper;
use yii\helpers\Json;
use yii\base\DynamicModel;
use yii\base\InvalidParamException;

/**
 * This is the model class for table "{{%order_field}}".
 *
 * @property integer $id
 * @property integer $order_id
 * @property string $type
 * @property string $key
 * @property string $value
 */
class OrderField extends \yii\db\ActiveRecord
{
    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return '{{%order_field}}';
    }

    /**
     * @param bool $forDropDown if false - return array or validators, true - key=>value for dropDown
     * @return array
     */
    public function getTypes($forDropDown = true)
    {
        $values = [
            'string' => ['value', 'string'],
            'integer' => ['value', 'integer'],
            'boolean' => ['value', 'boolean', 'trueValue' => "1", 'falseValue' => "0", 'strict' => true],
            'float' => ['value', 'number'],
            'email' => ['value', 'email'],
            'ip' => ['value', 'ip'],
            'url' => ['value', 'url'],
            'object' => [
                'value',
                function ($attribute, $params) {

                    $object = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    try {
                        Json::decode($this->$attribute);
                    } catch (InvalidParamException $e) {
                        $this->addError($attribute, "$attribute must be a valid JSON object");
                    }
                }
            ],
        ];

        if (!$forDropDown) {
            return $values;
        }

        $return = [];
        foreach ($values as $key => $value) {
            $return[$key] = $key;
        }

        return $return;
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            ['order_id', 'integer'],
            [['value'], 'string'],
            ['key', 'string', 'max' => 255],
            [
                ['key'],
                'unique',
                'targetAttribute' => ['order_id', 'key'],
                'message' => '{attribute} "{value}" already exists for this section.'
            ],
            ['type', 'in', 'range' => array_keys($this->getTypes(false))],
            ['type', 'safe'],
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => 'id',
            'type' => 'Type',
            'order_id' => 'order_id',
            'key' => 'Key',
            'value' => 'Value',
        ];
    }

    public function beforeSave($insert)
    {
        $validators = $this->getTypes(false);
        if (!array_key_exists($this->type, $validators)) {
            $this->addError('type', 'Please select correct type');
            return false;
        }

        $model = DynamicModel::validateData([
            'value' => $this->value
        ], [
            $validators[$this->type],
        ]);

        if ($model->hasErrors()) {
            $this->addError('value', $model->getFirstError('value'));
            return false;
        }

        if ($this->hasErrors()) {
            return false;
        }

        return parent::beforeSave($insert);
    }

    /**
     * @inheritdoc
     */
    public function getSettings()
    {
        $settings = static::find()->asArray()->all();
        return array_merge_recursive(
            ArrayHelper::map($settings, 'key', 'value', 'order_id'),
            ArrayHelper::map($settings, 'key', 'type', 'order_id')
        );
    }

    /**
     * @inheritdoc
     */
    public function setSetting($order_id, $key, $value, $type = null)
    {
        $model = static::findOne(['order_id' => $order_id, 'key' => $key]);

        if ($model === null) {
            $model = new static();
        }
        $model->order_id = $order_id;
        $model->key = $key;
        $model->value = strval($value);

        if ($type !== null) {
            $model->type = $type;
        } else {
            $t = gettype($value);
            if ($t == 'string') {
                $error = false;
                try {
                    Json::decode($value);
                } catch (InvalidParamException $e) {
                    $error = true;
                }
                if (!$error) {
                    $t = 'object';
                }
            }
            $model->type = $t;
        }

        return $model->save();
    }

    /**
     * @inheritdoc
     */
    public function deleteSetting($order_id, $key)
    {
        $model = static::findOne(['order_id' => $order_id, 'key' => $key]);

        if ($model) {
            return $model->delete();
        }
        return true;
    }

    /**
     * @param $key
     * @param $order_id
     * @return array|null|ActiveRecord
     */
    public function findSetting($key, $order_id)
    {
        return $this->find()->where(['order_id' => $order_id, 'key' => $key])->limit(1)->one();
    }
}


1		<?php
2
3		namespace zacksleo\yii2\shop\models;
4
5		use Yii;
6		use yii\db\ActiveRecord;
7		use yii\helpers\ArrayHelper;
8		use yii\helpers\Json;
9		use yii\base\DynamicModel;
10		use yii\base\InvalidParamException;
11
12		/**
13		* This is the model class for table "{{%order_field}}".
14		*
15		* @property integer $id
16		* @property integer $order_id
17		* @property string $type
18		* @property string $key
19		* @property string $value
20		*/
21		class OrderField extends \yii\db\ActiveRecord
22		{
23		/**
24		* @inheritdoc
25		*/
26	3	public static function tableName()
27		{
28	3	return '{{%order_field}}';
29		}
30
31		/**
32		* @param bool $forDropDown if false - return array or validators, true - key=>value for dropDown
33		* @return array
34		*/
35	2	public function getTypes($forDropDown = true)
36		{
37		$values = [
38	2	'string' => ['value', 'string'],
39		'integer' => ['value', 'integer'],
40		'boolean' => ['value', 'boolean', 'trueValue' => "1", 'falseValue' => "0", 'strict' => true],
41		'float' => ['value', 'number'],
42		'email' => ['value', 'email'],
43		'ip' => ['value', 'ip'],
44		'url' => ['value', 'url'],
45		'object' => [
46	2	'value',
47	2	function ($attribute, $params) {
		0 ignored issues – show Unused Code introduced 2017-09-03 15:35 UTC by Report Bug Copy Issue Report The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
48		$object = null;
		0 ignored issues – show Unused Code introduced 2017-09-03 15:35 UTC by Report Bug Copy Issue Report `$object` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
49		try {
50		Json::decode($this->$attribute);
51		} catch (InvalidParamException $e) {
52		$this->addError($attribute, "$attribute must be a valid JSON object");
53		}
54	2	}
55		],
56		];
57
58	2	if (!$forDropDown) {
59	1	return $values;
60		}
61
62	1	$return = [];
63	1	foreach ($values as $key => $value) {
64	1	$return[$key] = $key;
65		}
66
67	1	return $return;
68		}
69
70		/**
71		* @inheritdoc
72		*/
73	1	public function rules()
74		{
75		return [
76	1	['order_id', 'integer'],
77		[['value'], 'string'],
78		['key', 'string', 'max' => 255],
79		[
80		['key'],
81		'unique',
82		'targetAttribute' => ['order_id', 'key'],
83		'message' => '{attribute} "{value}" already exists for this section.'
84		],
85	1	['type', 'in', 'range' => array_keys($this->getTypes(false))],
86		['type', 'safe'],
87		];
88		}
89
90		/**
91		* @inheritdoc
92		*/
93	2	public function attributeLabels()
94		{
95		return [
96	2	'id' => 'id',
97		'type' => 'Type',
98		'order_id' => 'order_id',
99		'key' => 'Key',
100		'value' => 'Value',
101		];
102		}
103
104		public function beforeSave($insert)
105		{
106		$validators = $this->getTypes(false);
107		if (!array_key_exists($this->type, $validators)) {
108		$this->addError('type', 'Please select correct type');
109		return false;
110		}
111
112		$model = DynamicModel::validateData([
113		'value' => $this->value
114		], [
115		$validators[$this->type],
116		]);
117
118		if ($model->hasErrors()) {
119		$this->addError('value', $model->getFirstError('value'));
120		return false;
121		}
122
123		if ($this->hasErrors()) {
124		return false;
125		}
126
127		return parent::beforeSave($insert);
128		}
129
130		/**
131		* @inheritdoc
132		*/
133		public function getSettings()
134		{
135		$settings = static::find()->asArray()->all();
136		return array_merge_recursive(
137		ArrayHelper::map($settings, 'key', 'value', 'order_id'),
138		ArrayHelper::map($settings, 'key', 'type', 'order_id')
139		);
140		}
141
142		/**
143		* @inheritdoc
144		*/
145	1	public function setSetting($order_id, $key, $value, $type = null)
146		{
147	1	$model = static::findOne(['order_id' => $order_id, 'key' => $key]);
148
149	1	if ($model === null) {
150	1	$model = new static();
151		}
152	1	$model->order_id = $order_id;
153	1	$model->key = $key;
154	1	$model->value = strval($value);
155
156	1	if ($type !== null) {
157	1	$model->type = $type;
158		} else {
159		$t = gettype($value);
160		if ($t == 'string') {
161		$error = false;
162		try {
163		Json::decode($value);
164		} catch (InvalidParamException $e) {
165		$error = true;
166		}
167		if (!$error) {
168		$t = 'object';
169		}
170		}
171		$model->type = $t;
172		}
173
174	1	return $model->save();
175		}
176
177		/**
178		* @inheritdoc
179		*/
180	1	public function deleteSetting($order_id, $key)
181		{
182	1	$model = static::findOne(['order_id' => $order_id, 'key' => $key]);
183
184	1	if ($model) {
185		return $model->delete();
186		}
187	1	return true;
188		}
189
190		/**
191		* @param $key
192		* @param $order_id
193		* @return array\|null\|ActiveRecord
194		*/
195		public function findSetting($key, $order_id)
196		{
197		return $this->find()->where(['order_id' => $order_id, 'key' => $key])->limit(1)->one();
198		}
199		}
200

zacksleo / yii2-shop

Push — master ( bac038...c56098 )

OrderField::rules() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like