Item::getItemCategory() - Code Metrics - Inspection of "build(composer): update yii2-settings depend" - zacksleo/yii2-cms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f5277c...2a14a8 )

by zacksleo

created 2018-08-09 12:08 UTC

Item::getItemCategory() A

↳ Parent: Item

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
rs	10
c	0
b	0
f	0
ccs	4
cts	4
cp	1
cc	1
nc	1
nop	0
crap	1

<?php

namespace zacksleo\yii2\cms\models;

use nemmo\attachments\models\File;
use Yii;
use yii\behaviors\TimestampBehavior;
use yii\helpers\Url;
use zacksleo\yii2\cms\models\queries\ItemQuery;

/**
 * This is the model class for table "{{%item}}".
 *
 * @property integer $id
 * @property string $item_name
 * @property string $categories
 * @property string $market_price
 * @property integer $price
 * @property string $description
 * @property integer $status
 * @property integer $subtitle
 * @property integer $created_at
 * @property integer $updated_at
 * @property string $logo_image
 * @property string $url
 */
class Item extends \yii\db\ActiveRecord
{
    const STATUS_ACTIVE = 1;
    const STATUS_INACTIVE = 0;

    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return '{{%item}}';
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            [['item_name', 'subtitle', 'categories', 'description'], 'required'],
            [['status', 'created_at', 'updated_at'], 'integer'],
            ['status', 'default', 'value' => self::STATUS_ACTIVE],
            [['market_price', 'price'], 'number'],
            [['description', 'categories'], 'string'],
            [['item_name', 'logo_image', 'subtitle'], 'string', 'max' => 125],
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => 'ID',
            'item_name' => '商品名称',
            'subtitle' => '副标题',
            'categories' => '商品类别',
            'market_price' => '市场价',
            'price' => '价格',
            'description' => '简介',
            'status' => '状态',
            'created_at' => '创建时间',
            'updated_at' => '更新时间',
            'logo_image' => '缩略图'
        ];
    }

    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            'timestamp' => [
                'class' => TimestampBehavior::className(),

            ],
            'fileBehavior' => [
                'class' => \nemmo\attachments\behaviors\FileBehavior::className()

            ]
        ];
    }

    /**
     * @return string
     */
    public function getUrl()
    {
        return Url::to(['item/view', 'id' => $this->id]);
    }

    /**
     * @return ItemCategory
     */
    public function getItemCategory()
    {
        $ids = explode(',', $this->categories);
        $category_id = array_shift($ids);
        return ItemCategory::findOne($category_id);

    }

    /**
     * @return array
     */
    public function getItemCategories()
    {
        $ids = explode(',', $this->categories);
        $res = [];
        foreach ($ids as $id) {
            $res[] = ItemCategory::findOne($id);
        }
        return $res;
    }

    public function getItemCategoriesName()
    {
        $categories = $this->getItemCategories();
        $labels = [];
        foreach ($categories as $category) {
            $labels[] = $category->name;
        }
        return implode(',', $labels);
    }

    public static function getStatusList()
    {
        return [
            self::STATUS_INACTIVE => '下线',
            self::STATUS_ACTIVE => '上线',
        ];
    }

    public function getImage()
    {
        if ($this->files && $this->files[0] instanceof File) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return $this->files[0]->getUrl();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return 'https://ws1.sinaimg.cn/large/a76d6e45gy1fj5d3ckxgej205x05vaa4.jpg';
    }

    public static function find()
    {
        return new ItemQuery(get_called_class());
    }

    public function beforeSave($insert)
    {
        $this->categories = ',' . trim($this->categories, ',') . ',';
        return parent::beforeSave($insert);
    }

    public function afterFind()
    {
        $this->categories = trim($this->categories, ',');
        parent::afterFind();
    }
}


1		<?php
2
3		namespace zacksleo\yii2\cms\models;
4
5		use nemmo\attachments\models\File;
6		use Yii;
7		use yii\behaviors\TimestampBehavior;
8		use yii\helpers\Url;
9		use zacksleo\yii2\cms\models\queries\ItemQuery;
10
11		/**
12		* This is the model class for table "{{%item}}".
13		*
14		* @property integer $id
15		* @property string $item_name
16		* @property string $categories
17		* @property string $market_price
18		* @property integer $price
19		* @property string $description
20		* @property integer $status
21		* @property integer $subtitle
22		* @property integer $created_at
23		* @property integer $updated_at
24		* @property string $logo_image
25		* @property string $url
26		*/
27		class Item extends \yii\db\ActiveRecord
28		{
29		const STATUS_ACTIVE = 1;
30		const STATUS_INACTIVE = 0;
31
32		/**
33		* @inheritdoc
34		*/
35	4	public static function tableName()
36		{
37	4	return '{{%item}}';
38		}
39
40		/**
41		* @inheritdoc
42		*/
43	1	public function rules()
44		{
45		return [
46	1	[['item_name', 'subtitle', 'categories', 'description'], 'required'],
47	1	[['status', 'created_at', 'updated_at'], 'integer'],
48	1	['status', 'default', 'value' => self::STATUS_ACTIVE],
49	1	[['market_price', 'price'], 'number'],
50	1	[['description', 'categories'], 'string'],
51	1	[['item_name', 'logo_image', 'subtitle'], 'string', 'max' => 125],
52	1	];
53		}
54
55		/**
56		* @inheritdoc
57		*/
58		public function attributeLabels()
59		{
60		return [
61		'id' => 'ID',
62		'item_name' => '商品名称',
63		'subtitle' => '副标题',
64		'categories' => '商品类别',
65		'market_price' => '市场价',
66		'price' => '价格',
67		'description' => '简介',
68		'status' => '状态',
69		'created_at' => '创建时间',
70		'updated_at' => '更新时间',
71		'logo_image' => '缩略图'
72		];
73		}
74
75		/**
76		* @inheritdoc
77		*/
78	4	public function behaviors()
79		{
80		return [
81		'timestamp' => [
82	4	'class' => TimestampBehavior::className(),
		0 ignored issues – show Deprecated Code introduced 2018-07-16 09:04 UTC by Report Bug Copy Issue Report The method `yii\base\BaseObject::className()` has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
83	4	],
84		'fileBehavior' => [
85	4	'class' => \nemmo\attachments\behaviors\FileBehavior::className()
		0 ignored issues – show Deprecated Code introduced 2018-07-16 09:04 UTC by Report Bug Copy Issue Report The method `yii\base\BaseObject::className()` has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
86	4	]
87	4	];
88		}
89
90		/**
91		* @return string
92		*/
93		public function getUrl()
94		{
95		return Url::to(['item/view', 'id' => $this->id]);
96		}
97
98		/**
99		* @return ItemCategory
100		*/
101	1	public function getItemCategory()
102		{
103	1	$ids = explode(',', $this->categories);
104	1	$category_id = array_shift($ids);
105	1	return ItemCategory::findOne($category_id);
		0 ignored issues – show Bug Compatibility introduced 2017-12-28 15:35 UTC by Report Bug Copy Issue Report The expression `\zacksleo\yii2\cms\model...:findOne($category_id);` of type `yii\db\ActiveRecordInterface\|array\|null` adds the type `array` to the return on line 105 which is incompatible with the return type documented by `zacksleo\yii2\cms\models\Item::getItemCategory` of type `zacksleo\yii2\cms\models\ItemCategory\|null`. Loading history...
106		}
107
108		/**
109		* @return array
110		*/
111	2	public function getItemCategories()
112		{
113	2	$ids = explode(',', $this->categories);
114	2	$res = [];
115	2	foreach ($ids as $id) {
116	2	$res[] = ItemCategory::findOne($id);
117	2	}
118	2	return $res;
119		}
120
121	1	public function getItemCategoriesName()
122		{
123	1	$categories = $this->getItemCategories();
124	1	$labels = [];
125	1	foreach ($categories as $category) {
126	1	$labels[] = $category->name;
127	1	}
128	1	return implode(',', $labels);
129		}
130
131	1	public static function getStatusList()
132		{
133		return [
134	1	self::STATUS_INACTIVE => '下线',
135	1	self::STATUS_ACTIVE => '上线',
136	1	];
137		}
138
139		public function getImage()
140		{
141		if ($this->files && $this->files[0] instanceof File) {
		0 ignored issues – show Documentation introduced 2017-12-28 15:35 UTC by Report Bug Copy Issue Report The property `files` does not exist on `object<zacksleo\yii2\cms\models\Item>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
142		return $this->files[0]->getUrl();
		0 ignored issues – show Documentation introduced 2017-12-28 15:35 UTC by Report Bug Copy Issue Report The property `files` does not exist on `object<zacksleo\yii2\cms\models\Item>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
143		}
144		return 'https://ws1.sinaimg.cn/large/a76d6e45gy1fj5d3ckxgej205x05vaa4.jpg';
145		}
146
147	3	public static function find()
148		{
149	3	return new ItemQuery(get_called_class());
150		}
151
152	1	public function beforeSave($insert)
153		{
154	1	$this->categories = ',' . trim($this->categories, ',') . ',';
155	1	return parent::beforeSave($insert);
156		}
157
158	3	public function afterFind()
159		{
160	3	$this->categories = trim($this->categories, ',');
161	3	parent::afterFind();
162	3	}
163		}
164

zacksleo / yii2-cms

Push — master ( f5277c...2a14a8 )

Item::getItemCategory() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like