zacksleo\yii2\backend\tests\controllers\AdminController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	98
Duplicated Lines	28.57 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	actionIndex()	0	6	1
A	actionView()	0	4	1
A	actionCreate()	0	6	2
A	actionUpdate()	0	5	2
A	actionDelete()	0	4	1
A	behaviors()	20	20	1
A	findModel()	8	8	2

<?php

namespace zacksleo\yii2\backend\tests\controllers;

use Yii;
use zacksleo\yii2\backend\models\Admin;
use yii\data\ActiveDataProvider;
use yii\web\Controller;
use yii\web\NotFoundHttpException;
use yii\filters\VerbFilter;
use yii\filters\AccessControl;

/**
 * AdminController implements the CRUD actions for Admin model.
 */
class AdminController extends Controller
{
    /**
     * @inheritdoc
     */
    public function behaviors()

This method seems to be duplicated in your project.

    {
        return [
            'access' => [
                'class' => AccessControl::className(),

The method yii\base\BaseObject::className() has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead.

                'rules' => [
                    [
                        'allow' => true,
                        'roles' => ['@'],
                    ]
                ]
            ],
            'verbs' => [
                'class' => VerbFilter::className(),

The method yii\base\BaseObject::className() has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead.

                'actions' => [
                    'delete' => ['GET'],
                ],
            ],
        ];
    }

    /**
     * Lists all Admin models.
     * @return yii\data\ActiveDataProvider
     */
    public function actionIndex()
    {
        return $dataProvider = new ActiveDataProvider([

$dataProvider is not used, you could remove the assignment.

            'query' => Admin::find(),
        ]);
    }

    /**
     * Displays a single Admin model.
     * @param integer $id
     * @return mixed
     */
    public function actionView($id)
    {
        return $this->findModel($id);
    }

    /**
     * Creates a new Admin model.
     * If creation is successful, the browser will be redirected to the 'view' page.
     * @return mixed
     */
    public function actionCreate()
    {
        $model = new Admin();
        $model->load(Yii::$app->request->post()) && $model->save();
        return $model;
    }

    /**
     * Updates an existing Admin model.
     * If update is successful, the browser will be redirected to the 'view' page.
     * @param integer $id
     * @return mixed
     */
    public function actionUpdate($id)
    {
        $model = $this->findModel($id);
        return $model->load(Yii::$app->request->post()) && $model->save();
    }

    /**
     * Deletes an existing Admin model.
     * If deletion is successful, the browser will be redirected to the 'index' page.
     * @param integer $id
     * @return mixed
     */
    public function actionDelete($id)
    {
        return $this->findModel($id)->delete();
    }

    /**
     * Finds the Admin model based on its primary key value.
     * If the model is not found, a 404 HTTP exception will be thrown.
     * @param integer $id
     * @return Admin the loaded model
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findModel($id)

This method seems to be duplicated in your project.

    {
        if (($model = Admin::findOne($id)) !== null) {

The expression \zacksleo\yii2\backend\models\Admin::findOne($id); of type yii\db\ActiveRecordInterface|array|null adds the type array to the return on line 108 which is incompatible with the return type documented by zacksleo\yii2\backend\tests\controllers\AdminController::findModel of type zacksleo\yii2\backend\models\Admin.

            return $model;
        } else {
            throw new NotFoundHttpException('The requested page does not exist.');
        }
    }
}