m170218_063150_create_ad_position_table::up() - Code Metrics - zacksleo/yii2-ad - Measure and Improve Code Quality continuously with Scrutinizer

m170218_063150_create_ad_position_table::up() A
last analyzed 2019-03-15 02:41 UTC

↳ Parent: m170218_063150_create_ad_position_table

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php

use yii\db\Migration;

/**
 * Handles the creation of table `ad_position`.
 */
class m170218_063150_create_ad_position_table extends Migration
{
    /**
     * @inheritdoc
     */
    public function up()
    {
        $tableOptions = null;
        if ($this->db->driverName === 'mysql') {
            $tableOptions = 'CHARACTER SET utf8 COLLATE utf8_general_ci ENGINE=InnoDB';
        }
        $this->createTable('{{%ad_position}}', [
            'id' => $this->primaryKey(),
            'name' => $this->string()->notNull(),
            'slug' => $this->string()->notNull()->unique(),
            'size' => $this->string(),
            'status' => $this->boolean(),
        ], $tableOptions);
        return true;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    public function down()
    {
        $this->dropTable('{{%ad_position}}');
        return true;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			use yii\db\Migration;
4
5			/**
6			* Handles the creation of table `ad_position`.
7			*/
8			class m170218_063150_create_ad_position_table extends Migration
9			{
10			/**
11			* @inheritdoc
12			*/
13			public function up()
14			{
15			$tableOptions = null;
16			if ($this->db->driverName === 'mysql') {
17			$tableOptions = 'CHARACTER SET utf8 COLLATE utf8_general_ci ENGINE=InnoDB';
18			}
19			$this->createTable('{{%ad_position}}', [
20			'id' => $this->primaryKey(),
21			'name' => $this->string()->notNull(),
22			'slug' => $this->string()->notNull()->unique(),
23			'size' => $this->string(),
24			'status' => $this->boolean(),
25			], $tableOptions);
26			return true;
			0 ignored issues – show Bug Best Practice introduced 2017-09-01 05:28 UTC by Report Bug Copy Issue Report The return type of `return true;` (`boolean`) is incompatible with the return type of the parent method `yii\db\Migration::up` of type `false\|null`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
27			}
28
29			/**
30			* @inheritdoc
31			*/
32			public function down()
33			{
34			$this->dropTable('{{%ad_position}}');
35			return true;
			0 ignored issues – show Bug Best Practice introduced 2017-09-01 05:28 UTC by Report Bug Copy Issue Report The return type of `return true;` (`boolean`) is incompatible with the return type of the parent method `yii\db\Migration::down` of type `false\|null`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
36			}
37			}
38

zacksleo / yii2-ad

m170218_063150_create_ad_position_table::up() A last analyzed 2019-03-15 02:41 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

m170218_063150_create_ad_position_table::up() A
last analyzed 2019-03-15 02:41 UTC