zackebth / rm2Flash

test/flash_test.js

describe('Unit testing Angular Flash', function() {
    var $compile,
        $rootScope,
        $interval,
        node,
        Flash;

    beforeEach(module('rv2Flash'));

    beforeEach(inject(function(_$compile_, _$rootScope_, _$interval_, _Flash_) {
        $compile = _$compile_;
        $rootScope = _$rootScope_;
        $interval = _$interval_;
        Flash = _Flash_;
    }));

    beforeEach(function() {
        node = $compile('<div><flash-message duration=1000></flash-message></div>')($rootScope);
    });

    it('replaces the element with the appropriate content', function() {
        var contents = node.contents();
        expect(contents[0].nodeType).toEqual(Node.ELEMENT_NODE);

The variable Node seems to be never declared. If this is a global, consider adding a /** global: Node */ comment.

    });

    it('avoid to display flash when it does not have content', function() {
        created = Flash.create('success', '');

The variable created seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.created.

        $rootScope.$digest();
        var contents = node.contents()[0];
        expect(contents.querySelectorAll('.alert').length).toEqual(0);
        expect(created).toEqual(false);
    });

    it('has the class specified', function() {
        var testClassName = 'test-class';
        Flash.create('success', 'Good job', 10000, {class: testClassName});
        $rootScope.$digest();
        var contents = node.contents()[0];
        expect(contents.querySelectorAll('.alert')[0].classList).toContain(testClassName);
    });

    it('has the id specified', function() {
        var testIdName = 'test-id';
        Flash.create('success', 'Good job', 10000, {id: testIdName});
        $rootScope.$digest();
        var contents = node.contents()[0];
        expect(contents.querySelectorAll('.alert')[0].id).toContain(testIdName);
    });

    it('shows the flash when created and removes when deleted', function() {
        Flash.create('success', 'All good');
        $rootScope.$digest();
        var contents = node.contents()[0];
        expect(contents.querySelectorAll('.alert').length).toEqual(1);
        Flash.dismiss(0);
        $rootScope.$digest();
        expect(contents.querySelectorAll('.alert').length).toEqual(0);
    });

    it('clears all when clear is called', function() {
        for (var i = 0; i < 10; ++i) {
            Flash.create('success', 'All good');
        }
        $rootScope.$digest();
        var contents = node.contents()[0];
        expect(contents.querySelectorAll('.alert').length).toEqual(10);
        Flash.clear();
        $rootScope.$digest();
        expect(contents.querySelectorAll('.alert').length).toEqual(0);
    });

    it('is dismissed after timeout', function() {
        Flash.create('success', 'All good', 10000);
        $rootScope.$digest();
        var contents = node.contents()[0];
        $interval.flush(3000);
        expect(contents.querySelectorAll('.alert').length).toEqual(1);

        $interval.flush(10000);
        $rootScope.$digest();
        expect(contents.querySelectorAll('.alert').length).toEqual(0);
    });

    describe('show flashes in designated containers', function() {
        var containers;

        beforeEach(function() {
            containers = $compile(
                '<flash-message duration=1000></flash-message>' +
                '<flash-message duration=1000 name="flash-container-a"></flash-message>' +
                '<flash-message duration=1000 name="flash-container-b"></flash-message>')($rootScope);

            Flash.create('success', 'All good');
            Flash.create('success', 'All good - A', 0, { container: 'flash-container-a'});
            Flash.create('success', 'All good - B', 0, { container: 'flash-container-b'});

            $rootScope.$digest();
        });

        it('only shows default alert in default container', function() {
            expect(containers[0].querySelectorAll('.alert').length).toEqual(1);
            expect(containers[0].outerHTML).toContain('All good');
            expect(containers[0].outerHTML).not.toContain('All good - A');
            expect(containers[0].outerHTML).not.toContain('All good - B');
        });

        it('only shows alert A in container A', function() {
            expect(containers[1].querySelectorAll('.alert').length).toEqual(1);
            expect(containers[1].outerHTML).toContain('All good - A');
            expect(containers[1].outerHTML).not.toContain('All good - B');
        });

        it('only shows alert B in container B', function() {
            expect(containers[2].querySelectorAll('.alert').length).toEqual(1);
            expect(containers[2].outerHTML).toContain('All good - B');
            expect(containers[2].outerHTML).not.toContain('All good - A');
        });
    });

    describe('close button', function () {
        it('is shown by default', function() {
            Flash.create('success', 'All good');
            $rootScope.$digest();
            var contents = node.contents()[0];
            expect(contents.querySelectorAll('.close')[0].classList.contains('ng-hide')).toEqual(false);
        });

        it('can be hidden with directive parameter', function() {
            node = $compile('<div><flash-message show-close="false"></flash-message></div>')($rootScope);
            Flash.create('success', 'All good');
            $rootScope.$digest();
            var contents = node.contents()[0];
            expect(contents.querySelectorAll('.close')[0].classList.contains('ng-hide')).toEqual(true);
        });

        it('can be hidden with create function parameter', function() {
            Flash.create('success', 'All good', 0, '', false);
            $rootScope.$digest();
            var contents = node.contents()[0];
            expect(contents.querySelectorAll('.close')[0].classList.contains('ng-hide')).toEqual(true);
        });

        it('can be overriden with create function parameter', function() {
            node = $compile('<div><flash-message show-close="false"></flash-message></div>')($rootScope);
            Flash.create('success', 'All good', 0, '', true);
            $rootScope.$digest();
            var contents = node.contents()[0];
            expect(contents.querySelectorAll('.close')[0].classList.contains('ng-hide')).toEqual(false);
        });
    });

    describe('dismiss callback', function() {
        it('is called when dismissed', function() {
            $rootScope.myCallback = function(flash) {

The parameter flash is not used and could be removed.

            };
            spyOn($rootScope, "myCallback");
            node = $compile('<div><flash-message on-dismiss="myCallback(flash)"></flash-message></div>')($rootScope);
            const id = Flash.create('success', 'All good');
            Flash.dismiss(id);
            $rootScope.$digest();
            expect($rootScope.myCallback).toHaveBeenCalled();
        });
    })
});