Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 8 | class DirectoryCreator extends Creator |
||
| 9 | { |
||
| 10 | /** |
||
| 11 | * Create all directories and files for console. |
||
| 12 | */ |
||
| 13 | public function create($createExample = true) |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Create the kernel file. |
||
| 29 | * |
||
| 30 | * @return bool |
||
| 31 | */ |
||
| 32 | View Code Duplication | protected function createKernel() |
|
| 49 | |||
| 50 | /** |
||
| 51 | * Get the kernel stub. |
||
| 52 | * |
||
| 53 | * @return string |
||
| 54 | */ |
||
| 55 | protected function getKernelStub() |
||
| 61 | |||
| 62 | /** |
||
| 63 | * Create an example command. |
||
| 64 | * |
||
| 65 | * @return bool |
||
| 66 | */ |
||
| 67 | View Code Duplication | protected function createExampleCommand() |
|
| 84 | |||
| 85 | protected function getExampleStub() |
||
| 91 | } |
||
| 92 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.