MakeBundleMod::getStub() - Code Metrics - Inspection of "Refactoring." - zachleigh/laravel-lang-bundler - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( af9673...c6f8ca )

by Zach

created 2017-01-29 22:00 UTC

MakeBundleMod::getStub() A

↳ Parent: MakeBundleMod

Complexity

Conditions	1
Paths	1

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	13
nc	1
nop	1
dl	0
loc	22
rs	9.2
c	0
b	0
f	0

<?php

namespace LaravelLangBundler\Commands;

use Illuminate\Container\Container;

class MakeBundleMod extends LaravelLangBundlerCommand
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'langb:mod {name}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create a custom modification file.';

    /**
     * Execute the console command.
     */
    public function handle()
    {
        $this->setUp();

        $pathArray = ['LangBundler', 'Mods'];

        $basePath = app_path().'/';

        $path = $this->buildPath($pathArray, $basePath);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $name = ucfirst($this->argument('name')).'Mod';

        $stub = $this->getStub($name);

        $this->filesystem->put(
            app_path(implode('/', $pathArray).'/'.$name.'.php'),
            $stub
        );

        $this->info('New bundle modification file successfully created!');
    }

    /**
     * Get stub and fill.
     *
     * @param string $name
     *
     * @return string
     */
    protected function getStub($name)
    {
        $namespace = Container::getInstance()->getNamespace();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $namespace = $namespace.'LangBundler\\Mods';

        $stub = $this->filesystem->get(__DIR__.'/../BundleItems/ModStub.php');

        $stub = str_replace(
            'LaravelLangBundler\BundleItems',
            $namespace,
            $stub
        );

        $stub = str_replace(
            'ModStub',
            $name,
            $stub
        );

        return $stub;
    }
}


1			<?php
2
3			namespace LaravelLangBundler\Commands;
4
5			use Illuminate\Container\Container;
6
7			class MakeBundleMod extends LaravelLangBundlerCommand
8			{
9			/**
10			* The name and signature of the console command.
11			*
12			* @var string
13			*/
14			protected $signature = 'langb:mod {name}';
15
16			/**
17			* The console command description.
18			*
19			* @var string
20			*/
21			protected $description = 'Create a custom modification file.';
22
23			/**
24			* Execute the console command.
25			*/
26			public function handle()
27			{
28			$this->setUp();
29
30			$pathArray = ['LangBundler', 'Mods'];
31
32			$basePath = app_path().'/';
33
34			$path = $this->buildPath($pathArray, $basePath);
			0 ignored issues – show Unused Code introduced 2017-01-29 22:02 UTC by Report Bug Copy Issue Report `$path` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35
36			$name = ucfirst($this->argument('name')).'Mod';
37
38			$stub = $this->getStub($name);
39
40			$this->filesystem->put(
41			app_path(implode('/', $pathArray).'/'.$name.'.php'),
42			$stub
43			);
44
45			$this->info('New bundle modification file successfully created!');
46			}
47
48			/**
49			* Get stub and fill.
50			*
51			* @param string $name
52			*
53			* @return string
54			*/
55			protected function getStub($name)
56			{
57			$namespace = Container::getInstance()->getNamespace();
			0 ignored issues – show Bug introduced 2017-01-29 10:35 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Illuminate\Container\Container` as the method `getNamespace()` does only exist in the following sub-classes of `Illuminate\Container\Container`: `Illuminate\Foundation\Application`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
58
59			$namespace = $namespace.'LangBundler\\Mods';
60
61			$stub = $this->filesystem->get(__DIR__.'/../BundleItems/ModStub.php');
62
63			$stub = str_replace(
64			'LaravelLangBundler\BundleItems',
65			$namespace,
66			$stub
67			);
68
69			$stub = str_replace(
70			'ModStub',
71			$name,
72			$stub
73			);
74
75			return $stub;
76			}
77			}
78

zachleigh / laravel-lang-bundler

Push — dev ( af9673...c6f8ca )

MakeBundleMod::getStub() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like