PageController - Code Metrics - Inspection of "Add images to pages." - zachleigh/larafolio - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( 6a93ce...82e8fe )

by Zach

created 2017-02-04 21:17 UTC

PageController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	135
Duplicated Lines	11.11 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
dl	15
loc	135
rs	10
c	0
b	0
f	0
wmc	8
lcom	0
cbo	3

7 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	show()	15	15	2
A	create()	0	4	1
A	store()	0	10	1
A	edit()	0	14	1
A	update()	0	16	1
A	destroy()	0	16	1

How to fix Duplicated Code

<?php

namespace Larafolio\Http\Controllers;

use Larafolio\Models\Page;
use Illuminate\Http\Request;

class PageController extends Controller
{
    /**
     * Return all projects.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function index()
    {
        return response()->json(Page::all());

    }

    /**
     * Show an individual page in the manager.
     *
     * @param string $slug Slug of the page to show.
     *
     * @return \Illuminate\Http\Response
     */
    public function show($slug)

    {
        $page = Page::withBlocks($slug)->first();


        if (!$page) {
            abort(404, "No page with slug {$slug} found.");
        }

        $images = $page->imagesWithProps();

        return view('larafolio::pages.show', [
            'page' => $page,
            'images'  => $images,
        ]);
    }

    /**
     * Return the project create page.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        // return view('larafolio::projects.add');

    }

    /**
     * Add a new project to the portfolio.
     *
     * @param AddProjectRequest $request Form request.
     *
     * @return \Illuminate\Http\Response
     */
    public function store(AddProjectRequest $request)

    {
        // $project = $this->user->addProject($request->all());


        // if ($request->ajax()) {

        //     return response()->json(['project' => $project]);

        // }

        // return redirect(route('show-project', ['project' => $project]));

    }

    /**
     * Return the project edit form view.
     *
     * @param string $slug Slug for the project to edit.
     *
     * @return \Illuminate\Http\Response
     */
    public function edit($slug)

    {
        // $project = Project::full($slug)->first();


        // $nextBlock = $project->blocks->pluck('order')->max() + 1;


        // $nextLink = $project->links->pluck('order')->max() + 1;


        // return view('larafolio::projects.edit', [

        //     'project'   => $project,

        //     'nextBlock' => $nextBlock,

        //     'nextLink'  => $nextLink,

        // ]);
    }

    /**
     * Update a project.
     *
     * @param \Illuminate\Http\Request $request Request data.
     * @param string                   $slug    Slug of project to update.
     *
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $slug)

    {
        // $project = Project::withTrashed()->where('slug', $slug)->first();


        // if ($project->trashed()) {

        //     $this->user->restoreProject($project);

        // } else {

        //     $this->user->updateProject($project, $request->all());

        // }

        // if ($request->ajax()) {

        //     return response()->json(['project' => $project]);

        // }

        // return redirect(route('show-project', ['project' => $project]));

    }

    /**
     * Remove a project from the portfolio.
     *
     * @param \Illuminate\Http\Request $request Request data.
     * @param string                   $slug    Slug of project to remove.
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, $slug)

    {
        // $project = Project::withTrashed()->where('slug', $slug)->first();


        // if ($project->trashed()) {

        //     $this->user->purgeProject($project);

        // } else {

        //     $this->user->removeProject($project);

        // }

        // if ($request->ajax()) {

        //     return response()->json(true);

        // }

        // return redirect(route('dashboard'));

    }
}


1		<?php
2
3		namespace Larafolio\Http\Controllers;
4
5		use Larafolio\Models\Page;
6		use Illuminate\Http\Request;
7
8		class PageController extends Controller
9		{
10		/**
11		* Return all projects.
12		*
13		* @return \Illuminate\Http\JsonResponse
14		*/
15		public function index()
16		{
17		return response()->json(Page::all());
		0 ignored issues – show Bug introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report It seems like `\Larafolio\Models\Page::all()` targeting `Illuminate\Database\Eloquent\Model::all()` can also be of type `object<Illuminate\Database\Eloquent\Collection>`; however, `Illuminate\Contracts\Rou...ResponseFactory::json()` does only seem to accept `string\|array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
18		}
19
20		/**
21		* Show an individual page in the manager.
22		*
23		* @param string $slug Slug of the page to show.
24		*
25		* @return \Illuminate\Http\Response
26		*/
27	View Code Duplication	public function show($slug)
		0 ignored issues – show Duplication introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$page = Page::withBlocks($slug)->first();
		1 ignored issue – show Bug introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report The method `withBlocks()` does not exist on `Larafolio\Models\Page`. Did you maybe mean `scopeWithBlocks()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
30
31		if (!$page) {
32		abort(404, "No page with slug {$slug} found.");
33		}
34
35		$images = $page->imagesWithProps();
36
37		return view('larafolio::pages.show', [
38		'page' => $page,
39		'images' => $images,
40		]);
41		}
42
43		/**
44		* Return the project create page.
45		*
46		* @return \Illuminate\Http\Response
47		*/
48		public function create()
49		{
50		// return view('larafolio::projects.add');
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
51		}
52
53		/**
54		* Add a new project to the portfolio.
55		*
56		* @param AddProjectRequest $request Form request.
57		*
58		* @return \Illuminate\Http\Response
59		*/
60		public function store(AddProjectRequest $request)
		0 ignored issues – show Unused Code introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
61		{
62		// $project = $this->user->addProject($request->all());
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
63
64		// if ($request->ajax()) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
65		// return response()->json(['project' => $project]);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
66		// }
67
68		// return redirect(route('show-project', ['project' => $project]));
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
69		}
70
71		/**
72		* Return the project edit form view.
73		*
74		* @param string $slug Slug for the project to edit.
75		*
76		* @return \Illuminate\Http\Response
77		*/
78		public function edit($slug)
		0 ignored issues – show Unused Code introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report The parameter `$slug` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
79		{
80		// $project = Project::full($slug)->first();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `57%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
81
82		// $nextBlock = $project->blocks->pluck('order')->max() + 1;
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
83
84		// $nextLink = $project->links->pluck('order')->max() + 1;
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
85
86		// return view('larafolio::projects.edit', [
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
87		// 'project' => $project,
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
88		// 'nextBlock' => $nextBlock,
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
89		// 'nextLink' => $nextLink,
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
90		// ]);
91		}
92
93		/**
94		* Update a project.
95		*
96		* @param \Illuminate\Http\Request $request Request data.
97		* @param string $slug Slug of project to update.
98		*
99		* @return \Illuminate\Http\Response
100		*/
101		public function update(Request $request, $slug)
		0 ignored issues – show Unused Code introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report The parameter `$slug` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
102		{
103		// $project = Project::withTrashed()->where('slug', $slug)->first();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `61%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
104
105		// if ($project->trashed()) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
106		// $this->user->restoreProject($project);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
107		// } else {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
108		// $this->user->updateProject($project, $request->all());
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `71%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
109		// }
110
111		// if ($request->ajax()) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
112		// return response()->json(['project' => $project]);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
113		// }
114
115		// return redirect(route('show-project', ['project' => $project]));
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
116		}
117
118		/**
119		* Remove a project from the portfolio.
120		*
121		* @param \Illuminate\Http\Request $request Request data.
122		* @param string $slug Slug of project to remove.
123		*
124		* @return \Illuminate\Http\Response
125		*/
126		public function destroy(Request $request, $slug)
		0 ignored issues – show Unused Code introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report The parameter `$slug` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
127		{
128		// $project = Project::withTrashed()->where('slug', $slug)->first();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `61%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
129
130		// if ($project->trashed()) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
131		// $this->user->purgeProject($project);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
132		// } else {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
133		// $this->user->removeProject($project);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
134		// }
135
136		// if ($request->ajax()) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
137		// return response()->json(true);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
138		// }
139
140		// return redirect(route('dashboard'));
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-04 21:20 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
141		}
142		}
143

zachleigh / larafolio

Push — dev ( 6a93ce...82e8fe )

PageController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like