HasBlocks - Code Metrics - Inspection of "Minify resources." - zachleigh/larafolio - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3b9644...b65440 )

by Zach

created 2017-01-30 22:06 UTC

HasBlocks A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	6
c	1
b	0
f	0
lcom	1
cbo	0
dl	65
loc	65
rs	10

5 Methods

Rating	Name	Duplication	Size	Complexity
	getFromRelationshipByName()	1	1	?
A	blocks()	4	4	1
A	hasBlocks()	4	4	1
A	block()	4	4	1
A	blockText()	12	12	3

How to fix Duplicated Code

<?php

namespace Larafolio\Models\Traits;

use Larafolio\Models\TextBlock;

trait HasBlocks

{
    /**
     * Get a model from a relationship by model name.
     *
     * @param string $relationship Name of relationship.
     * @param string $name         Name of model to get.
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    abstract protected function getFromRelationshipByName($relationship, $name);

    /**
     * A project has many text blocks.
     *
     * @return \Illuminate\Database\Eloquent\Relations\HasMany
     */
    public function blocks()
    {
        return $this->hasMany(TextBlock::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Return true if project has blocks.
     *
     * @return bool
     */
    public function hasBlocks()
    {
        return !$this->blocks->isEmpty();
    }

    /**
     * Get a text block by name, if exists.
     *
     * @param string $name Name of text block to get.
     *
     * @return Larafolio\Models\TextBlock|null
     */
    public function block($name)
    {
        return $this->getFromRelationshipByName('blocks', $name);
    }

    /**
     * Get block text by block name, if block exists.
     *
     * @param string $name      Name of text block to get.
     * @param bool   $formatted If true, return formmated text.
     *
     * @return string|null
     */
    public function blockText($name, $formatted = true)
    {
        if (!$block = $this->block($name)) {
            return;
        }

        if ($formatted) {
            return $block->formattedText();
        }

        return $block->text();
    }
}


1		<?php
2
3		namespace Larafolio\Models\Traits;
4
5		use Larafolio\Models\TextBlock;
6
7	View Code Duplication	trait HasBlocks
		1 ignored issue – show Duplication introduced 2017-01-30 05:49 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		/**
10		* Get a model from a relationship by model name.
11		*
12		* @param string $relationship Name of relationship.
13		* @param string $name Name of model to get.
14		*
15		* @return \Illuminate\Database\Eloquent\Model\|null
16		*/
17		abstract protected function getFromRelationshipByName($relationship, $name);
18
19		/**
20		* A project has many text blocks.
21		*
22		* @return \Illuminate\Database\Eloquent\Relations\HasMany
23		*/
24		public function blocks()
25		{
26		return $this->hasMany(TextBlock::class);
		0 ignored issues – show Bug introduced 2017-01-30 05:49 UTC by Report Bug Copy Issue Report It seems like `hasMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27		}
28
29		/**
30		* Return true if project has blocks.
31		*
32		* @return bool
33		*/
34		public function hasBlocks()
35		{
36		return !$this->blocks->isEmpty();
37		}
38
39		/**
40		* Get a text block by name, if exists.
41		*
42		* @param string $name Name of text block to get.
43		*
44		* @return Larafolio\Models\TextBlock\|null
45		*/
46		public function block($name)
47		{
48		return $this->getFromRelationshipByName('blocks', $name);
49		}
50
51		/**
52		* Get block text by block name, if block exists.
53		*
54		* @param string $name Name of text block to get.
55		* @param bool $formatted If true, return formmated text.
56		*
57		* @return string\|null
58		*/
59		public function blockText($name, $formatted = true)
60		{
61		if (!$block = $this->block($name)) {
62		return;
63		}
64
65		if ($formatted) {
66		return $block->formattedText();
67		}
68
69		return $block->text();
70		}
71		}
72

zachleigh / larafolio

Push — master ( 3b9644...b65440 )

HasBlocks A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like