Larafolio\Http\Controllers\ProjectController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	135
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	show()	0	15	2
A	create()	0	4	1
A	store()	0	10	2
A	edit()	0	14	1
A	update()	0	16	3
A	destroy()	0	16	3

<?php

namespace Larafolio\Http\Controllers;

use Illuminate\Http\Request;
use Larafolio\Models\Project;
use Larafolio\Http\Requests\AddProjectRequest;

class ProjectController extends Controller
{
    /**
     * Return all projects.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function index()
    {
        return response()->json(Project::all());

It seems like \Larafolio\Models\Project::all() targeting Illuminate\Database\Eloquent\Model::all() can also be of type object<Illuminate\Database\Eloquent\Collection>; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }

    /**
     * Show an individual project in the manager.
     *
     * @param string $slug Slug of the project to show.
     *
     * @return \Illuminate\Http\Response
     */
    public function show($slug)
    {
        $project = Project::withBlocks($slug)->first();

        if (!$project) {
            abort(404, "No project with slug {$slug} found.");
        }

        $images = $project->imagesWithProps();

        return view('larafolio::projects.show', [
            'project' => $project,
            'images'  => $images,
        ]);
    }

    /**
     * Return the project create page.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('larafolio::projects.add');
    }

    /**
     * Add a new project to the portfolio.
     *
     * @param AddProjectRequest $request Form request.
     *
     * @return \Illuminate\Http\Response
     */
    public function store(AddProjectRequest $request)
    {
        $project = $this->user->addProject($request->all());

        if ($request->ajax()) {
            return response()->json(['project' => $project]);
        }

        return redirect(route('show-project', ['project' => $project]));
    }

    /**
     * Return the project edit form view.
     *
     * @param string $slug Slug for the project to edit.
     *
     * @return \Illuminate\Http\Response
     */
    public function edit($slug)
    {
        $project = Project::full($slug)->first();

        $nextBlock = $project->blocks->pluck('order')->max() + 1;

        $nextLink = $project->links->pluck('order')->max() + 1;

        return view('larafolio::projects.edit', [
            'project'   => $project,
            'nextBlock' => $nextBlock,
            'nextLink'  => $nextLink,
        ]);
    }

    /**
     * Update a project.
     *
     * @param \Illuminate\Http\Request $request Request data.
     * @param string                   $slug    Slug of project to update.
     *
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $slug)
    {
        $project = Project::withTrashed()->where('slug', $slug)->first();

The method withTrashed() does not exist on Larafolio\Models\Project. Did you maybe mean trashed()?

        if ($project->trashed()) {
            $this->user->restoreProject($project);
        } else {
            $this->user->updateProject($project, $request->all());
        }

        if ($request->ajax()) {
            return response()->json(['project' => $project]);
        }

        return redirect(route('show-project', ['project' => $project]));
    }

    /**
     * Remove a project from the portfolio.
     *
     * @param \Illuminate\Http\Request $request Request data.
     * @param string                   $slug    Slug of project to remove.
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, $slug)
    {
        $project = Project::withTrashed()->where('slug', $slug)->first();

The method withTrashed() does not exist on Larafolio\Models\Project. Did you maybe mean trashed()?

        if ($project->trashed()) {
            $this->user->purgeProject($project);
        } else {
            $this->user->removeProject($project);
        }

        if ($request->ajax()) {
            return response()->json(true);

true is of type boolean, but the function expects a string|array.

        }

        return redirect(route('dashboard'));
    }
}