Larafolio\Http\Controllers\LinkController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	destroy()	0	6	1
A	check()	0	8	1

<?php

namespace Larafolio\Http\Controllers;

use Larafolio\Models\Link;
use Illuminate\Http\Request;
use Larafolio\Http\HttpValidator\HttpValidator;

class LinkController extends Controller
{
    /**
     * Remove a link.
     *
     * @param Link $link Link to remove.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy(Link $link)
    {
        $deleted = $this->user->removeLink($link);

        return response()->json($deleted);
    }

    /**
     * Check the status of a link and return json http code.
     *
     * @param Request       $request       Http request with 'url'.
     * @param HttpValidator $httpValidator Instance of http validator class.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function check(Request $request, HttpValidator $httpValidator)
    {
        $url = $request->input('url');

        $httpCode = $httpValidator->validate($url);

It seems like $url defined by $request->input('url') on line 35 can also be of type array; however, Larafolio\Http\HttpValidator\HttpValidator::validate() does only seem to accept string, maybe add an additional type check?

        return response()->json(['httpCode' => $httpCode]);
    }
}