ImageController - Code Metrics - zachleigh/larafolio - Measure and Improve Code Quality continuously with Scrutinizer

ImageController A
last analyzed 2017-01-30 22:14 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
dl	0
loc	41
rs	10
c	0
b	0
f	0
wmc	4
lcom	1
cbo	3

2 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	12	2
A	destroy()	0	10	2

<?php

namespace Larafolio\Http\Controllers;

use Larafolio\Models\Image;
use Illuminate\Http\Request;

class ImageController extends Controller
{
    /**
     * Update image name and caption.
     *
     * @param \Illuminate\Http\Request $request Request object.
     * @param Image                    $image   Image to be updated.
     *
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, Image $image)
    {
        $imageData = $request->only(['name', 'caption', 'alt']);

        $this->user->updateImageInfo($image, $imageData);

        if ($request->ajax()) {
            return response()->json(true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return back();
    }

    /**
     * Remove image from portfolio.
     *
     * @param Image $image Image to be removed.
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, Image $image)
    {
        $this->user->removeImage($image);

        if ($request->ajax()) {
            return response()->json(true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return back();
    }
}


1			<?php
2
3			namespace Larafolio\Http\Controllers;
4
5			use Larafolio\Models\Image;
6			use Illuminate\Http\Request;
7
8			class ImageController extends Controller
9			{
10			/**
11			* Update image name and caption.
12			*
13			* @param \Illuminate\Http\Request $request Request object.
14			* @param Image $image Image to be updated.
15			*
16			* @return \Illuminate\Http\Response
17			*/
18			public function update(Request $request, Image $image)
19			{
20			$imageData = $request->only(['name', 'caption', 'alt']);
21
22			$this->user->updateImageInfo($image, $imageData);
23
24			if ($request->ajax()) {
25			return response()->json(true);
			0 ignored issues – show Documentation introduced 2017-01-30 03:54 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `string\|array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			}
27
28			return back();
29			}
30
31			/**
32			* Remove image from portfolio.
33			*
34			* @param Image $image Image to be removed.
35			*
36			* @return \Illuminate\Http\Response
37			*/
38			public function destroy(Request $request, Image $image)
39			{
40			$this->user->removeImage($image);
41
42			if ($request->ajax()) {
43			return response()->json(true);
			0 ignored issues – show Documentation introduced 2017-01-30 03:54 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `string\|array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44			}
45
46			return back();
47			}
48			}
49

zachleigh / larafolio

ImageController A last analyzed 2017-01-30 22:14 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

ImageController A
last analyzed 2017-01-30 22:14 UTC