RedisQ::listen() - Code Metrics - Inspection of "added a simple stats display" - zKillboard/RedisQ - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8fee49...c9e6b0 )

by Clinton

created 2016-06-08 20:01 UTC

RedisQ::listen() A

↳ Parent: RedisQ

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	10
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	18
rs	9.4285

<?php

namespace RedisQ;

class RedisQ
{
    public function queueObject($object)
    {
        global $redis;
function myFunction($a, $b) {
    // Do something
}

        $wrapped = serialize($object);

        $allQueues = new RedisTtlSortedSet('redisQ:allQueues');
	$objectQueues = new RedisTtlSortedSet('objectQueues');
        $queues = $allQueues->getMembers();

        $multi = $redis->multi();

        // Store an instance of the object
        $objectID = 'redisQ:objectID:'.uniqID().md5($wrapped);
	$objectQueues->add(time(), $objectID);
        $multi->setex($objectID, 9600, $wrapped);

        // Add objectID to all queues
        foreach ($queues as $queueID) {
            $multi->lPush($queueID, $objectID);
            $multi->expire($queueID, 9600);
        }
        $multi->exec();
    }

    public function registerListener($queueID)
    {
        $allQueues = new RedisTtlSortedSet('redisQ:allQueues');
        $allQueues->add(time(), $queueID);
    }

    public function listen($queueID)
    {
        global $redis;
function myFunction($a, $b) {
    // Do something
}

        $rQueueID = "redisQ:queueID:$queueID";

        self::registerListener($rQueueID);

        $pop = $redis->blPop($rQueueID, 10);
        if (!isset($pop[1])) {
            return;
        }

        $objectID = $pop[1];
        $object = $redis->get($objectID);

        return unserialize($object);
    }
}


1			<?php
2
3			namespace RedisQ;
4
5			class RedisQ
6			{
7			public function queueObject($object)
8			{
9			global $redis;
			0 ignored issues – show Compatibility Best Practice introduced 2015-11-24 20:30 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
10
11			$wrapped = serialize($object);
12
13			$allQueues = new RedisTtlSortedSet('redisQ:allQueues');
14			$objectQueues = new RedisTtlSortedSet('objectQueues');
15			$queues = $allQueues->getMembers();
16
17			$multi = $redis->multi();
18
19			// Store an instance of the object
20			$objectID = 'redisQ:objectID:'.uniqID().md5($wrapped);
21			$objectQueues->add(time(), $objectID);
22			$multi->setex($objectID, 9600, $wrapped);
23
24			// Add objectID to all queues
25			foreach ($queues as $queueID) {
26			$multi->lPush($queueID, $objectID);
27			$multi->expire($queueID, 9600);
28			}
29			$multi->exec();
30			}
31
32			public function registerListener($queueID)
33			{
34			$allQueues = new RedisTtlSortedSet('redisQ:allQueues');
35			$allQueues->add(time(), $queueID);
36			}
37
38			public function listen($queueID)
39			{
40			global $redis;
			0 ignored issues – show Compatibility Best Practice introduced 2015-11-24 20:30 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
41
42			$rQueueID = "redisQ:queueID:$queueID";
43
44			self::registerListener($rQueueID);
45
46			$pop = $redis->blPop($rQueueID, 10);
47			if (!isset($pop[1])) {
48			return;
49			}
50
51			$objectID = $pop[1];
52			$object = $redis->get($objectID);
53
54			return unserialize($object);
55			}
56			}
57

zKillboard / RedisQ

GitHub Access Token became invalid

Push — master ( 8fee49...c9e6b0 )

RedisQ::listen() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like