PostalAccount::__construct() - Code Metrics - Inspection of "Fix Scrutinizer configuration (II)" - z38/swiss-payment - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — scrutinizer ( 42ac6a...7bc18e )

by z38

created 2015-12-31 14:59 UTC

PostalAccount::__construct() A

↳ Parent: PostalAccount

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
c	2
b	0
f	2
dl	0
loc	15
ccs	10
cts	10
cp	1
rs	9.4286
cc	3
eloc	9
nc	3
nop	1
crap	3

<?php

namespace Z38\SwissPayment;

/**
 * PostalAccount holds details about a PostFinance account
 */
class PostalAccount
{
    const PATTERN = '/^[0-9]{2}-[1-9][0-9]{0,5}-[0-9]$/';

    /**
     * @var int
     */
    protected $prefix;

    /**
     * @var int
     */
    protected $number;

    /**
     * @var int
     */
    protected $checkDigit;

    /**
     * Constructor
     *
     * @param string $postalAccount
     *
     * @throws \InvalidArgumentException When the account number is not valid (check digit is not being tested).
     */
    public function __construct($postalAccount)
    {
        if (!preg_match(self::PATTERN, $postalAccount)) {
            throw new \InvalidArgumentException('Postal account number is not properly formatted.');
        }

        $parts = explode('-', $postalAccount);
        if (!self::checkPrefix($parts[0])) {
            throw new \InvalidArgumentException('Postal account number has an invalid prefix.');
        }

        $this->prefix = (int) $parts[0];
        $this->number = (int) $parts[1];
        $this->checkDigit = (int) $parts[2];
    }

    /**
     * Format the postal account number
     *
     * @return string The formatted account number
     */
    public function format()
    {
        return sprintf('%d-%d-%d', $this->prefix, $this->number, $this->checkDigit);
    }

    /**
     * Checks whether a given prefix is valid
     *
     * @param int $prefix The prefix to be checked
     *
     * @return bool True if the prefix is valid
     */
    private static function checkPrefix($prefix)
    {
        return in_array($prefix, array(
            10, 12, 17, 18, 19,
            20, 23, 25, 30, 34,
            40, 45, 46, 49, 50,
            60, 65, 69, 70, 80,
            82, 84, 85, 87, 90,
            91, 92,
        ));
    }
}


1		<?php
2
3		namespace Z38\SwissPayment;
4
5		/**
6		* PostalAccount holds details about a PostFinance account
7		*/
8		class PostalAccount
9		{
10		const PATTERN = '/^[0-9]{2}-[1-9][0-9]{0,5}-[0-9]$/';
11
12		/**
13		* @var int
14		*/
15		protected $prefix;
16
17		/**
18		* @var int
19		*/
20		protected $number;
21
22		/**
23		* @var int
24		*/
25		protected $checkDigit;
26
27		/**
28		* Constructor
29		*
30		* @param string $postalAccount
31		*
32		* @throws \InvalidArgumentException When the account number is not valid (check digit is not being tested).
33		*/
34	8	public function __construct($postalAccount)
35		{
36	8	if (!preg_match(self::PATTERN, $postalAccount)) {
37	1	throw new \InvalidArgumentException('Postal account number is not properly formatted.');
38		}
39
40	7	$parts = explode('-', $postalAccount);
41	7	if (!self::checkPrefix($parts[0])) {
42	1	throw new \InvalidArgumentException('Postal account number has an invalid prefix.');
43		}
44
45	6	$this->prefix = (int) $parts[0];
46	6	$this->number = (int) $parts[1];
47	6	$this->checkDigit = (int) $parts[2];
48	6	}
49
50		/**
51		* Format the postal account number
52		*
53		* @return string The formatted account number
54		*/
55	6	public function format()
56		{
57	6	return sprintf('%d-%d-%d', $this->prefix, $this->number, $this->checkDigit);
58		}
59
60		/**
61		* Checks whether a given prefix is valid
62		*
63		* @param int $prefix The prefix to be checked
64		*
65		* @return bool True if the prefix is valid
66		*/
67	2	private static function checkPrefix($prefix)
68		{
69	2	return in_array($prefix, array(
70	2	10, 12, 17, 18, 19,
71	2	20, 23, 25, 30, 34,
72	2	40, 45, 46, 49, 50,
73	2	60, 65, 69, 70, 80,
74	2	82, 84, 85, 87, 90,
75	2	91, 92,
76	2	));
77		}
78		}
79

z38 / swiss-payment

Push — scrutinizer ( 42ac6a...7bc18e )

PostalAccount::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like