GeneralAccount::__construct() - Code Metrics - Inspection of "Add support for intermediary agents" - z38/swiss-payment - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dc2855...0a5beb )

by z38

created 2016-05-12 08:56 UTC

GeneralAccount::__construct() A

↳ Parent: GeneralAccount

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	9
ccs	6
cts	6
cp	1
rs	9.6666
cc	2
eloc	5
nc	2
nop	1
crap	2

<?php

namespace Z38\SwissPayment;

use DOMDocument;
use InvalidArgumentException;

/**
 * GeneralAccount holds details about an account which is not covered by any of the other classes
 */
class GeneralAccount implements AccountInterface
{
    const MAX_LENGTH = 34;

    /**
     * @var string
     */
    protected $id;

    /**
     * Constructor
     *
     * @param string $id
     *
     * @throws InvalidArgumentException When the account identification exceeds the maximum length.
     */
    public function __construct($id)
    {
        $stringId = (string) $id;
        if (strlen($stringId) > self::MAX_LENGTH) {
            throw new InvalidArgumentException('The account identifcation is too long.');
        }

        $this->id = $stringId;
    }

    /**
     * {@inheritdoc}
     */
    public function format()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function asDom(DOMDocument $doc)
    {
        $root = $doc->createElement('Id');
        $other = $doc->createElement('Othr');
        $other->appendChild($doc->createElement('Id', $this->format()));
        $root->appendChild($other);

        return $root;
    }
}


1		<?php
2
3		namespace Z38\SwissPayment;
4
5		use DOMDocument;
6		use InvalidArgumentException;
7
8		/**
9		* GeneralAccount holds details about an account which is not covered by any of the other classes
10		*/
11		class GeneralAccount implements AccountInterface
12		{
13		const MAX_LENGTH = 34;
14
15		/**
16		* @var string
17		*/
18		protected $id;
19
20		/**
21		* Constructor
22		*
23		* @param string $id
24		*
25		* @throws InvalidArgumentException When the account identification exceeds the maximum length.
26		*/
27	4	public function __construct($id)
28		{
29	4	$stringId = (string) $id;
30	4	if (strlen($stringId) > self::MAX_LENGTH) {
31	1	throw new InvalidArgumentException('The account identifcation is too long.');
32		}
33
34	3	$this->id = $stringId;
35	3	}
36
37		/**
38		* {@inheritdoc}
39		*/
40	3	public function format()
41		{
42	3	return $this->id;
43		}
44
45		/**
46		* {@inheritdoc}
47		*/
48	2	public function asDom(DOMDocument $doc)
49		{
50	2	$root = $doc->createElement('Id');
51	2	$other = $doc->createElement('Othr');
52	2	$other->appendChild($doc->createElement('Id', $this->format()));
53	2	$root->appendChild($other);
54
55	2	return $root;
56		}
57		}
58

z38 / swiss-payment

Push — master ( dc2855...0a5beb )

GeneralAccount::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like