UserAndLevel::modifyPermissions() - Code Metrics - Inspection of "trying to fix code quality fixes cause by magic me..." - z1haze/laravel-acl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dcb410...e7354d )

by Stephen

created 2017-02-06 22:02 UTC

UserAndLevel::modifyPermissions() B

↳ Parent: UserAndLevel

Complexity

Conditions	6
Paths	16

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	22
ccs	0
cts	17
cp	0
rs	8.6737
cc	6
eloc	12
nc	16
nop	2
crap	42

<?php

namespace z1haze\Acl\Traits;

use Illuminate\Support\Collection;
use z1haze\Acl\Exceptions\PermissionNotFoundException;
use z1haze\Acl\Models\Level;
use z1haze\Acl\Models\Permission;

/**
 * Class UserAndLevel
 * @package z1haze\Acl\Traits
 */
trait UserAndLevel
{
    /**
     * USER & LEVEL
     * Check if a model has a given level
     *
     * @param $level
     * @return bool
     */
    public function isLevel($level)
    {
        $level = $this->getLevel($level);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return is_a($this, config('laravel-acl.level'), true) ? $this->name == $level->name : $this->level->name == $level->name;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * USER & LEVEL
     * Check if a user has or has inherited
     * a given level
     *
     * @param $level
     * @return bool
     */
    public function hasLevel($level)
    {
        $level = $this->getLevel($level);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return is_a($this, config('laravel-acl.level'), true) ? $this->rank <= $level->rank : $this->level->rank <= $level->rank;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * USER & LEVEL
     * Add a single permission to a model
     *
     * @param $permission
     */
    public function addPermission($permission)
    {
        $this->modifyPermissions([$permission], 'add');
    }

    /**
     * USER & LEVEL
     * Add an array of permissions to a model
     *
     * @param $permissions
     */
    public function addPermissions(array $permissions)
    {
        $this->modifyPermissions($permissions, 'add');
    }

    /**
     * USER & LEVEL
     * Remove a permission from a model
     *
     * @param $permission
     */
    public function removePermission($permission)
    {
        $this->modifyPermissions([$permission], 'remove');
    }

    /**
     * USER & LEVEL
     * Remove an array of permissions objects or permission names (can be mixed)
     *
     * @param $permissions
     */
    public function removePermissions(array $permissions)
    {
        $this->modifyPermissions($permissions, 'remove');
    }

    /**
     * USER & LEVEL
     * Sync permissions on a model
     *
     * @param $permissions
     */
    public function syncPermissions(array $permissions)
    {
        $this->modifyPermissions($permissions, 'sync');
    }

    /**
     * USER & LEVEL
     * Clear permissions from a model
     *
     * @return mixed
     */
    public function clearPermissions()
    {
        if (is_a($this, config('laravel-acl.user'), true))
            $this->permissions()->detach();


        if (is_a($this, config('laravel-acl.level'), true))
            config('laravel-acl.permission', Permission::class)::whereLevelId($this->id)->update(['level_id' => null]);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }


    /* ------------------------------------------------------------------------------------------------
     |  Other Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * USER & LEVEL
     * First try the cache to return the collection,
     * then fetch it from the database.
     *
     * See @cacheGetAllPermissions()
     *
     * @return mixed
     */
    public function getAllPermissions()

    {
        $model = is_a($this, config('laravel-acl.level'), true) ? 'Level' : 'User';

        return \Cache::remember(
            'laravel-acl.getAllPermissionsFor' . $model . '_' . $this->id,
            config('laravel-acl.cacheMinutes'),
            function () {
                return $this->cacheGetAllPermissions();
            }
        );
    }

    /**
     * USER & LEVEL
     * First try the cache to return the collection,
     * then fetch it from the database.
     *
     * See @cacheGetInheritedPermissions()
     *
     * @return mixed
     */
    public function getInheritedPermissions()

    {
        $model = is_a($this, config('laravel-acl.level'), true) ? 'Level' : 'User';

        return \Cache::remember(
            'laravel-acl.getInheritedPermissionsFor' . $model . '_' . $this->id,
            config('laravel-acl.cacheMinutes'),
            function () {
                return $this->cacheGetInheritedPermissions();
            }
        );
    }

    /**
     * USER & LEVEL
     * First try the cache to return the collection,
     * then fetch it from the database.
     *
     * See @cacheGetAvailablePermissions()
     *
     * @return mixed
     */
    public function getAvailablePermissions()

    {
        $model = is_a($this, config('laravel-acl.level'), true) ? 'Level' : 'User';

        return \Cache::remember(
            'laravel-acl.getAvailablePermissionsFor' . $model . '_' . $this->id,
            config('laravel-acl.cacheMinutes'),
            function () {
                return $this->cacheGetAvailablePermissions();
            }
        );
    }

    /**
     * USER & LEVEL
     * First try the cache to return the collection,
     * then fetch it from the database.
     *
     * See @cacheHasPermissionTo()
     *
     * @param $permission
     * @return mixed
     */
    public function hasPermissionTo($permission)
    {
        $model = is_a($this, config('laravel-acl.level'), true) ? 'Level' : 'User';

        return \Cache::remember(
            'laravel-acl.hasPermissionTo_' . $model . '_' . $this->id . '_Permission_' . $permission,
            config('laravel-acl.cacheMinutes'),
            function () use ($permission) {
                return $this->cacheHasPermissionTo($permission);
            }
        );
    }

    /**
     * USER & LEVEL
     * Returns if a level is lower ranking than another level,
     * or if a user is lower ranking than another user.
     *
     * @param $other
     * @return bool
     */
    public function isLowerThan($other)
    {
        return is_a($this, config('laravel-acl.user'), true) ? $this->level->rank > $other->level->rank : $this->rank > $other->rank;
    }

    /**
     * USER & LEVEL
     * Returns if a level is higher ranking than another level,
     * or if a user is higher ranking than another user.
     *
     * @param $other
     * @return bool
     */
    public function isHigherThan($other)
    {
        return is_a($this, config('laravel-acl.user'), true) ? $this->level->rank < $other->level->rank : $this->rank < $other->rank;
    }

    /**
     * USER & LEVEL
     * Returns if a equal is lower ranking than another level,
     * or if a user is equal ranking than another user.
     *
     * @param $other
     * @return bool
     */
    public function isEqualTo($other)
    {
        return is_a($this, config('laravel-acl.user'), true) ? $this->level->rank == $other->level->rank : $this->rank == $other->rank;
    }


    /* ------------------------------------------------------------------------------------------------
     |  Other Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * USER & LEVEL
     * Return a collection of all permissions
     * associated to a user by direct or
     * inheritance
     *
     * @return mixed
     */
    protected function cacheGetAllPermissions()
    {
        $rank = is_a($this, config('laravel-acl.level'), true) ? $this->rank : $this->level->rank;

        $levels = config('laravel-acl.level', Level::class)::where('rank', '>=', $rank)->with('permissions')->get();

        $allPerms = new Collection();

        $levels->each(function ($level, $key) use (&$allPerms) {

            $allPerms = $allPerms->merge($level->permissions);
        });

        return $allPerms->merge($this->permissions)->unique('id');
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * USER & LEVEL
     * Return a collection of permissions that
     * are inherited from a higher level
     * @return mixed
     */
    protected function cacheGetInheritedPermissions()
    {
        $rank = is_a($this, config('laravel-acl.level'), true) ? $this->rank : $this->level->rank;

        $levels = is_a($this, config('laravel-acl.user'), true) ? config('laravel-acl.level', Level::class)::where('rank', '>=', $rank)->with('permissions')->get() : config('laravel-acl.level', Level::class)::where('rank', '>', $rank)->with('permissions')->get();

        $inheritedPerms = new Collection();

        $levels->each(function ($level, $key) use (&$inheritedPerms) {

            $inheritedPerms = $inheritedPerms->merge($level->permissions->load('level'));
        });

        return $inheritedPerms->unique('id');
    }

    /**
     * USER & LEVEL
     * Return a collection of permissions still able to be assigned
     * ie, not already inherited or explicitly assigned
     * @return \Illuminate\Database\Eloquent\Collection
     */
    protected function cacheGetAvailablePermissions()
    {
        $allPerms = config('laravel-acl.permission', Permission::class)::with('level')->get();

        return $allPerms->diff($this->permissions);
    }

    /**
     * USER & LEVEL
     * Check if a model has permission to do something
     *
     * @param $permission
     * @return bool
     */
    protected function cacheHasPermissionTo($permission)
    {
        $permission = $this->getPermission($permission);

        if (is_a($this, config('laravel-acl.user'), true)) {
            $negatedPermissions = $this->permissions()->wherePivot('negated', true)->get();


            if ($this->getAllPermissions()->contains('id', $permission->id)) {
                return !$negatedPermissions->contains('id', $permission->id);
            }
        }
        
        return $this->getAllPermissions()->contains('id', $permission->id) ||
        $this->getAllPermissions()->contains('name', '*');
    }

    /**
     * USER & LEVEL
     * Modify a given set of permissions, given the action to be taken
     *
     * @param $permissions
     * @param $action
     * @return mixed
     */
    protected function modifyPermissions($permissions, $action)
    {
        $model = is_a($this, config('laravel-acl.level'), true) ? 'Level' : 'User';

        \Cache::forget('laravel-acl.getAvailablePermissionsFor' . $model . '_' . $this->id);
        \Cache::forget('laravel-acl.getAllPermissionsFor' . $model . '_' . $this->id);
        \Cache::forget('laravel-acl.getNegatedPermissionsForUser_' . $this->id);

        $permissionObjects = $this->buildPermissionsArray($permissions, $action, $model);

        if ($action == 'add' || $action == 'negate') {
            $this->addOrNegate($model, $permissionObjects, $action);
        }

        if ($action == 'remove') {
            $this->remove($model, $permissionObjects);
        }

        if ($action == 'sync') {
            $this->sync($model, $permissionObjects);
        }
    }

    /**
     * USER & LEVEL
     * Helper function to build the array
     * for modifyPermissions
     *
     * @param $permissions
     * @param $action
     * @param $model
     * @return mixed
     * @throws PermissionNotFoundException
     */
    protected function buildPermissionsArray($permissions, $action, $model)
    {
        $permissionsObjects = [];

        foreach ($permissions as $permission) {
            $permission = $this->getPermission($permission);
            \Cache::forget('laravel-acl.hasPermissionTo_' . $model . '_' . $this->id . '_Permission_' . $permission->id);

            if ($action == 'negate') {
                $permissionsObjects[$permission->id] = ['negated' => true];
            } else {
                $model == 'User' ?
                    array_push($permissionsObjects, $permission->id) :
                    array_push($permissionsObjects, $permission);
            }
        }

        return $permissionsObjects;
    }

    /**
     * USER & LEVEL
     * Helper function to handle adding or negating permissions
     *
     * @param $model
     * @param $permissionObjects
     */
    protected function addOrNegate($model, $permissionObjects, $action)

    {
        if ($model == 'User')
            $this->permissions()->attach($permissionObjects);


        if ($model == 'Level')
            $this->permissions()->saveMany($permissionObjects);

    }

    /**
     * USER & LEVEL
     * Helper function to handle removing permissions
     *
     * @param $model
     * @param $permissionObjects
     */
    protected function remove($model, $permissionObjects)

    {
        if ($model == 'User')
            $this->permissions()->detach($permissionObjects);


        if ($model == 'Level') {
            config('laravel-acl.permission', Permission::class)::whereIn('id', array_map(function ($permission) {
                return $permission->id;
            }, $permissionObjects))->update(['level_id' => null]);
        }
    }

    /**
     * USER & LEVEL
     * Help function to handle syncing permissions
     *
     * @param $model
     * @param $permissionObjects
     */
    protected function sync($model, $permissionObjects)

    {
        if ($model == 'User')
            $this->permissions()->sync($permissionObjects);


        if ($model == 'Level') {
            $this->clearPermissions();

            config('laravel-acl.permission', Permission::class)::whereIn('id', array_map(function ($permission) {
                return $permission->id;
            }, $permissionObjects))
                ->update(['level_id' => $this->id]);
        }
    }

    /**
     * USER & LEVEL
     * Helper function to get the permission whether it is the permission ID
     * or the permission name, or the permission object itself.
     *
     * @param $permission
     * @return mixed
     * @throws PermissionNotFoundException
     */
    protected function getPermission($permission)

    {
        if (is_string($permission))
            $permission = config('laravel-acl.permission', Permission::class)::whereName($permission)->first();

        if (is_int($permission))
            $permission = config('laravel-acl.permission', Permission::class)::find($permission);

        if (!$permission)
            throw new PermissionNotFoundException;

        return $permission;
    }
}

1			<?php
2
3			namespace z1haze\Acl\Traits;
4
5			use Illuminate\Support\Collection;
6			use z1haze\Acl\Exceptions\PermissionNotFoundException;
7			use z1haze\Acl\Models\Level;
8			use z1haze\Acl\Models\Permission;
9
10			/**
11			* Class UserAndLevel
12			* @package z1haze\Acl\Traits
13			*/
14			trait UserAndLevel
15			{
16			/**
17			* USER & LEVEL
18			* Check if a model has a given level
19			*
20			* @param $level
21			* @return bool
22			*/
23			public function isLevel($level)
24			{
25			$level = $this->getLevel($level);
			0 ignored issues – show Bug introduced 2017-02-06 17:55 UTC by Report Bug Copy Issue Report It seems like `getLevel()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26
27			return is_a($this, config('laravel-acl.level'), true) ? $this->name == $level->name : $this->level->name == $level->name;
			0 ignored issues – show Bug introduced 2017-02-06 22:10 UTC by Report Bug Copy Issue Report The property `name` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-02-06 22:10 UTC by Report Bug Copy Issue Report The property `level` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28			}
29
30			/**
31			* USER & LEVEL
32			* Check if a user has or has inherited
33			* a given level
34			*
35			* @param $level
36			* @return bool
37			*/
38			public function hasLevel($level)

z1haze / laravel-acl

Push — master ( dcb410...e7354d )

UserAndLevel::modifyPermissions() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like