UserAndPermission - Code Metrics - Inspection of "trying to fix code quality fixes cause by magic me..." - z1haze/laravel-acl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dcb410...e7354d )

by Stephen

created 2017-02-06 22:02 UTC

UserAndPermission A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	66
Duplicated Lines	19.7 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	7
c	0
b	0
f	0
lcom	1
cbo	1
dl	13
loc	66
ccs	0
cts	23
cp	0
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	level()	0	4	1
A	assignLevel()	0	6	1
A	clearLevel()	0	4	1
A	getLevel()	13	13	4

How to fix Duplicated Code

<?php

namespace z1haze\Acl\Traits;

use z1haze\Acl\Exceptions\LevelNotFoundException;
use z1haze\Acl\Models\Level;

trait UserAndPermission
{
    /**
     * USER & PERMISSION
     * A model belongs to a Level
     *
     * @return mixed
     */
    public function level()
    {
        return $this->belongsTo(config('laravel-acl.level', Level::class));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * USER & PERMISSION
     * Assign a model to a level
     *
     * @param $level
     * @return mixed
     */
    public function assignLevel($level)
    {
        $level = $this->getLevel($level);

        return $this->level()->associate($level)->save();
    }

    /**
     * USER & PERMISSION
     * Clear a model's level
     *
     * @return mixed
     */
    public function clearLevel()
    {
        return $this->level()->dissociate()->save();
    }


    /* ------------------------------------------------------------------------------------------------
     |  Other Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * USER & PERMISSION
     * Helper function to get the level whether it is the ID
     * or the name of the level, or the level object itself.
     *
     * @param $level
     * @return mixed
     * @throws LevelNotFoundException
     */
    protected function getLevel($level)

    {
        if (is_string($level))
            $level = config('laravel-acl.level', Level::class)::whereName($level)->first();

        if (is_int($level))
            $level = config('laravel-acl.level', Level::class)::find($level);

        if (!$level)
            throw new LevelNotFoundException();

        return $level;
    }
}

1		<?php
2
3		namespace z1haze\Acl\Traits;
4
5		use z1haze\Acl\Exceptions\LevelNotFoundException;
6		use z1haze\Acl\Models\Level;
7
8		trait UserAndPermission
9		{
10		/**
11		* USER & PERMISSION
12		* A model belongs to a Level
13		*
14		* @return mixed
15		*/
16		public function level()
17		{
18		return $this->belongsTo(config('laravel-acl.level', Level::class));
		0 ignored issues – show Bug introduced 2017-02-06 17:55 UTC by Report Bug Copy Issue Report It seems like `belongsTo()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19		}
20
21		/**
22		* USER & PERMISSION
23		* Assign a model to a level
24		*
25		* @param $level
26		* @return mixed
27		*/
28		public function assignLevel($level)
29		{
30		$level = $this->getLevel($level);
31
32		return $this->level()->associate($level)->save();
33		}
34
35		/**
36		* USER & PERMISSION
37		* Clear a model's level
38		*
39		* @return mixed
40		*/
41		public function clearLevel()
42		{
43		return $this->level()->dissociate()->save();
44		}
45
46
47		/* ------------------------------------------------------------------------------------------------
48		\| Other Functions
49		\| ------------------------------------------------------------------------------------------------
50		*/
51		/**
52		* USER & PERMISSION
53		* Helper function to get the level whether it is the ID
54		* or the name of the level, or the level object itself.
55		*
56		* @param $level
57		* @return mixed
58		* @throws LevelNotFoundException
59		*/
60	View Code Duplication	protected function getLevel($level)
		0 ignored issues – show Duplication introduced 2017-02-06 17:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		{
62		if (is_string($level))
63		$level = config('laravel-acl.level', Level::class)::whereName($level)->first();
64
65		if (is_int($level))
66		$level = config('laravel-acl.level', Level::class)::find($level);
67
68		if (!$level)
69		throw new LevelNotFoundException();
70
71		return $level;
72		}
73		}

z1haze / laravel-acl

Push — master ( dcb410...e7354d )

UserAndPermission A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like