Completed
Pull Request — master (#2901)
by
unknown
02:15
created

HasMany   F

Complexity

Total Complexity 64

Size/Duplication

Total Lines 650
Duplicated Lines 31.54 %

Coupling/Cohesion

Components 1
Dependencies 7

Importance

Changes 0
Metric Value
dl 205
loc 650
rs 3.23
c 0
b 0
f 0
wmc 64
lcom 1
cbo 7

16 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 15 15 3
F getValidator() 57 180 29
B formatValidationAttribute() 26 26 8
A resetInputKey() 26 54 4
A prepare() 0 6 1
A buildNestedForm() 0 14 1
A getKeyName() 0 8 2
A mode() 0 6 1
A useTab() 0 4 1
B buildRelatedForms() 0 43 8
A setupScript() 0 6 1
A setupScriptForDefaultView() 34 34 1
A setupScriptForTabView() 47 47 1
A disableCreate() 0 6 1
A disableDelete() 0 6 1
A render() 0 17 1

How to fix   Duplicated Code    Complexity   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

Complex Class

 Tip:   Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like HasMany often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use HasMany, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
namespace Encore\Admin\Form\Field;
4
5
use Encore\Admin\Admin;
6
use Encore\Admin\Form;
7
use Encore\Admin\Form\Field;
8
use Encore\Admin\Form\NestedForm;
9
use Illuminate\Database\Eloquent\Relations\HasMany as Relation;
10
use Illuminate\Database\Eloquent\Relations\MorphMany;
11
use Illuminate\Support\Facades\Validator;
12
use Illuminate\Support\Str;
13
14
/**
15
 * Class HasMany.
16
 */
17
class HasMany extends Field
18
{
19
    /**
20
     * Relation name.
21
     *
22
     * @var string
23
     */
24
    protected $relationName = '';
25
26
    /**
27
     * Form builder.
28
     *
29
     * @var \Closure
30
     */
31
    protected $builder = null;
32
33
    /**
34
     * Form data.
35
     *
36
     * @var array
37
     */
38
    protected $value = [];
39
40
    /**
41
     * View Mode.
42
     *
43
     * Supports `default` and `tab` currently.
44
     *
45
     * @var string
46
     */
47
    protected $viewMode = 'default';
48
49
    /**
50
     * Available views for HasMany field.
51
     *
52
     * @var array
53
     */
54
    protected $views = [
55
        'default' => 'admin::form.hasmany',
56
        'tab' => 'admin::form.hasmanytab',
57
    ];
58
59
    /**
60
     * Options for template.
61
     *
62
     * @var array
63
     */
64
    protected $options = [
65
        'allowCreate' => true,
66
        'allowDelete' => true,
67
    ];
68
69
    /**
70
     * Create a new HasMany field instance.
71
     *
72
     * @param $relationName
73
     * @param array $arguments
74
     */
75 View Code Duplication
    public function __construct($relationName, $arguments = [])
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
76
    {
77
        $this->relationName = $relationName;
78
79
        $this->column = $relationName;
80
81
        if (count($arguments) == 1) {
82
            $this->label = $this->formatLabel();
83
            $this->builder = $arguments[0];
84
        }
85
86
        if (count($arguments) == 2) {
87
            list($this->label, $this->builder) = $arguments;
88
        }
89
    }
90
91
    /**
92
     * Get validator for this field.
93
     *
94
     * @param array $input
95
     *
96
     * @return bool|Validator
97
     */
98
    public function getValidator(array $input)
99
    {
100
        if (!array_key_exists($this->column, $input)) {
101
            return false;
102
        }
103
104 View Code Duplication
        $array_key_attach_str = function (array $a, string $b, string $c = '.') {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
105
            return call_user_func_array(
106
                'array_merge',
107
                array_map(function ($u, $v) use ($b, $c) {
108
                    return ["{$b}{$c}{$u}" => $v];
109
                }, array_keys($a), array_values($a))
110
            );
111
        };
112
113 View Code Duplication
        $array_key_clean = function (array $a) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
114
            $a = count($a) ? call_user_func_array('array_merge', array_map(function ($k, $v) {
115
                return [str_replace(':', '', $k) => $v];
116
            }, array_keys($a), array_values($a))) : $a;
117
118
            return $a;
119
        };
120
121 View Code Duplication
        $array_key_clean_undot = function (array $a) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
122
            if (count($a)) {
123
                foreach ($a as $key => $val) {
124
                    array_set($a, str_replace(':', '', $key), $val);
125
                    if (preg_match('/[\.\:]/', $key)) {
126
                        unset($a[$key]);
127
                    }
128
                }
129
            }
130
131
            return $a;
132
        };
133
134
        $input = array_only($input, $this->column);
135
        $form = $this->buildNestedForm($this->column, $this->builder);
0 ignored issues
show
Bug introduced by
It seems like $this->column can also be of type array; however, Encore\Admin\Form\Field\HasMany::buildNestedForm() does only seem to accept string, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
136
        $rel = $this->relationName;
137
        $rules = $attributes = [];
138
        $messages = [];
139
        // remove all inputs & keys marked as removed
140
        $availInput = array_filter(array_map(function ($v) {
141
            return $v[NestedForm::REMOVE_FLAG_NAME] ? null : $v;
142
        }, $input[$rel]));
143
        $keys = array_keys($availInput);
144
        /* @var Field $field */
145
        foreach ($form->fields() as $field) {
146
            if (!$fieldRules = $field->getRules()) {
147
                continue;
148
            }
149
            $column = $field->column();
150
            $columns = is_array($column) ? $column : [$column];
151
            if ($field instanceof Field\MultipleSelect) {
152
                foreach ($keys as $key) {
153
                    $availInput[$key][$column] = array_filter($availInput[$key][$column], 'strlen');
154
                    $availInput[$key][$column] = $availInput[$key][$column] ? : null;
155
                }
156
            }
157
            // if($field instanceof Field\File)
158
            // {
159
            //     dd(request());
160
            // }
161
            $newColumn = call_user_func_array('array_merge', array_map(function ($u) use ($columns, $rel) {
162
                return array_map(function ($k, $v) use ($u, $rel) {
163
                            //Fix ResetInput Function! A Headache Implementation!
164
                    return !$k ? "{$rel}.{$u}.{$v}" : "{$rel}.{$u}.{$v}:{$k}";
165
                }, array_keys($columns), array_values($columns));
166
            }, $keys));
167
168
            $fieldRules = is_array($fieldRules) ? implode('|', $fieldRules) : $fieldRules;
169
            $rules = array_merge($rules, call_user_func_array(
170
                'array_merge',
171
                array_map(function ($v) use ($fieldRules) {
172
                    return [$v => $fieldRules];
173
                }, $newColumn)
174
            ));
175
            $attributes = array_merge($attributes, call_user_func_array(
176
                'array_merge',
177 View Code Duplication
                array_map(function ($v) use ($field) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
178
                    //Fix ResetInput Function! A Headache Implementation!
179
                    $u = $field->label();
180
                    $u .= is_array($field->column()) ? '[' . explode(':', explode('.', $v)[1])[0] . ']' : '';
181
182
                    return [$v => "{$u}"];
183
                }, $newColumn)
184
            ));
185 View Code Duplication
            if ($field->validationMessages) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
186
                $newMessages = array_map(function ($v) use ($field, $availInput, $array_key_attach_str) {
187
                    list($r, $k, $c) = explode('.', $v);
0 ignored issues
show
Unused Code introduced by
The assignment to $r is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
188
                    //Fix ResetInput Function! A Headache Implementation!
189
                    $col1 = explode(':', $c)[0];
190
                    if (!array_key_exists($col1, $availInput[$k])) {
191
                        return [null => null];
192
                    }
193
                    $rows = $availInput[$k][$col1];
194
                    if (!is_array($rows)) {
195
                        return $array_key_attach_str($field->validationMessages, $v);
196
                    }
197
                    $r = [];
198
                    foreach (array_keys($rows) as $k) {
199
                        $k = "{$v}{$k}";
200
                        $r = array_merge($r, $array_key_attach_str($field->validationMessages, $k));
201
                    }
202
                    return $r;
203
                }, $newColumn);
204
                $newMessages = call_user_func_array('array_merge', $newMessages);
205
                $messages = array_merge($messages, $newMessages);
206
            }
207
        }
208
209
        if (empty($rules)) {
210
            return false;
211
        }
212
213
        $newInput = call_user_func_array('array_merge', array_map(function ($u) use ($availInput) {
214
            list($rel, $key, $col) = explode('.', $u);
215
            $idx = "{$rel}.{$key}.{$col}";
216
            //Fix ResetInput Function! A Headache Implementation!
217
            $col1 = explode(':', $col)[0];
218
            if (!array_key_exists($col1, $availInput[$key])) {
219
                return [null => null];
220
            }
221
            if (is_array($availInput[$key][$col1])) {
222
                return call_user_func_array('array_merge', array_map(function ($x, $y) use ($idx) {
223
                    return ["{$idx}{$x}" => $y];
224
                }, array_keys($availInput[$key][$col1]), $availInput[$key][$col1]));
225
            }
226
            return ["{$idx}" => $availInput[$key][$col1]];
227
        }, array_keys($rules)));
228
        $newInput = $array_key_clean_undot($newInput);
229
230
        $newRules = array_map(function ($u) use ($availInput, $rules) {
231
            list($rel, $key, $col) = explode('.', $u);
232
            $idx = "{$rel}.{$key}.{$col}";
233
            //Fix ResetInput Function! A Headache Implementation!
234
            $col1 = explode(':', $col)[0];
235
            if (!array_key_exists($col1, $availInput[$key])) {
236
                return [null => null];
237
            }
238
            if (is_array($availInput[$key][$col1])) {
239
                return call_user_func_array('array_merge', array_map(function ($x) use ($idx, $rules) {
240
                    return ["{$idx}{$x}" => $rules[$idx]];
241
                }, array_keys($availInput[$key][$col1])));
242
            }
243
244
            return ["{$idx}" => $rules[$idx]];
245
        }, array_keys($rules));
246
        $newRules = array_filter(call_user_func_array('array_merge', $newRules), 'strlen', ARRAY_FILTER_USE_KEY);
247
        $newRules = $array_key_clean($newRules);
248
249
        $newAttributes = array_map(function ($u) use ($availInput, $attributes) {
250
            list($rel, $key, $col) = explode('.', $u);
251
            $idx = "{$rel}.{$key}.{$col}";
252
            //Fix ResetInput Function! A Headache Implementation!
253
            $col1 = explode(':', $col)[0];
254
            if (!array_key_exists($col1, $availInput[$key])) {
255
                return [null => null];
256
            }
257 View Code Duplication
            if (is_array($availInput[$key][$col1])) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
258
                if (array_keys($availInput[$key][$col1])) {
259
                    return call_user_func_array('array_merge', array_map(function ($x) use ($idx, $attributes) {
260
                        return ["{$idx}.{$x}" => $attributes[$idx]];
261
                    }, array_keys($availInput[$key][$col1])));
262
                }
263
                return [null => null];
264
            }
265
266
            return ["{$idx}" => $attributes[$idx]];
267
        }, array_keys($attributes));
268
        $newAttributes = array_filter(call_user_func_array('array_merge', $newAttributes), 'strlen');
269
        $newAttributes = $array_key_clean($newAttributes);
270
271
        $messages = $array_key_clean($messages);
272
273
        if (empty($newInput)) {
274
            $newInput = [$rel => $availInput];
275
        }
276
        return Validator::make($newInput, $newRules, $messages, $newAttributes);
0 ignored issues
show
Bug Best Practice introduced by
The return type of return \Illuminate\Suppo...sages, $newAttributes); (Illuminate\Contracts\Validation\Validator) is incompatible with the return type of the parent method Encore\Admin\Form\Field::getValidator of type boolean|Illuminate\Support\Facades\Validator.

If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.

Let’s take a look at an example:

class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

Our function my_function expects a Post object, and outputs the author of the post. The base class Post returns a simple string and outputting a simple string will work just fine. However, the child class BlogPost which is a sub-type of Post instead decided to return an object, and is therefore violating the SOLID principles. If a BlogPost were passed to my_function, PHP would not complain, but ultimately fail when executing the strtoupper call in its body.

Loading history...
277
    }
278
279
    /**
280
     * Format validation attributes.
281
     *
282
     * @param array  $input
283
     * @param string $label
284
     * @param string $column
285
     *
286
     * @return array
287
     */
288 View Code Duplication
    protected function formatValidationAttribute($input, $label, $column)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
289
    {
290
        $new = $attributes = [];
291
292
        if (is_array($column)) {
293
            foreach ($column as $index => $col) {
294
                $new[$col . $index] = $col;
295
            }
296
        }
297
298
        foreach (array_keys(array_dot($input)) as $key) {
299
            if (is_string($column)) {
300
                if (Str::endsWith($key, ".$column")) {
301
                    $attributes[$key] = $label;
302
                }
303
            } else {
304
                foreach ($new as $k => $val) {
305
                    if (Str::endsWith($key, ".$k")) {
306
                        $attributes[$key] = $label . "[$val]";
307
                    }
308
                }
309
            }
310
        }
311
312
        return $attributes;
313
    }
314
315
    /**
316
     * Reset input key for validation.
317
     *
318
     * @param array $input
319
     * @param array $column $column is the column name array set
320
     *
321
     * @return void.
0 ignored issues
show
Documentation introduced by
The doc-type void. could not be parsed: Unknown type name "void." at position 0. (view supported doc-types)

This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types.

Loading history...
322
     */
323
    protected function resetInputKey(array &$input, array $column)
324
    {
325
        /**
326
         * flip the column name array set.
327
         *
328
         * for example, for the DateRange, the column like as below
329
         *
330
         * ["start" => "created_at", "end" => "updated_at"]
331
         *
332
         * to:
333
         *
334
         * [ "created_at" => "start", "updated_at" => "end" ]
335
         */
336
        $column = array_flip($column);
337
338
        /**
339
         * $this->column is the inputs array's node name, default is the relation name.
340
         *
341
         * So... $input[$this->column] is the data of this column's inputs data
342
         *
343
         * in the HasMany relation, has many data/field set, $set is field set in the below
344
         */
345
        foreach ($input[$this->column] as $index => $set) {
346
            /*
347
             * foreach the field set to find the corresponding $column
348
             */
349 View Code Duplication
            foreach ($set as $name => $value) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
350
                /*
351
                 * if doesn't have column name, continue to the next loop
352
                 */
353
                if (!array_key_exists($name, $column)) {
354
                    continue;
355
                }
356
357
                /**
358
                 * example:  $newKey = created_atstart.
359
                 *
360
                 * Σ( ° △ °|||)︴
361
                 *
362
                 * I don't know why a form need range input? Only can imagine is for range search....
363
                 */
364
                $newKey = $name . $column[$name];
365
366
                /*
367
                 * set new key
368
                 */
369
                array_set($input, "{$this->column}.$index.$newKey", $value);
370
                /*
371
                 * forget the old key and value
372
                 */
373
                array_forget($input, "{$this->column}.$index.$name");
374
            }
375
        }
376
    }
377
378
    /**
379
     * Prepare input data for insert or update.
380
     *
381
     * @param array $input
382
     *
383
     * @return array
384
     */
385
    public function prepare($input)
386
    {
387
        $form = $this->buildNestedForm($this->column, $this->builder);
0 ignored issues
show
Bug introduced by
It seems like $this->column can also be of type array; however, Encore\Admin\Form\Field\HasMany::buildNestedForm() does only seem to accept string, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
388
389
        return $form->setOriginal($this->original, $this->getKeyName())->prepare($input);
390
    }
391
392
    /**
393
     * Build a Nested form.
394
     *
395
     * @param string   $column
396
     * @param \Closure $builder
397
     * @param null     $key
398
     *
399
     * @return NestedForm
400
     */
401
    protected function buildNestedForm($column, \Closure $builder, $key = null)
402
    {
403
        $form = new Form\NestedForm($column, $key);
404
405
        $form->setForm($this->form);
406
407
        call_user_func($builder, $form);
408
409
        $form->hidden($this->getKeyName());
410
411
        $form->hidden(NestedForm::REMOVE_FLAG_NAME)->default(0)->addElementClass(NestedForm::REMOVE_FLAG_CLASS);
412
413
        return $form;
414
    }
415
416
    /**
417
     * Get the HasMany relation key name.
418
     *
419
     * @return string
420
     */
421
    protected function getKeyName()
422
    {
423
        if (is_null($this->form)) {
424
            return;
425
        }
426
427
        return $this->form->model()->{$this->relationName}()->getRelated()->getKeyName();
428
    }
429
430
    /**
431
     * Set view mode.
432
     *
433
     * @param string $mode currently support `tab` mode.
434
     *
435
     * @return $this
436
     *
437
     * @author Edwin Hui
438
     */
439
    public function mode($mode)
440
    {
441
        $this->viewMode = $mode;
442
443
        return $this;
444
    }
445
446
    /**
447
     * Use tab mode to showing hasmany field.
448
     *
449
     * @return HasMany
450
     */
451
    public function useTab()
452
    {
453
        return $this->mode('tab');
454
    }
455
456
    /**
457
     * Build Nested form for related data.
458
     *
459
     * @throws \Exception
460
     *
461
     * @return array
462
     */
463
    protected function buildRelatedForms()
464
    {
465
        if (is_null($this->form)) {
466
            return [];
467
        }
468
469
        $model = $this->form->model();
470
471
        $relation = call_user_func([$model, $this->relationName]);
472
473
        if (!$relation instanceof Relation && !$relation instanceof MorphMany) {
474
            throw new \Exception('hasMany field must be a HasMany or MorphMany relation.');
475
        }
476
477
        $forms = [];
478
479
        /*
480
         * If redirect from `exception` or `validation error` page.
481
         *
482
         * Then get form data from session flash.
483
         *
484
         * Else get data from database.
485
         */
486
        if ($values = old($this->column)) {
0 ignored issues
show
Bug introduced by
It seems like $this->column can also be of type array; however, old() does only seem to accept string|null, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
487
            foreach ($values as $key => $data) {
488
                if ($data[NestedForm::REMOVE_FLAG_NAME] == 1) {
489
                    continue;
490
                }
491
492
                $forms[$key] = $this->buildNestedForm($this->column, $this->builder, $key)
0 ignored issues
show
Bug introduced by
It seems like $this->column can also be of type array; however, Encore\Admin\Form\Field\HasMany::buildNestedForm() does only seem to accept string, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
493
                    ->fill($data);
494
            }
495
        } else {
496
            foreach ($this->value as $data) {
497
                $key = array_get($data, $relation->getRelated()->getKeyName());
498
499
                $forms[$key] = $this->buildNestedForm($this->column, $this->builder, $key)
0 ignored issues
show
Bug introduced by
It seems like $this->column can also be of type array; however, Encore\Admin\Form\Field\HasMany::buildNestedForm() does only seem to accept string, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
500
                    ->fill($data);
501
            }
502
        }
503
504
        return $forms;
505
    }
506
507
    /**
508
     * Setup script for this field in different view mode.
509
     *
510
     * @param string $script
511
     *
512
     * @return void
513
     */
514
    protected function setupScript($script)
515
    {
516
        $method = 'setupScriptFor' . ucfirst($this->viewMode) . 'View';
517
518
        call_user_func([$this, $method], $script);
519
    }
520
521
    /**
522
     * Setup default template script.
523
     *
524
     * @param string $templateScript
525
     *
526
     * @return void
527
     */
528 View Code Duplication
    protected function setupScriptForDefaultView($templateScript)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
529
    {
530
        $removeClass = NestedForm::REMOVE_FLAG_CLASS;
531
        $defaultKey = NestedForm::DEFAULT_KEY_NAME;
532
533
        /**
534
         * When add a new sub form, replace all element key in new sub form.
535
         *
536
         * @example comments[new___key__][title]  => comments[new_{index}][title]
537
         *
538
         * {count} is increment number of current sub form count.
539
         */
540
        $script = <<<EOT
541
var index = 0;
542
$('#has-many-{$this->column}').on('click', '.add', function () {
543
544
    var tpl = $('template.{$this->column}-tpl');
545
546
    index++;
547
548
    var template = tpl.html().replace(/{$defaultKey}/g, index);
549
    $('.has-many-{$this->column}-forms').append(template);
550
    {$templateScript}
551
});
552
553
$('#has-many-{$this->column}').on('click', '.remove', function () {
554
    $(this).closest('.has-many-{$this->column}-form').hide();
555
    $(this).closest('.has-many-{$this->column}-form').find('.$removeClass').val(1);
556
});
557
558
EOT;
559
560
        Admin::script($script);
561
    }
562
563
    /**
564
     * Setup tab template script.
565
     *
566
     * @param string $templateScript
567
     *
568
     * @return void
569
     */
570 View Code Duplication
    protected function setupScriptForTabView($templateScript)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
571
    {
572
        $removeClass = NestedForm::REMOVE_FLAG_CLASS;
573
        $defaultKey = NestedForm::DEFAULT_KEY_NAME;
574
575
        $script = <<<EOT
576
577
$('#has-many-{$this->column} > .nav').off('click', 'i.close-tab').on('click', 'i.close-tab', function(){
578
    var \$navTab = $(this).siblings('a');
579
    var \$pane = $(\$navTab.attr('href'));
580
    if( \$pane.hasClass('new') ){
581
        \$pane.remove();
582
    }else{
583
        \$pane.removeClass('active').find('.$removeClass').val(1);
584
    }
585
    if(\$navTab.closest('li').hasClass('active')){
586
        \$navTab.closest('li').remove();
587
        $('#has-many-{$this->column} > .nav > li:nth-child(1) > a').tab('show');
588
    }else{
589
        \$navTab.closest('li').remove();
590
    }
591
});
592
593
var index = 0;
594
$('#has-many-{$this->column} > .header').off('click', '.add').on('click', '.add', function(){
595
    index++;
596
    var navTabHtml = $('#has-many-{$this->column} > template.nav-tab-tpl').html().replace(/{$defaultKey}/g, index);
597
    var paneHtml = $('#has-many-{$this->column} > template.pane-tpl').html().replace(/{$defaultKey}/g, index);
598
    $('#has-many-{$this->column} > .nav').append(navTabHtml);
599
    $('#has-many-{$this->column} > .tab-content').append(paneHtml);
600
    $('#has-many-{$this->column} > .nav > li:last-child a').tab('show');
601
    {$templateScript}
602
});
603
604
if ($('.has-error').length) {
605
    $('.has-error').parent('.tab-pane').each(function () {
606
        var tabId = '#'+$(this).attr('id');
607
        $('li a[href="'+tabId+'"] i').removeClass('hide');
608
    });
609
    
610
    var first = $('.has-error:first').parent().attr('id');
611
    $('li a[href="#'+first+'"]').tab('show');
612
}
613
EOT;
614
615
        Admin::script($script);
616
    }
617
618
    /**
619
     * Disable create button.
620
     *
621
     * @return $this
622
     */
623
    public function disableCreate()
624
    {
625
        $this->options['allowCreate'] = false;
626
627
        return $this;
628
    }
629
630
    /**
631
     * Disable delete button.
632
     *
633
     * @return $this
634
     */
635
    public function disableDelete()
636
    {
637
        $this->options['allowDelete'] = false;
638
639
        return $this;
640
    }
641
642
    /**
643
     * Render the `HasMany` field.
644
     *
645
     * @throws \Exception
646
     *
647
     * @return \Illuminate\View\View
648
     */
649
    public function render()
650
    {
651
        // specify a view to render.
652
        $this->view = $this->views[$this->viewMode];
653
654
        list($template, $script) = $this->buildNestedForm($this->column, $this->builder)
0 ignored issues
show
Bug introduced by
It seems like $this->column can also be of type array; however, Encore\Admin\Form\Field\HasMany::buildNestedForm() does only seem to accept string, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
655
            ->getTemplateHtmlAndScript();
656
657
        $this->setupScript($script);
658
659
        return parent::render()->with([
0 ignored issues
show
Bug introduced by
The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
660
            'forms' => $this->buildRelatedForms(),
661
            'template' => $template,
662
            'relationName' => $this->relationName,
663
            'options' => $this->options,
664
        ]);
665
    }
666
}
667