View GitHub Repository laravel-admin

Schedule Inspection
Subscribe
Completed
Pull Request — master (#73)
by Song
05:19 queued 02:21
created
Status
Category
Toggle Patches
migrations/2016_01_04_173148_create_admin_tables.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -12,7 +12,7 @@  discard block
 
 block discarded – undo
12 12 
      */
13 13 
     public function up()
14 14 
     {
15 
-        Schema::create(config('admin.database.users_table'), function (Blueprint $table) {
15 
+        Schema::create(config('admin.database.users_table'), function(Blueprint $table) {
16 16 
             $table->increments('id');
17 17 
             $table->string('username', 190)->unique();
18 18 
             $table->string('password', 60);
 
@@ -21,21 +21,21 @@  discard block
 
 block discarded – undo
21 21 
             $table->timestamps();
22 22 
         });
23 23
24 
-        Schema::create(config('admin.database.roles_table'), function (Blueprint $table) {
24 
+        Schema::create(config('admin.database.roles_table'), function(Blueprint $table) {
25 25 
             $table->increments('id');
26 26 
             $table->string('name', 50)->unique();
27 27 
             $table->string('slug', 50);
28 28 
             $table->timestamps();
29 29 
         });
30 30
31 
-        Schema::create(config('admin.database.permissions_table'), function (Blueprint $table) {
31 
+        Schema::create(config('admin.database.permissions_table'), function(Blueprint $table) {
32 32 
             $table->increments('id');
33 33 
             $table->string('name', 50)->unique();
34 34 
             $table->string('slug', 50);
35 35 
             $table->timestamps();
36 36 
         });
37 37
38 
-        Schema::create(config('admin.database.menu_table'), function (Blueprint $table) {
38 
+        Schema::create(config('admin.database.menu_table'), function(Blueprint $table) {
39 39 
             $table->increments('id');
40 40 
             $table->integer('parent_id')->default(0);
41 41 
             $table->integer('order');
 
@@ -46,21 +46,21 @@  discard block
 
 block discarded – undo
46 46 
             $table->timestamps();
47 47 
         });
48 48
49 
-        Schema::create(config('admin.database.role_users_table'), function (Blueprint $table) {
49 
+        Schema::create(config('admin.database.role_users_table'), function(Blueprint $table) {
50 50 
             $table->integer('role_id');
51 51 
             $table->integer('user_id');
52 52 
             $table->index(['role_id', 'user_id']);
53 53 
             $table->timestamps();
54 54 
         });
55 55
56 
-        Schema::create(config('admin.database.role_permissions_table'), function (Blueprint $table) {
56 
+        Schema::create(config('admin.database.role_permissions_table'), function(Blueprint $table) {
57 57 
             $table->integer('role_id');
58 58 
             $table->integer('permission_id');
59 59 
             $table->index(['role_id', 'permission_id']);
60 60 
             $table->timestamps();
61 61 
         });
62 62
63 
-        Schema::create(config('admin.database.role_menu_table'), function (Blueprint $table) {
63 
+        Schema::create(config('admin.database.role_menu_table'), function(Blueprint $table) {
64 64 
             $table->integer('role_id');
65 65 
             $table->integer('menu_id');
66 66 
             $table->index(['role_id', 'menu_id']);
Please login to merge, or discard this patch.
src/Auth/Database/Menu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -84,7 +84,7 @@
 
 block discarded – undo
84 84 
     {
85 85 
         static::$branchOrder = array_flip(array_flatten($order));
86 86
87 
-        static::$branchOrder = array_map(function ($item) {
87 
+        static::$branchOrder = array_map(function($item) {
88 88 
             return ++$item;
89 89 
         }, static::$branchOrder);
90 90 
     }
Please login to merge, or discard this patch.
src/Controllers/MenuController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -20,7 +20,7 @@  discard block
 
 block discarded – undo
20 20 
      */
21 21 
     public function index()
22 22 
     {
23 
-        return Admin::content(function (Content $content) {
23 
+        return Admin::content(function(Content $content) {
24 24 
             $content->header(trans('admin::lang.menu'));
25 25 
             $content->description(trans('admin::lang.list'));
26 26 
 
@@ -37,7 +37,7 @@  discard block
 
 block discarded – undo
37 37 
      */
38 38 
     public function edit($id)
39 39 
     {
40 
-        return Admin::content(function (Content $content) use ($id) {
40 
+        return Admin::content(function(Content $content) use ($id) {
41 41 
             $content->header(trans('admin::lang.menu'));
42 42 
             $content->description(trans('admin::lang.edit'));
43 43 
 
@@ -53,7 +53,7 @@  discard block
 
 block discarded – undo
53 53 
      */
54 54 
     public function create()
55 55 
     {
56 
-        return Admin::content(function (Content $content) {
56 
+        return Admin::content(function(Content $content) {
57 57 
             $content->header(trans('admin::lang.menu'));
58 58 
             $content->description(trans('admin::lang.create'));
59 59 
 
@@ -109,7 +109,7 @@  discard block
 
 block discarded – undo
109 109 
      */
110 110 
     public function form()
111 111 
     {
112 
-        return Admin::form(Menu::class, function (Form $form) {
112 
+        return Admin::form(Menu::class, function(Form $form) {
113 113 
             $form->display('id', 'ID');
114 114
115 115 
             $options = [0 => 'Root'] + Menu::buildSelectOptions();
Please login to merge, or discard this patch.
src/Form/Field/File.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -76,7 +76,7 @@
 
 block discarded – undo
76 76 
     /**
77 77 
      * @param $file
78 78 
      *
79 
-     * @return mixed
79 
+     * @return string
80 80 
      */
81 81 
     protected function uploadAndDeleteOriginal(UploadedFile $file)
82 82 
     {
Please login to merge, or discard this patch.
src/Controllers/UserController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch 
@@ -21,7 +21,7 @@  discard block
 
 block discarded – undo
21 21 
      */
22 22 
     public function index()
23 23 
     {
24 
-        return Admin::content(function (Content $content) {
24 
+        return Admin::content(function(Content $content) {
25 25 
             $content->header(trans('admin::lang.administrator'));
26 26 
             $content->description(trans('admin::lang.list'));
27 27 
             $content->body($this->grid()->render());
 
@@ -37,7 +37,7 @@  discard block
 
 block discarded – undo
37 37 
      */
38 38 
     public function edit($id)
39 39 
     {
40 
-        return Admin::content(function (Content $content) use ($id) {
40 
+        return Admin::content(function(Content $content) use ($id) {
41 41 
             $content->header(trans('admin::lang.administrator'));
42 42 
             $content->description(trans('admin::lang.edit'));
43 43 
             $content->body($this->form()->edit($id));
 
@@ -51,7 +51,7 @@  discard block
 
 block discarded – undo
51 51 
      */
52 52 
     public function create()
53 53 
     {
54 
-        return Admin::content(function (Content $content) {
54 
+        return Admin::content(function(Content $content) {
55 55 
             $content->header(trans('admin::lang.administrator'));
56 56 
             $content->description(trans('admin::lang.create'));
57 57 
             $content->body($this->form());
 
@@ -65,13 +65,13 @@  discard block
 
 block discarded – undo
65 65 
      */
66 66 
     protected function grid()
67 67 
     {
68 
-        return Admin::grid(Administrator::class, function (Grid $grid) {
68 
+        return Admin::grid(Administrator::class, function(Grid $grid) {
69 69 
             $grid->id('ID')->sortable();
70 70 
             $grid->username(trans('admin::lang.username'));
71 71 
             $grid->name(trans('admin::lang.name'));
72 72
73 
-            $grid->roles(trans('admin::lang.roles'))->value(function ($roles) {
74 
-                $roles = array_map(function ($role) {
73 
+            $grid->roles(trans('admin::lang.roles'))->value(function($roles) {
74 
+                $roles = array_map(function($role) {
75 75 
                     return "<span class='label label-success'>{$role['name']}</span>";
76 76 
                 }, $roles);
77 77 
 
@@ -81,7 +81,7 @@  discard block
 
 block discarded – undo
81 81 
             $grid->created_at(trans('admin::lang.created_at'));
82 82 
             $grid->updated_at(trans('admin::lang.updated_at'));
83 83
84 
-            $grid->rows(function ($row) {
84 
+            $grid->rows(function($row) {
85 85 
                 if ($row->id == 1) {
86 86 
                     $row->actions('edit');
87 87 
                 }
 
@@ -96,7 +96,7 @@  discard block
 
 block discarded – undo
96 96 
      */
97 97 
     public function form()
98 98 
     {
99 
-        return Admin::form(Administrator::class, function (Form $form) {
99 
+        return Admin::form(Administrator::class, function(Form $form) {
100 100 
             $form->display('id', 'ID');
101 101
102 102 
             $form->text('username', trans('admin::lang.username'))->rules('required');
 
@@ -108,7 +108,7 @@  discard block
 
 block discarded – undo
108 108 
             $form->display('created_at', trans('admin::lang.created_at'));
109 109 
             $form->display('updated_at', trans('admin::lang.updated_at'));
110 110
111 
-            $form->saving(function (Form $form) {
111 
+            $form->saving(function(Form $form) {
112 112 
                 if ($form->password && $form->model()->password != $form->password) {
113 113 
                     $form->password = bcrypt($form->password);
114 114 
                 }
Please login to merge, or discard this patch.
src/Controllers/RoleController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -21,7 +21,7 @@  discard block
 
 block discarded – undo
21 21 
      */
22 22 
     public function index()
23 23 
     {
24 
-        return Admin::content(function (Content $content) {
24 
+        return Admin::content(function(Content $content) {
25 25 
             $content->header(trans('admin::lang.roles'));
26 26 
             $content->description(trans('admin::lang.list'));
27 27 
             $content->body($this->grid()->render());
 
@@ -37,7 +37,7 @@  discard block
 
 block discarded – undo
37 37 
      */
38 38 
     public function edit($id)
39 39 
     {
40 
-        return Admin::content(function (Content $content) use ($id) {
40 
+        return Admin::content(function(Content $content) use ($id) {
41 41 
             $content->header(trans('admin::lang.roles'));
42 42 
             $content->description(trans('admin::lang.edit'));
43 43 
             $content->body($this->form()->edit($id));
 
@@ -51,7 +51,7 @@  discard block
 
 block discarded – undo
51 51 
      */
52 52 
     public function create()
53 53 
     {
54 
-        return Admin::content(function (Content $content) {
54 
+        return Admin::content(function(Content $content) {
55 55 
             $content->header(trans('admin::lang.roles'));
56 56 
             $content->description(trans('admin::lang.create'));
57 57 
             $content->body($this->form());
 
@@ -65,7 +65,7 @@  discard block
 
 block discarded – undo
65 65 
      */
66 66 
     protected function grid()
67 67 
     {
68 
-        return Admin::grid(Role::class, function (Grid $grid) {
68 
+        return Admin::grid(Role::class, function(Grid $grid) {
69 69 
             $grid->id('ID')->sortable();
70 70 
             $grid->slug(trans('admin::lang.slug'));
71 71 
             $grid->name(trans('admin::lang.name'));
 
@@ -73,7 +73,7 @@  discard block
 
 block discarded – undo
73 73 
             $grid->created_at(trans('admin::lang.created_at'));
74 74 
             $grid->updated_at(trans('admin::lang.updated_at'));
75 75
76 
-            $grid->rows(function ($row) {
76 
+            $grid->rows(function($row) {
77 77 
                 if ($row->slug == 'administrator') {
78 78 
                     $row->actions('edit');
79 79 
                 }
 
@@ -88,7 +88,7 @@  discard block
 
 block discarded – undo
88 88 
      */
89 89 
     public function form()
90 90 
     {
91 
-        return Admin::form(Role::class, function (Form $form) {
91 
+        return Admin::form(Role::class, function(Form $form) {
92 92 
             $form->display('id', 'ID');
93 93
94 94 
             $form->text('slug', trans('admin::lang.slug'))->rules('required');
Please login to merge, or discard this patch.