Delete::handle() - Code Metrics - Inspection of "Action implements" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1d3c0c...8bf0fe )

by Song

created 2019-07-15 12:58 UTC

Delete::handle() A

↳ Parent: Delete

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0

<?php

namespace Encore\Admin\Grid\Actions;

use Encore\Admin\Actions\Response;
use Encore\Admin\Actions\RowAction;
use Illuminate\Database\Eloquent\Model;

class Delete extends RowAction
{
    /**
     * @return array|null|string
     */
    public function name()
    {
        return __('admin.delete');

    }

    /**
     * @param Model $model
     *
     * @return Response
     */
    public function handle(Model $model)
    {
        $trans = [
            'failed'    => trans('admin.delete_failed'),
            'succeeded' => trans('admin.delete_succeeded'),
        ];

        try {
            $model->delete();
        } catch (\Exception $exception) {
            return $this->getResponse()->error("{$trans['failed']} : {$exception->getMessage()}");

        }

        return $this->getResponse()->success($trans['succeeded'])->refresh();

    }

    /**
     * @return void
     */
    public function dialog()
    {
        $this->question(trans('admin.delete_confirm'), ['confirmButtonColor' => '#d33']);
    }
}

1			<?php
2
3			namespace Encore\Admin\Grid\Actions;
4
5			use Encore\Admin\Actions\Response;
6			use Encore\Admin\Actions\RowAction;
7			use Illuminate\Database\Eloquent\Model;
8
9			class Delete extends RowAction
10			{
11			/**
12			* @return array\|null\|string
13			*/
14			public function name()
15			{
16			return __('admin.delete');
			0 ignored issues – show Bug Compatibility introduced 2019-07-15 13:01 UTC by Report Bug Copy Issue Report The expression `__('admin.delete');` of type `string\|array\|null` adds the type `array` to the return on line 16 which is incompatible with the return type of the parent method `Encore\Admin\Actions\Action::name` of type `string`. Loading history...
17			}
18
19			/**
20			* @param Model $model
21			*
22			* @return Response
23			*/
24			public function handle(Model $model)
25			{
26			$trans = [
27			'failed' => trans('admin.delete_failed'),
28			'succeeded' => trans('admin.delete_succeeded'),
29			];
30
31			try {
32			$model->delete();
33			} catch (\Exception $exception) {
34			return $this->getResponse()->error("{$trans['failed']} : {$exception->getMessage()}");
			0 ignored issues – show Bug introduced 2019-07-15 13:01 UTC by Report Bug Copy Issue Report The method `getResponse()` does not exist on `Encore\Admin\Grid\Actions\Delete`. Did you maybe mean `response()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
35			}
36
37			return $this->getResponse()->success($trans['succeeded'])->refresh();
			0 ignored issues – show Bug introduced 2019-07-15 13:01 UTC by Report Bug Copy Issue Report The method `getResponse()` does not exist on `Encore\Admin\Grid\Actions\Delete`. Did you maybe mean `response()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
38			}
39
40			/**
41			* @return void
42			*/
43			public function dialog()
44			{
45			$this->question(trans('admin.delete_confirm'), ['confirmButtonColor' => '#d33']);
46			}
47			}

z-song / laravel-admin

Push — master ( 1d3c0c...8bf0fe )

Delete::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like