Completed
Pull Request — master (#3423)
by
unknown
02:56
created
src/Form/Field/Table.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,9 +65,9 @@
 block discarded – undo
65 65
 
66 66
         $prepare = $form->prepare($input);
67 67
 
68
-        return collect($prepare)->reject(function ($item) {
68
+        return collect($prepare)->reject(function($item) {
69 69
             return $item[NestedForm::REMOVE_FLAG_NAME] == 1;
70
-        })->map(function ($item) {
70
+        })->map(function($item) {
71 71
             unset($item[NestedForm::REMOVE_FLAG_NAME]);
72 72
 
73 73
             return $item;
Please login to merge, or discard this patch.
src/Form.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -436,7 +436,7 @@  discard block
 block discarded – undo
436 436
      *
437 437
      * @param array $data
438 438
      *
439
-     * @return mixed
439
+     * @return Response|null
440 440
      */
441 441
     protected function prepare($data = [])
442 442
     {
@@ -576,7 +576,7 @@  discard block
 block discarded – undo
576 576
     /**
577 577
      * Get RedirectResponse after update.
578 578
      *
579
-     * @param mixed $key
579
+     * @param integer $key
580 580
      *
581 581
      * @return \Illuminate\Http\RedirectResponse
582 582
      */
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
305 305
                 return $ret;
306 306
             }
307 307
 
308
-            collect(explode(',', $id))->filter()->each(function ($id) {
308
+            collect(explode(',', $id))->filter()->each(function($id) {
309 309
                 $builder = $this->model()->newQuery();
310 310
 
311 311
                 if ($this->isSoftDeletes) {
@@ -359,9 +359,9 @@  discard block
 block discarded – undo
359 359
 
360 360
         $data = $model->toArray();
361 361
 
362
-        $this->builder->fields()->filter(function ($field) {
362
+        $this->builder->fields()->filter(function($field) {
363 363
             return $field instanceof Field\File;
364
-        })->each(function (Field\File $file) use ($data) {
364
+        })->each(function(Field\File $file) use ($data) {
365 365
             $file->setOriginal($data);
366 366
 
367 367
             $file->destroy();
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
             return $response;
387 387
         }
388 388
 
389
-        DB::transaction(function () {
389
+        DB::transaction(function() {
390 390
             $inserts = $this->prepareInsert($this->updates);
391 391
 
392 392
             foreach ($inserts as $column => $value) {
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
535 535
             return $response;
536 536
         }
537 537
 
538
-        DB::transaction(function () {
538
+        DB::transaction(function() {
539 539
             $updates = $this->prepareUpdate($this->updates);
540 540
 
541 541
             foreach ($updates as $column => $value) {
@@ -1015,7 +1015,7 @@  discard block
 block discarded – undo
1015 1015
     protected function getFieldByColumn($column)
1016 1016
     {
1017 1017
         return $this->builder->fields()->first(
1018
-            function (Field $field) use ($column) {
1018
+            function(Field $field) use ($column) {
1019 1019
                 if (is_array($field->column())) {
1020 1020
                     return in_array($column, $field->column());
1021 1021
                 }
@@ -1036,7 +1036,7 @@  discard block
 block discarded – undo
1036 1036
 
1037 1037
         $values = $this->model->toArray();
1038 1038
 
1039
-        $this->builder->fields()->each(function (Field $field) use ($values) {
1039
+        $this->builder->fields()->each(function(Field $field) use ($values) {
1040 1040
             $field->setOriginal($values);
1041 1041
         });
1042 1042
     }
@@ -1066,7 +1066,7 @@  discard block
 block discarded – undo
1066 1066
 
1067 1067
         $data = $this->model->toArray();
1068 1068
 
1069
-        $this->builder->fields()->each(function (Field $field) use ($data) {
1069
+        $this->builder->fields()->each(function(Field $field) use ($data) {
1070 1070
             if (!in_array($field->column(), $this->ignored)) {
1071 1071
                 $field->fill($data);
1072 1072
             }
@@ -1189,7 +1189,7 @@  discard block
 block discarded – undo
1189 1189
      */
1190 1190
     public function setWidth($fieldWidth = 8, $labelWidth = 2)
1191 1191
     {
1192
-        $this->builder()->fields()->each(function ($field) use ($fieldWidth, $labelWidth) {
1192
+        $this->builder()->fields()->each(function($field) use ($fieldWidth, $labelWidth) {
1193 1193
             /* @var Field $field  */
1194 1194
             $field->setWidth($fieldWidth, $labelWidth);
1195 1195
         });
Please login to merge, or discard this patch.
src/Console/MinifyCommand.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     protected function minifyCSS()
79 79
     {
80 80
         $css = collect(array_merge(Admin::$css, Admin::baseCss()))
81
-            ->unique()->map(function ($css) {
81
+            ->unique()->map(function($css) {
82 82
 
83 83
                 if (url()->isValidUrl($css)) {
84 84
                     $this->assets['css'][] = $css;
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
     protected function minifyJS()
103 103
     {
104 104
         $js = collect(array_merge(Admin::$js, Admin::baseJs()))
105
-            ->unique()->map(function ($js) {
105
+            ->unique()->map(function($js) {
106 106
 
107 107
                 if (url()->isValidUrl($js)) {
108 108
                     $this->assets['js'][] = $js;
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 
126 126
     protected function generateManifest()
127 127
     {
128
-        $min = collect(Admin::$min)->mapWithKeys(function ($path, $type) {
128
+        $min = collect(Admin::$min)->mapWithKeys(function($path, $type) {
129 129
             return [$type => sprintf('%s?id=%s', $path, md5(uniqid()))];
130 130
         });
131 131
 
Please login to merge, or discard this patch.
database/migrations/2016_01_04_173148_create_admin_tables.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      */
22 22
     public function up()
23 23
     {
24
-        Schema::create(config('admin.database.users_table'), function (Blueprint $table) {
24
+        Schema::create(config('admin.database.users_table'), function(Blueprint $table) {
25 25
             $table->increments('id');
26 26
             $table->string('username', 190)->unique();
27 27
             $table->string('password', 60);
@@ -31,14 +31,14 @@  discard block
 block discarded – undo
31 31
             $table->timestamps();
32 32
         });
33 33
 
34
-        Schema::create(config('admin.database.roles_table'), function (Blueprint $table) {
34
+        Schema::create(config('admin.database.roles_table'), function(Blueprint $table) {
35 35
             $table->increments('id');
36 36
             $table->string('name', 50)->unique();
37 37
             $table->string('slug', 50)->unique();
38 38
             $table->timestamps();
39 39
         });
40 40
 
41
-        Schema::create(config('admin.database.permissions_table'), function (Blueprint $table) {
41
+        Schema::create(config('admin.database.permissions_table'), function(Blueprint $table) {
42 42
             $table->increments('id');
43 43
             $table->string('name', 50)->unique();
44 44
             $table->string('slug', 50)->unique();
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
             $table->timestamps();
48 48
         });
49 49
 
50
-        Schema::create(config('admin.database.menu_table'), function (Blueprint $table) {
50
+        Schema::create(config('admin.database.menu_table'), function(Blueprint $table) {
51 51
             $table->increments('id');
52 52
             $table->integer('parent_id')->default(0);
53 53
             $table->integer('order')->default(0);
@@ -59,35 +59,35 @@  discard block
 block discarded – undo
59 59
             $table->timestamps();
60 60
         });
61 61
 
62
-        Schema::create(config('admin.database.role_users_table'), function (Blueprint $table) {
62
+        Schema::create(config('admin.database.role_users_table'), function(Blueprint $table) {
63 63
             $table->integer('role_id');
64 64
             $table->integer('user_id');
65 65
             $table->index(['role_id', 'user_id']);
66 66
             $table->timestamps();
67 67
         });
68 68
 
69
-        Schema::create(config('admin.database.role_permissions_table'), function (Blueprint $table) {
69
+        Schema::create(config('admin.database.role_permissions_table'), function(Blueprint $table) {
70 70
             $table->integer('role_id');
71 71
             $table->integer('permission_id');
72 72
             $table->index(['role_id', 'permission_id']);
73 73
             $table->timestamps();
74 74
         });
75 75
 
76
-        Schema::create(config('admin.database.user_permissions_table'), function (Blueprint $table) {
76
+        Schema::create(config('admin.database.user_permissions_table'), function(Blueprint $table) {
77 77
             $table->integer('user_id');
78 78
             $table->integer('permission_id');
79 79
             $table->index(['user_id', 'permission_id']);
80 80
             $table->timestamps();
81 81
         });
82 82
 
83
-        Schema::create(config('admin.database.role_menu_table'), function (Blueprint $table) {
83
+        Schema::create(config('admin.database.role_menu_table'), function(Blueprint $table) {
84 84
             $table->integer('role_id');
85 85
             $table->integer('menu_id');
86 86
             $table->index(['role_id', 'menu_id']);
87 87
             $table->timestamps();
88 88
         });
89 89
 
90
-        Schema::create(config('admin.database.operation_log_table'), function (Blueprint $table) {
90
+        Schema::create(config('admin.database.operation_log_table'), function(Blueprint $table) {
91 91
             $table->increments('id');
92 92
             $table->integer('user_id');
93 93
             $table->string('path');
Please login to merge, or discard this patch.
src/Grid/Concerns/HasElementNames.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -107,6 +107,7 @@
 block discarded – undo
107 107
     }
108 108
 
109 109
     /**
110
+     * @param string $name
110 111
      * @return string
111 112
      */
112 113
     protected function elementNameWithPrefix($name)
Please login to merge, or discard this patch.
src/Grid/Concerns/HasFilter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      *
53 53
      * @param bool $toArray
54 54
      *
55
-     * @return array|Collection|mixed
55
+     * @return Collection
56 56
      */
57 57
     public function processFilter($toArray = true)
58 58
     {
Please login to merge, or discard this patch.
src/Admin.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -287,10 +287,10 @@
 block discarded – undo
287 287
             'middleware' => config('admin.route.middleware'),
288 288
         ];
289 289
 
290
-        app('router')->group($attributes, function ($router) {
290
+        app('router')->group($attributes, function($router) {
291 291
 
292 292
             /* @var \Illuminate\Support\Facades\Route $router */
293
-            $router->namespace('\Encore\Admin\Controllers')->group(function ($router) {
293
+            $router->namespace('\Encore\Admin\Controllers')->group(function($router) {
294 294
 
295 295
                 /* @var \Illuminate\Routing\Router $router */
296 296
                 $router->resource('auth/users', 'UserController')->names('admin.auth.users');
Please login to merge, or discard this patch.
src/Grid.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
      * Get or set option for grid.
261 261
      *
262 262
      * @param string $key
263
-     * @param mixed  $value
263
+     * @param boolean  $value
264 264
      *
265 265
      * @return $this|mixed
266 266
      */
@@ -464,7 +464,7 @@  discard block
 block discarded – undo
464 464
     /**
465 465
      * Get the grid paginator.
466 466
      *
467
-     * @return mixed
467
+     * @return Tools\Paginator
468 468
      */
469 469
     public function paginator()
470 470
     {
@@ -516,7 +516,7 @@  discard block
 block discarded – undo
516 516
     /**
517 517
      * Set grid action callback.
518 518
      *
519
-     * @param Closure|string $actions
519
+     * @param Closure $actions
520 520
      *
521 521
      * @return $this
522 522
      */
@@ -876,8 +876,8 @@  discard block
 block discarded – undo
876 876
     /**
877 877
      * Dynamically add columns to the grid view.
878 878
      *
879
-     * @param $method
880
-     * @param $arguments
879
+     * @param string $method
880
+     * @param string[] $arguments
881 881
      *
882 882
      * @return Column
883 883
      */
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
         $column = new Column($column, $label);
351 351
         $column->setGrid($this);
352 352
 
353
-        return tap($column, function ($value) {
353
+        return tap($column, function($value) {
354 354
             $this->columns->push($value);
355 355
         });
356 356
     }
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
         $column = new Column($column, $label);
415 415
         $column->setGrid($this);
416 416
 
417
-        return tap($column, function ($value) {
417
+        return tap($column, function($value) {
418 418
             $this->columns->prepend($value);
419 419
         });
420 420
     }
@@ -577,7 +577,7 @@  discard block
 block discarded – undo
577 577
 
578 578
         Column::setOriginalGridModels($collection);
579 579
 
580
-        $this->columns->map(function (Column $column) use (&$data) {
580
+        $this->columns->map(function(Column $column) use (&$data) {
581 581
             $data = $column->fill($data);
582 582
 
583 583
             $this->columnNames[] = $column->getName();
@@ -597,7 +597,7 @@  discard block
 block discarded – undo
597 597
      */
598 598
     protected function buildRows(array $data)
599 599
     {
600
-        $this->rows = collect($data)->map(function ($model, $number) {
600
+        $this->rows = collect($data)->map(function($model, $number) {
601 601
             return new Row($number, $model);
602 602
         });
603 603
 
Please login to merge, or discard this patch.
src/Controllers/RoleController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -36,14 +36,14 @@  discard block
 block discarded – undo
36 36
         $grid->column('created_at', trans('admin.created_at'));
37 37
         $grid->column('updated_at', trans('admin.updated_at'));
38 38
 
39
-        $grid->actions(function (Grid\Displayers\Actions $actions) {
39
+        $grid->actions(function(Grid\Displayers\Actions $actions) {
40 40
             if ($actions->row->slug == 'administrator') {
41 41
                 $actions->disableDelete();
42 42
             }
43 43
         });
44 44
 
45
-        $grid->tools(function (Grid\Tools $tools) {
46
-            $tools->batch(function (Grid\Tools\BatchActions $actions) {
45
+        $grid->tools(function(Grid\Tools $tools) {
46
+            $tools->batch(function(Grid\Tools\BatchActions $actions) {
47 47
                 $actions->disableDelete();
48 48
             });
49 49
         });
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
         $show->field('id', 'ID');
68 68
         $show->field('slug', trans('admin.slug'));
69 69
         $show->field('name', trans('admin.name'));
70
-        $show->field('permissions', trans('admin.permissions'))->as(function ($permission) {
70
+        $show->field('permissions', trans('admin.permissions'))->as(function($permission) {
71 71
             return $permission->pluck('name');
72 72
         })->label();
73 73
         $show->field('created_at', trans('admin.created_at'));
Please login to merge, or discard this patch.