Issues in MultipleImage.php - Fixed Issues - Inspection of "Merge pull request #4996 from themightysapien/mast..." - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9b49f7...0d2bac )

by Song

created 2020-09-24 08:20 UTC

src/Form/Field/MultipleImage.php (1 issue)

Showing only issues like (Show All)

call_checks.possibly_null_being_passed_with_param

Bug Major

z-song 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Encore\Admin\Form\Field;

use Symfony\Component\HttpFoundation\File\UploadedFile;

class MultipleImage extends MultipleFile
{
    use ImageField;

    /**
     * {@inheritdoc}
     */
    protected $view = 'admin::form.multiplefile';

    /**
     *  Validation rules.
     *
     * @var string
     */
    protected $rules = 'image';

    /**
     * Prepare for each file.
     *
     * @param UploadedFile $image
     *
     * @return mixed|string
     */
    protected function prepareForeach(UploadedFile $image = null)
    {
        $this->name = $this->getStoreName($image);

        $this->callInterventionMethods($image->getRealPath());

        return tap($this->upload($image), function () {
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
            $this->name = null;
        });
    }
}


1		<?php
2
3		namespace Encore\Admin\Form\Field;
4
5		use Symfony\Component\HttpFoundation\File\UploadedFile;
6
7		class MultipleImage extends MultipleFile
8		{
9		use ImageField;
10
11		/**
12		* {@inheritdoc}
13		*/
14		protected $view = 'admin::form.multiplefile';
15
16		/**
17		* Validation rules.
18		*
19		* @var string
20		*/
21		protected $rules = 'image';
22
23		/**
24		* Prepare for each file.
25		*
26		* @param UploadedFile $image
27		*
28		* @return mixed\|string
29		*/
30	View Code Duplication	protected function prepareForeach(UploadedFile $image = null)
31		{
32		$this->name = $this->getStoreName($image);
33
34		$this->callInterventionMethods($image->getRealPath());
35
36		return tap($this->upload($image), function () {
		0 ignored issues – show Bug introduced 2017-09-19 15:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$image` defined by parameter `$image` on line `30` can be `null`; however, `Encore\Admin\Form\Field\UploadField::upload()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
37		$this->name = null;
38		});
39		}
40		}
41

z-song / laravel-admin

Push — master ( 9b49f7...0d2bac )

src/Form/Field/MultipleImage.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like