QuickSearch::placeholder() - Code Metrics - Inspection of "Grid quick search support set placeholder, Fix #36..." - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6943ef...15a38e )

by Song

created 2019-07-05 06:37 UTC

QuickSearch::placeholder() A

↳ Parent: QuickSearch

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php

namespace Encore\Admin\Grid\Tools;

use Encore\Admin\Grid\Concerns\HasQuickSearch;
use Illuminate\Support\Arr;

class QuickSearch extends AbstractTool
{
    /**
     * @var string
     */
    protected $view = 'admin::grid.quick-search';

    /**
     * @var string
     */
    protected $placeholder;

    /**
     * Set placeholder.
     *
     * @param string $text
     *
     * @return $this
     */
    public function placeholder($text = '')
    {
        $this->placeholder = $text;

        return $this;
    }

    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function render()
    {
        $query = request()->query();

        Arr::forget($query, HasQuickSearch::$searchKey);

        $vars = [
            'action'      => request()->url().'?'.http_build_query($query),
            'key'         => HasQuickSearch::$searchKey,
            'value'       => request(HasQuickSearch::$searchKey),
            'placeholder' => $this->placeholder,
        ];

        return view($this->view, $vars);

    }
}


1			<?php
2
3			namespace Encore\Admin\Grid\Tools;
4
5			use Encore\Admin\Grid\Concerns\HasQuickSearch;
6			use Illuminate\Support\Arr;
7
8			class QuickSearch extends AbstractTool
9			{
10			/**
11			* @var string
12			*/
13			protected $view = 'admin::grid.quick-search';
14
15			/**
16			* @var string
17			*/
18			protected $placeholder;
19
20			/**
21			* Set placeholder.
22			*
23			* @param string $text
24			*
25			* @return $this
26			*/
27			public function placeholder($text = '')
28			{
29			$this->placeholder = $text;
30
31			return $this;
32			}
33
34			/**
35			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
36			*/
37			public function render()
38			{
39			$query = request()->query();
40
41			Arr::forget($query, HasQuickSearch::$searchKey);
42
43			$vars = [
44			'action' => request()->url().'?'.http_build_query($query),
45			'key' => HasQuickSearch::$searchKey,
46			'value' => request(HasQuickSearch::$searchKey),
47			'placeholder' => $this->placeholder,
48			];
49
50			return view($this->view, $vars);
			0 ignored issues – show Bug Compatibility introduced 2019-05-31 11:04 UTC by Report Bug Copy Issue Report The expression `view($this->view, $vars);` of type `Illuminate\View\View\|Ill...\Contracts\View\Factory` adds the type `Illuminate\Contracts\View\Factory` to the return on line 50 which is incompatible with the return type declared by the interface `Illuminate\Contracts\Support\Renderable::render` of type `string`. Loading history...
51			}
52			}
53

z-song / laravel-admin

Push — master ( 6943ef...15a38e )

QuickSearch::placeholder() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like