NestedForm - Code Metrics - Inspection of "修复数据表单的table和embeds功能" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5062)

by zi

created 2020-10-30 04:59 UTC

NestedForm B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	411
Duplicated Lines	14.11 %

Coupling/Cohesion

Components	2
Dependencies	6

Importance

Changes

Metric	Value
dl	58
loc	411
rs	8.72
c	0
b	0
f	0
wmc	46
lcom	2
cbo	6

18 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	model()	0	4	1
A	getKey()	0	16	4
A	setKey()	0	6	1
A	setForm()	0	6	1
A	setWidgetForm()	0	6	1
A	getForm()	0	4	1
A	setOriginal()	0	19	4
A	prepare()	0	9	2
A	setFieldOriginalValue()	10	11	2
B	prepareRecord()	7	37	10
A	fetchColumnValue()	18	18	5
A	pushField()	0	6	1
A	fields()	0	4	1
A	fill()	0	9	2
A	getTemplateHtmlAndScript()	0	21	3
A	formatField()	0	24	3
A	__call()	23	23	3

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like NestedForm often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use NestedForm, and based on these observations, apply Extract Interface, too.

<?php

namespace Encore\Admin\Form;

use Encore\Admin\Admin;
use Encore\Admin\Form;
use Encore\Admin\Widgets\Form as WidgetForm;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Arr;
use Illuminate\Support\Collection;

/**
 * Class NestedForm.
 *
 * @method Field\Text           text($column, $label = '')
 * @method Field\Checkbox       checkbox($column, $label = '')
 * @method Field\Radio          radio($column, $label = '')
 * @method Field\Select         select($column, $label = '')
 * @method Field\MultipleSelect multipleSelect($column, $label = '')
 * @method Field\Textarea       textarea($column, $label = '')
 * @method Field\Hidden         hidden($column, $label = '')
 * @method Field\Id             id($column, $label = '')
 * @method Field\Ip             ip($column, $label = '')
 * @method Field\Url            url($column, $label = '')
 * @method Field\Color          color($column, $label = '')
 * @method Field\Email          email($column, $label = '')
 * @method Field\Mobile         mobile($column, $label = '')
 * @method Field\Slider         slider($column, $label = '')
 * @method Field\Map            map($latitude, $longitude, $label = '')
 * @method Field\Editor         editor($column, $label = '')
 * @method Field\File           file($column, $label = '')
 * @method Field\Image          image($column, $label = '')
 * @method Field\Date           date($column, $label = '')
 * @method Field\Datetime       datetime($column, $label = '')
 * @method Field\Time           time($column, $label = '')
 * @method Field\Year           year($column, $label = '')
 * @method Field\Month          month($column, $label = '')
 * @method Field\DateRange      dateRange($start, $end, $label = '')
 * @method Field\DateTimeRange  datetimeRange($start, $end, $label = '')
 * @method Field\TimeRange      timeRange($start, $end, $label = '')
 * @method Field\Number         number($column, $label = '')
 * @method Field\Currency       currency($column, $label = '')
 * @method Field\HasMany        hasMany($relationName, $callback)
 * @method Field\SwitchField    switch($column, $label = '')
 * @method Field\Display        display($column, $label = '')
 * @method Field\Rate           rate($column, $label = '')
 * @method Field\Divide         divider()
 * @method Field\Password       password($column, $label = '')
 * @method Field\Decimal        decimal($column, $label = '')
 * @method Field\Html           html($html, $label = '')
 * @method Field\Tags           tags($column, $label = '')
 * @method Field\Icon           icon($column, $label = '')
 * @method Field\Embeds         embeds($column, $label = '')
 */
class NestedForm
{
    const DEFAULT_KEY_NAME = '__LA_KEY__';

    const REMOVE_FLAG_NAME = '_remove_';

    const REMOVE_FLAG_CLASS = 'fom-removed';

    /**
     * @var mixed
     */
    protected $key;

    /**
     * @var string
     */
    protected $relationName;

    /**
     * NestedForm key.
     *
     * @var Model
     */
    protected $model;

    /**
     * Fields in form.
     *
     * @var Collection
     */
    protected $fields;

    /**
     * Original data for this field.
     *
     * @var array
     */
    protected $original = [];

    /**
     * @var \Encore\Admin\Form|\Encore\Admin\Widgets\Form
     */
    protected $form;

    /**
     * Create a new NestedForm instance.
     *
     * NestedForm constructor.
     *
     * @param string $relation
     * @param Model  $model
     */
    public function __construct($relation, $model = null)
    {
        $this->relationName = $relation;

        $this->model = $model;

        $this->fields = new Collection();
    }

    /**
     * Get current model.
     *
     * @return Model|null
     */
    public function model()
    {
        return $this->model;
    }

    /**
     * Get the value of the model's primary key.
     *
     * @return mixed|null
     */
    public function getKey()
    {
        if ($this->model) {
            $key = $this->model->getKey();
        }

        if (!is_null($this->key)) {
            $key = $this->key;
        }

        if (isset($key)) {
            return $key;
        }

        return 'new_'.static::DEFAULT_KEY_NAME;
    }

    /**
     * Set key for current form.
     *
     * @param mixed $key
     *
     * @return $this
     */
    public function setKey($key)
    {
        $this->key = $key;

        return $this;
    }

    /**
     * Set Form.
     *
     * @param Form $form
     *
     * @return $this
     */
    public function setForm(Form $form = null)
    {
        $this->form = $form;

        return $this;
    }

    /**
     * Set Widget/Form.
     *
     * @param WidgetForm $form
     *
     * @return $this
     */
    public function setWidgetForm(WidgetForm $form = null)
    {
        $this->form = $form;

        return $this;
    }

    /**
     * Get form.
     *
     * @return Form
     */
    public function getForm()
    {
        return $this->form;

    }

    /**
     * Set original values for fields.
     *
     * @param array  $data
     * @param string $relatedKeyName
     *
     * @return $this
     */
    public function setOriginal($data, $relatedKeyName = null)
    {
        if (empty($data)) {
            return $this;
        }

        foreach ($data as $key => $value) {
            /*
             * like $this->original[30] = [ id = 30, .....]
             */
            if ($relatedKeyName) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $key = $value[$relatedKeyName];
            }

            $this->original[$key] = $value;
        }

        return $this;
    }

    /**
     * Prepare for insert or update.
     *
     * @param array $input
     *
     * @return mixed
     */
    public function prepare($input)
    {
        foreach ($input as $key => $record) {
            $this->setFieldOriginalValue($key);
            $input[$key] = $this->prepareRecord($record);
        }

        return $input;
    }

    /**
     * Set original data for each field.
     *
     * @param string $key
     *
     * @return void
     */
    protected function setFieldOriginalValue($key)

    {
        $values = [];
        if (array_key_exists($key, $this->original)) {
            $values = $this->original[$key];
        }

        $this->fields->each(function (Field $field) use ($values) {
            $field->setOriginal($values);
        });
    }

    /**
     * Do prepare work before store and update.
     *
     * @param array $record
     *
     * @return array
     */
    protected function prepareRecord($record)
    {
        if ($record[static::REMOVE_FLAG_NAME] == 1) {
            return $record;
        }

        $prepared = [];

        /* @var Field $field */
        foreach ($this->fields as $field) {
            $columns = $field->column();

            $value = $this->fetchColumnValue($record, $columns);

            if (is_null($value)) {
                continue;
            }

            if (method_exists($field, 'prepare')) {
                $value = $field->prepare($value);
            }

            if (($field instanceof \Encore\Admin\Form\Field\Hidden) || $value != $field->original()) {
                if (is_array($columns)) {

                    foreach ($columns as $name => $column) {
                        Arr::set($prepared, $column, $value[$name]);
                    }
                } elseif (is_string($columns)) {
                    Arr::set($prepared, $columns, $value);
                }
            }
        }

        $prepared[static::REMOVE_FLAG_NAME] = $record[static::REMOVE_FLAG_NAME];

        return $prepared;
    }

    /**
     * Fetch value in input data by column name.
     *
     * @param array        $data
     * @param string|array $columns
     *
     * @return array|mixed
     */
    protected function fetchColumnValue($data, $columns)

    {
        if (is_string($columns)) {
            return Arr::get($data, $columns);
        }

        if (is_array($columns)) {
            $value = [];
            foreach ($columns as $name => $column) {
                if (!Arr::has($data, $column)) {
                    continue;
                }
                $value[$name] = Arr::get($data, $column);
            }

            return $value;
        }
    }

    /**
     * @param Field $field
     *
     * @return $this
     */
    public function pushField(Field $field)
    {
        $this->fields->push($field);

        return $this;
    }

    /**
     * Get fields of this form.
     *
     * @return Collection
     */
    public function fields()
    {
        return $this->fields;
    }

    /**
     * Fill data to all fields in form.
     *
     * @param array $data
     *
     * @return $this
     */
    public function fill(array $data)
    {
        /* @var Field $field */
        foreach ($this->fields() as $field) {
            $field->fill($data);
        }

        return $this;
    }

    /**
     * Get the html and script of template.
     *
     * @return array
     */
    public function getTemplateHtmlAndScript()
    {
        $html = '';
        $scripts = [];

        /* @var Field $field */
        foreach ($this->fields() as $field) {

            //when field render, will push $script to Admin
            $html .= $field->render();

            /*
             * Get and remove the last script of Admin::$script stack.
             */
            if ($field->getScript()) {
                $scripts[] = array_pop(Admin::$script);
            }
        }

        return [$html, implode("\r\n", $scripts)];
    }

    /**
     * Set `errorKey` `elementName` `elementClass` for fields inside hasmany fields.
     *
     * @param Field $field
     *
     * @return Field
     */
    protected function formatField(Field $field)
    {
        $column = $field->column();

        $elementName = $elementClass = $errorKey = [];

        $key = $this->getKey();

        if (is_array($column)) {
            foreach ($column as $k => $name) {
                $errorKey[$k] = sprintf('%s.%s.%s', $this->relationName, $key, $name);
                $elementName[$k] = sprintf('%s[%s][%s]', $this->relationName, $key, $name);
                $elementClass[$k] = [$this->relationName, $name];
            }
        } else {
            $errorKey = sprintf('%s.%s.%s', $this->relationName, $key, $column);
            $elementName = sprintf('%s[%s][%s]', $this->relationName, $key, $column);
            $elementClass = [$this->relationName, $column];
        }

        return $field->setErrorKey($errorKey)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            ->setElementName($elementName)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            ->setElementClass($elementClass);
    }

    /**
     * Add nested-form fields dynamically.
     *
     * @param string $method
     * @param array  $arguments
     *
     * @return mixed
     */
    public function __call($method, $arguments)

    {
        if ($className = Form::findFieldClass($method)) {
            $column = Arr::get($arguments, 0, '');

            /* @var Field $field */
            $field = new $className($column, array_slice($arguments, 1));

            if ($this->form instanceof WidgetForm) {
                $field->setWidgetForm($this->form);
            } else {
                $field->setForm($this->form);
            }

            $field = $this->formatField($field);

            $this->pushField($field);

            return $field;
        }

        return $this;
    }
}


1		<?php
2
3		namespace Encore\Admin\Form;
4
5		use Encore\Admin\Admin;
6		use Encore\Admin\Form;
7		use Encore\Admin\Widgets\Form as WidgetForm;
8		use Illuminate\Database\Eloquent\Model;
9		use Illuminate\Support\Arr;
10		use Illuminate\Support\Collection;
11
12		/**
13		* Class NestedForm.
14		*
15		* @method Field\Text text($column, $label = '')
16		* @method Field\Checkbox checkbox($column, $label = '')
17		* @method Field\Radio radio($column, $label = '')
18		* @method Field\Select select($column, $label = '')
19		* @method Field\MultipleSelect multipleSelect($column, $label = '')
20		* @method Field\Textarea textarea($column, $label = '')
21		* @method Field\Hidden hidden($column, $label = '')
22		* @method Field\Id id($column, $label = '')
23		* @method Field\Ip ip($column, $label = '')
24		* @method Field\Url url($column, $label = '')
25		* @method Field\Color color($column, $label = '')
26		* @method Field\Email email($column, $label = '')
27		* @method Field\Mobile mobile($column, $label = '')
28		* @method Field\Slider slider($column, $label = '')
29		* @method Field\Map map($latitude, $longitude, $label = '')
30		* @method Field\Editor editor($column, $label = '')
31		* @method Field\File file($column, $label = '')
32		* @method Field\Image image($column, $label = '')
33		* @method Field\Date date($column, $label = '')
34		* @method Field\Datetime datetime($column, $label = '')
35		* @method Field\Time time($column, $label = '')
36		* @method Field\Year year($column, $label = '')
37		* @method Field\Month month($column, $label = '')
38		* @method Field\DateRange dateRange($start, $end, $label = '')
39		* @method Field\DateTimeRange datetimeRange($start, $end, $label = '')
40		* @method Field\TimeRange timeRange($start, $end, $label = '')
41		* @method Field\Number number($column, $label = '')
42		* @method Field\Currency currency($column, $label = '')
43		* @method Field\HasMany hasMany($relationName, $callback)
44		* @method Field\SwitchField switch($column, $label = '')
45		* @method Field\Display display($column, $label = '')
46		* @method Field\Rate rate($column, $label = '')
47		* @method Field\Divide divider()
48		* @method Field\Password password($column, $label = '')
49		* @method Field\Decimal decimal($column, $label = '')
50		* @method Field\Html html($html, $label = '')
51		* @method Field\Tags tags($column, $label = '')
52		* @method Field\Icon icon($column, $label = '')
53		* @method Field\Embeds embeds($column, $label = '')
54		*/
55		class NestedForm
56		{
57		const DEFAULT_KEY_NAME = '__LA_KEY__';
58
59		const REMOVE_FLAG_NAME = '_remove_';
60
61		const REMOVE_FLAG_CLASS = 'fom-removed';
62
63		/**
64		* @var mixed
65		*/
66		protected $key;
67
68		/**
69		* @var string
70		*/
71		protected $relationName;
72
73		/**
74		* NestedForm key.
75		*
76		* @var Model
77		*/
78		protected $model;
79
80		/**
81		* Fields in form.
82		*
83		* @var Collection
84		*/
85		protected $fields;
86
87		/**
88		* Original data for this field.
89		*
90		* @var array
91		*/
92		protected $original = [];
93
94		/**
95		* @var \Encore\Admin\Form\|\Encore\Admin\Widgets\Form
96		*/
97		protected $form;
98
99		/**
100		* Create a new NestedForm instance.
101		*
102		* NestedForm constructor.
103		*
104		* @param string $relation
105		* @param Model $model
106		*/
107		public function __construct($relation, $model = null)
108		{
109		$this->relationName = $relation;
110
111		$this->model = $model;
112
113		$this->fields = new Collection();
114		}
115
116		/**
117		* Get current model.
118		*
119		* @return Model\|null
120		*/
121		public function model()
122		{
123		return $this->model;
124		}
125
126		/**
127		* Get the value of the model's primary key.
128		*
129		* @return mixed\|null
130		*/
131		public function getKey()
132		{
133		if ($this->model) {
134		$key = $this->model->getKey();
135		}
136
137		if (!is_null($this->key)) {
138		$key = $this->key;
139		}
140
141		if (isset($key)) {
142		return $key;
143		}
144
145		return 'new_'.static::DEFAULT_KEY_NAME;
146		}
147
148		/**
149		* Set key for current form.
150		*
151		* @param mixed $key
152		*
153		* @return $this
154		*/
155		public function setKey($key)
156		{
157		$this->key = $key;
158
159		return $this;
160		}
161
162		/**
163		* Set Form.
164		*
165		* @param Form $form
166		*
167		* @return $this
168		*/
169		public function setForm(Form $form = null)
170		{
171		$this->form = $form;
172
173		return $this;
174		}
175
176		/**
177		* Set Widget/Form.
178		*
179		* @param WidgetForm $form
180		*
181		* @return $this
182		*/
183		public function setWidgetForm(WidgetForm $form = null)
184		{
185		$this->form = $form;
186
187		return $this;
188		}
189
190		/**
191		* Get form.
192		*
193		* @return Form
194		*/
195		public function getForm()
196		{
197		return $this->form;
		0 ignored issues – show Bug Compatibility introduced 2020-10-30 05:02 UTC by Report Bug Copy Issue Report The expression `$this->form;` of type `Encore\Admin\Form\|Encore\Admin\Widgets\Form` adds the type `Encore\Admin\Widgets\Form` to the return on line 197 which is incompatible with the return type documented by `Encore\Admin\Form\NestedForm::getForm` of type `Encore\Admin\Form`. Loading history...
198		}
199
200		/**
201		* Set original values for fields.
202		*
203		* @param array $data
204		* @param string $relatedKeyName
205		*
206		* @return $this
207		*/
208		public function setOriginal($data, $relatedKeyName = null)
209		{
210		if (empty($data)) {
211		return $this;
212		}
213
214		foreach ($data as $key => $value) {
215		/*
216		* like $this->original[30] = [ id = 30, .....]
217		*/
218		if ($relatedKeyName) {
		0 ignored issues – show Bug Best Practice introduced 2019-04-26 16:23 UTC by Report Bug Copy Issue Report The expression `$relatedKeyName` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
219		$key = $value[$relatedKeyName];
220		}
221
222		$this->original[$key] = $value;
223		}
224
225		return $this;
226		}
227
228		/**
229		* Prepare for insert or update.
230		*
231		* @param array $input
232		*
233		* @return mixed
234		*/
235		public function prepare($input)
236		{
237		foreach ($input as $key => $record) {
238		$this->setFieldOriginalValue($key);
239		$input[$key] = $this->prepareRecord($record);
240		}
241
242		return $input;
243		}
244
245		/**
246		* Set original data for each field.
247		*
248		* @param string $key
249		*
250		* @return void
251		*/
252	View Code Duplication	protected function setFieldOriginalValue($key)
		0 ignored issues – show Duplication introduced 2017-09-01 02:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
253		{
254		$values = [];
255		if (array_key_exists($key, $this->original)) {
256		$values = $this->original[$key];
257		}
258
259		$this->fields->each(function (Field $field) use ($values) {
260		$field->setOriginal($values);
261		});
262		}
263
264		/**
265		* Do prepare work before store and update.
266		*
267		* @param array $record
268		*
269		* @return array
270		*/
271		protected function prepareRecord($record)
272		{
273		if ($record[static::REMOVE_FLAG_NAME] == 1) {
274		return $record;
275		}
276
277		$prepared = [];
278
279		/* @var Field $field */
280		foreach ($this->fields as $field) {
281		$columns = $field->column();
282
283		$value = $this->fetchColumnValue($record, $columns);
284
285		if (is_null($value)) {
286		continue;
287		}
288
289		if (method_exists($field, 'prepare')) {
290		$value = $field->prepare($value);
291		}
292
293		if (($field instanceof \Encore\Admin\Form\Field\Hidden) \|\| $value != $field->original()) {
294	View Code Duplication	if (is_array($columns)) {
		0 ignored issues – show Duplication introduced 2017-09-01 02:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
295		foreach ($columns as $name => $column) {
296		Arr::set($prepared, $column, $value[$name]);
297		}
298		} elseif (is_string($columns)) {
299		Arr::set($prepared, $columns, $value);
300		}
301		}
302		}
303
304		$prepared[static::REMOVE_FLAG_NAME] = $record[static::REMOVE_FLAG_NAME];
305
306		return $prepared;
307		}
308
309		/**
310		* Fetch value in input data by column name.
311		*
312		* @param array $data
313		* @param string\|array $columns
314		*
315		* @return array\|mixed
316		*/
317	View Code Duplication	protected function fetchColumnValue($data, $columns)
		0 ignored issues – show Duplication introduced 2017-09-01 02:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
318		{
319		if (is_string($columns)) {
320		return Arr::get($data, $columns);
321		}
322
323		if (is_array($columns)) {
324		$value = [];
325		foreach ($columns as $name => $column) {
326		if (!Arr::has($data, $column)) {
327		continue;
328		}
329		$value[$name] = Arr::get($data, $column);
330		}
331
332		return $value;
333		}
334		}
335
336		/**
337		* @param Field $field
338		*
339		* @return $this
340		*/
341		public function pushField(Field $field)
342		{
343		$this->fields->push($field);
344
345		return $this;
346		}
347
348		/**
349		* Get fields of this form.
350		*
351		* @return Collection
352		*/
353		public function fields()
354		{
355		return $this->fields;
356		}
357
358		/**
359		* Fill data to all fields in form.
360		*
361		* @param array $data
362		*
363		* @return $this
364		*/
365		public function fill(array $data)
366		{
367		/* @var Field $field */
368		foreach ($this->fields() as $field) {
369		$field->fill($data);
370		}
371
372		return $this;
373		}
374
375		/**
376		* Get the html and script of template.
377		*
378		* @return array
379		*/
380		public function getTemplateHtmlAndScript()
381		{
382		$html = '';
383		$scripts = [];
384
385		/* @var Field $field */
386		foreach ($this->fields() as $field) {
387
388		//when field render, will push $script to Admin
389		$html .= $field->render();
390
391		/*
392		* Get and remove the last script of Admin::$script stack.
393		*/
394		if ($field->getScript()) {
395		$scripts[] = array_pop(Admin::$script);
396		}
397		}
398
399		return [$html, implode("\r\n", $scripts)];
400		}
401
402		/**
403		* Set `errorKey` `elementName` `elementClass` for fields inside hasmany fields.
404		*
405		* @param Field $field
406		*
407		* @return Field
408		*/
409		protected function formatField(Field $field)
410		{
411		$column = $field->column();
412
413		$elementName = $elementClass = $errorKey = [];
414
415		$key = $this->getKey();
416
417		if (is_array($column)) {
418		foreach ($column as $k => $name) {
419		$errorKey[$k] = sprintf('%s.%s.%s', $this->relationName, $key, $name);
420		$elementName[$k] = sprintf('%s[%s][%s]', $this->relationName, $key, $name);
421		$elementClass[$k] = [$this->relationName, $name];
422		}
423		} else {
424		$errorKey = sprintf('%s.%s.%s', $this->relationName, $key, $column);
425		$elementName = sprintf('%s[%s][%s]', $this->relationName, $key, $column);
426		$elementClass = [$this->relationName, $column];
427		}
428
429		return $field->setErrorKey($errorKey)
		0 ignored issues – show Bug introduced 2017-10-13 02:31 UTC by Report Bug Copy Issue Report It seems like `$errorKey` defined by `array()` on line `413` can also be of type `array`; however, `Encore\Admin\Form\Field::setErrorKey()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
430		->setElementName($elementName)
		0 ignored issues – show Bug introduced 2017-10-13 02:31 UTC by Report Bug Copy Issue Report It seems like `$elementName` defined by `$elementClass = $errorKey = array()` on line `413` can also be of type `array`; however, `Encore\Admin\Form\Field::setElementName()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
431		->setElementClass($elementClass);
432		}
433
434		/**
435		* Add nested-form fields dynamically.
436		*
437		* @param string $method
438		* @param array $arguments
439		*
440		* @return mixed
441		*/
442	View Code Duplication	public function __call($method, $arguments)
		0 ignored issues – show Duplication introduced 2017-09-01 02:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
443		{
444		if ($className = Form::findFieldClass($method)) {
445		$column = Arr::get($arguments, 0, '');
446
447		/* @var Field $field */
448		$field = new $className($column, array_slice($arguments, 1));
449
450		if ($this->form instanceof WidgetForm) {
451		$field->setWidgetForm($this->form);
452		} else {
453		$field->setForm($this->form);
454		}
455
456		$field = $this->formatField($field);
457
458		$this->pushField($field);
459
460		return $field;
461		}
462
463		return $this;
464		}
465		}
466

z-song / laravel-admin