FormCommand::handle() - Code Metrics - Inspection of "add a command:form filed generator" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2262)

unknown

created 2018-08-02 05:27 UTC

FormCommand::handle() F

↳ Parent: FormCommand

Complexity

Conditions	34
Paths	112

Size

Total Lines

128

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	34
nc	112
nop	0
dl	0
loc	128
rs	3.2533
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Encore\Admin\Console;

use Illuminate\Console\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputOption;

class FormCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'admin:form';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'laravel-admin form filed generator';

    /**
     * Execute the console command.
     *
     * @return void
     */
    public function handle()
    {
        $modelName = $this->option('model');
        if (empty($modelName) || !class_exists($modelName)) {
            $this->error('Model does not exists !');
            return false;
        }

        // use doctrine/dbal
        $model = $this->laravel->make($modelName);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $table = $model->getConnection()->getTablePrefix() . $model->getTable();
        $schema = $model->getConnection()->getDoctrineSchemaManager($table);

        if (!method_exists($schema, 'getDatabasePlatform')) {
            $this->error('You need to require doctrine/dbal: ~2.3 in your own composer.json to get database columns. ');
            $this->info('Using install command: composer require doctrine/dbal');
            return false;

        }

        // custom mapping the types that doctrine/dbal does not support
        $databasePlatform = $schema->getDatabasePlatform();
        $databasePlatform->registerDoctrineTypeMapping('enum', 'string');
        $databasePlatform->registerDoctrineTypeMapping('geometry', 'string');
        $databasePlatform->registerDoctrineTypeMapping('geometrycollection', 'string');
        $databasePlatform->registerDoctrineTypeMapping('linestring', 'string');
        $databasePlatform->registerDoctrineTypeMapping('multilinestring', 'string');
        $databasePlatform->registerDoctrineTypeMapping('multipoint', 'string');
        $databasePlatform->registerDoctrineTypeMapping('multipolygon', 'string');
        $databasePlatform->registerDoctrineTypeMapping('point', 'string');
        $databasePlatform->registerDoctrineTypeMapping('polygon', 'string');
        $databasePlatform->registerDoctrineTypeMapping('multipolygon', 'string');
        $databasePlatform->registerDoctrineTypeMapping('multipolygon', 'string');

        $database = null;
        if (strpos($table, '.')) {
            list($database, $table) = explode('.', $table);
        }
        $columns = $schema->listTableColumns($table, $database);

        $admin_form = '';
        if ($columns) {
            foreach ($columns as $column) {
                $name = $column->getName();
                if (in_array($name, ['id', 'created_at', 'deleted_at'])) {
                    continue;
                }
                $type = $column->getType()->getName();
                $comment = $column->getComment();
                $default = $column->getDefault();
                if ($default === '') {
                    $default = "''";
                }

                switch ($type) {
                    case 'boolean':
                    case 'bool':
                        $field_type = 'switch';
                        break;
                    case 'json':
                    case 'array':
                    case 'object':
                        $field_type = 'text';
                        break;
                    case 'string':
                        switch ($name) {
                            case $this->check_column($name, ['email']):
                                $field_type = 'email';
                                break;
                            case $this->check_column($name, ['password', 'pwd']):
                                $field_type = 'password';
                                break;
                            case $this->check_column($name, ['url', 'link', 'src', 'href']):
                                $field_type = 'url';
                                break;
                            case $this->check_column($name, ['ip']):
                                $field_type = 'ip';
                                break;
                            case $this->check_column($name, ['mobile', 'phone']):
                                $field_type = 'mobile';
                                break;
                            case $this->check_column($name, ['color', 'rgb']):
                                $field_type = 'color';
                                break;
                            case $this->check_column($name, ['image', 'img', 'avatar']) :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                                $field_type = 'image';
                                break;
                            case $this->check_column($name, ['file', 'attachment']) :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                                $field_type = 'file';
                                break;
                            default:
                                $field_type = 'text';
                        }
                        break;
                    case 'integer':
                    case 'bigint':
                    case 'smallint':
                    case 'timestamp':
                        $field_type = 'number';
                        break;
                    case 'decimal':
                    case 'float':
                    case 'real':
                        $field_type = 'decimal';
                        break;
                    case 'datetime':
                        $field_type = 'datetime';
                        $default = "date('Y-m-d H:i:s')";
                        break;
                    case 'date':
                        $field_type = 'date';
                        $default = "date('Y-m-d')";
                        break;
                    case 'text':
                    case 'blob':
                        $field_type = 'textarea';
                        $default = "''";
                        break;
                    default:
                        $field_type = 'text';
                }
                $admin_form .= "\$form->{$field_type}('{$name}', '{$comment}')->default({$default});\n";
            }
            $this->alert("laravel-admin form filed generator for {$modelName}:");
            $this->info($admin_form);
        }

    }

    /**
     * Check if the table column contains the specified keywords of the array
     * @param string $haystack
     * @param array $needle
     * @return bool
     */
    private function check_column(string $haystack, array $needle)
    {
        foreach ($needle as $value) {
            if (strstr($haystack, $value) !== false) {
                return true;
            }
        }
        return false;
    }


    /**
     * Get the console command options.
     *
     * @return array
     */
    protected function getOptions()
    {
        return [
            ['model', null, InputOption::VALUE_REQUIRED,
                'The eloquent model that should be use as controller data source.',],
        ];
    }
}


1			<?php
2
3			namespace Encore\Admin\Console;
4
5			use Illuminate\Console\Command;
6			use Symfony\Component\Console\Input\InputArgument;
7			use Symfony\Component\Console\Input\InputOption;
8
9			class FormCommand extends Command
10			{
11			/**
12			* The console command name.
13			*
14			* @var string
15			*/
16			protected $name = 'admin:form';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'laravel-admin form filed generator';
24
25			/**
26			* Execute the console command.
27			*
28			* @return void
29			*/
30			public function handle()
31			{
32			$modelName = $this->option('model');
33			if (empty($modelName) \|\| !class_exists($modelName)) {
34			$this->error('Model does not exists !');
35			return false;
36			}
37
38			// use doctrine/dbal
39			$model = $this->laravel->make($modelName);
			0 ignored issues – show Bug introduced 2018-08-02 05:44 UTC by Report Bug Copy Issue Report It seems like `$modelName` defined by `$this->option('model')` on line `32` can also be of type `array`; however, `Illuminate\Contracts\Container\Container::make()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
40			$table = $model->getConnection()->getTablePrefix() . $model->getTable();
41			$schema = $model->getConnection()->getDoctrineSchemaManager($table);
42
43			if (!method_exists($schema, 'getDatabasePlatform')) {
44			$this->error('You need to require doctrine/dbal: ~2.3 in your own composer.json to get database columns. ');
45			$this->info('Using install command: composer require doctrine/dbal');
46			return false;
47
48			}
49
50			// custom mapping the types that doctrine/dbal does not support
51			$databasePlatform = $schema->getDatabasePlatform();
52			$databasePlatform->registerDoctrineTypeMapping('enum', 'string');
53			$databasePlatform->registerDoctrineTypeMapping('geometry', 'string');
54			$databasePlatform->registerDoctrineTypeMapping('geometrycollection', 'string');
55			$databasePlatform->registerDoctrineTypeMapping('linestring', 'string');
56			$databasePlatform->registerDoctrineTypeMapping('multilinestring', 'string');
57			$databasePlatform->registerDoctrineTypeMapping('multipoint', 'string');
58			$databasePlatform->registerDoctrineTypeMapping('multipolygon', 'string');
59			$databasePlatform->registerDoctrineTypeMapping('point', 'string');
60			$databasePlatform->registerDoctrineTypeMapping('polygon', 'string');
61			$databasePlatform->registerDoctrineTypeMapping('multipolygon', 'string');
62			$databasePlatform->registerDoctrineTypeMapping('multipolygon', 'string');
63
64			$database = null;
65			if (strpos($table, '.')) {
66			list($database, $table) = explode('.', $table);
67			}
68			$columns = $schema->listTableColumns($table, $database);
69
70			$admin_form = '';
71			if ($columns) {
72			foreach ($columns as $column) {
73			$name = $column->getName();
74			if (in_array($name, ['id', 'created_at', 'deleted_at'])) {
75			continue;
76			}
77			$type = $column->getType()->getName();
78			$comment = $column->getComment();
79			$default = $column->getDefault();
80			if ($default === '') {
81			$default = "''";
82			}
83
84			switch ($type) {
85			case 'boolean':
86			case 'bool':
87			$field_type = 'switch';
88			break;
89			case 'json':
90			case 'array':
91			case 'object':
92			$field_type = 'text';
93			break;
94			case 'string':
95			switch ($name) {
96			case $this->check_column($name, ['email']):
97			$field_type = 'email';
98			break;
99			case $this->check_column($name, ['password', 'pwd']):
100			$field_type = 'password';
101			break;
102			case $this->check_column($name, ['url', 'link', 'src', 'href']):
103			$field_type = 'url';
104			break;
105			case $this->check_column($name, ['ip']):
106			$field_type = 'ip';
107			break;
108			case $this->check_column($name, ['mobile', 'phone']):
109			$field_type = 'mobile';
110			break;
111			case $this->check_column($name, ['color', 'rgb']):
112			$field_type = 'color';
113			break;
114			case $this->check_column($name, ['image', 'img', 'avatar']) :
			0 ignored issues – show Coding Style introduced 2018-08-02 05:44 UTC by Report Bug Copy Issue Report There must be no space before the colon in a CASE statement As per the PSR-2 coding standard, there must not be a space in front of the colon in case statements. switch ($selector) { case "A": //right doSomething(); break; case "B" : //wrong doSomethingElse(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
115			$field_type = 'image';
116			break;
117			case $this->check_column($name, ['file', 'attachment']) :
			0 ignored issues – show Coding Style introduced 2018-08-02 05:44 UTC by Report Bug Copy Issue Report There must be no space before the colon in a CASE statement As per the PSR-2 coding standard, there must not be a space in front of the colon in case statements. switch ($selector) { case "A": //right doSomething(); break; case "B" : //wrong doSomethingElse(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
118			$field_type = 'file';
119			break;
120			default:
121			$field_type = 'text';
122			}
123			break;
124			case 'integer':
125			case 'bigint':
126			case 'smallint':
127			case 'timestamp':
128			$field_type = 'number';
129			break;
130			case 'decimal':
131			case 'float':
132			case 'real':
133			$field_type = 'decimal';
134			break;
135			case 'datetime':
136			$field_type = 'datetime';
137			$default = "date('Y-m-d H:i:s')";
138			break;
139			case 'date':
140			$field_type = 'date';
141			$default = "date('Y-m-d')";
142			break;
143			case 'text':
144			case 'blob':
145			$field_type = 'textarea';
146			$default = "''";
147			break;
148			default:
149			$field_type = 'text';
150			}
151			$admin_form .= "\$form->{$field_type}('{$name}', '{$comment}')->default({$default});\n";
152			}
153			$this->alert("laravel-admin form filed generator for {$modelName}:");
154			$this->info($admin_form);
155			}
156
157			}
158
159			/**
160			* Check if the table column contains the specified keywords of the array
161			* @param string $haystack
162			* @param array $needle
163			* @return bool
164			*/
165			private function check_column(string $haystack, array $needle)
166			{
167			foreach ($needle as $value) {
168			if (strstr($haystack, $value) !== false) {
169			return true;
170			}
171			}
172			return false;
173			}
174
175
176			/**
177			* Get the console command options.
178			*
179			* @return array
180			*/
181			protected function getOptions()
182			{
183			return [
184			['model', null, InputOption::VALUE_REQUIRED,
185			'The eloquent model that should be use as controller data source.',],
186			];
187			}
188			}
189

z-song / laravel-admin

Pull Request — master (#2262)

FormCommand::handle() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like